* [U-Boot] [PATCH] ARM: socfpga: Build sfp image only for Gen5 and Arria10 devices
@ 2019-03-20 15:40 Dalon Westergreen
2019-03-20 17:09 ` Marek Vasut
0 siblings, 1 reply; 3+ messages in thread
From: Dalon Westergreen @ 2019-03-20 15:40 UTC (permalink / raw)
To: u-boot
From: Dalon Westergreen <dalon.westergreen@intel.com>
The sfp file is only valid for Gen5 (Cyclone5 & Arria5) and Arria10
devices. The file should only be built for these devices.
Signed-off-by: Dalon Westergreen <dalon.westergreen@intel.com>
---
Kconfig | 3 ++-
scripts/Makefile.spl | 6 +++++-
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/Kconfig b/Kconfig
index 512c7beb89..305b265ed7 100644
--- a/Kconfig
+++ b/Kconfig
@@ -226,7 +226,8 @@ config BUILD_ROM
config BUILD_TARGET
string "Build target special images"
- default "u-boot-with-spl.sfp" if ARCH_SOCFPGA
+ default "u-boot-with-spl.sfp" if TARGET_SOCFPGA_ARRIA10
+ default "u-boot-with-spl.sfp" if TARGET_SOCFPGA_GEN5
default "u-boot-spl.kwb" if ARCH_MVEBU && SPL
default "u-boot-elf.srec" if RCAR_GEN3
default "u-boot.itb" if SPL_LOAD_FIT && ARCH_SUNXI
diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl
index 9d5921606e..592c5dfe57 100644
--- a/scripts/Makefile.spl
+++ b/scripts/Makefile.spl
@@ -212,7 +212,11 @@ ifdef CONFIG_SAMSUNG
ALL-y += $(obj)/$(BOARD)-spl.bin
endif
-ifdef CONFIG_ARCH_SOCFPGA
+ifdef CONFIG_TARGET_SOCFPGA_ARRIA10
+ALL-y += $(obj)/$(SPL_BIN).sfp
+endif
+
+ifdef CONFIG_TARGET_SOCFPGA_GEN5
ALL-y += $(obj)/$(SPL_BIN).sfp
endif
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] ARM: socfpga: Build sfp image only for Gen5 and Arria10 devices
2019-03-20 15:40 [U-Boot] [PATCH] ARM: socfpga: Build sfp image only for Gen5 and Arria10 devices Dalon Westergreen
@ 2019-03-20 17:09 ` Marek Vasut
2019-03-20 19:05 ` Dalon L Westergreen
0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2019-03-20 17:09 UTC (permalink / raw)
To: u-boot
On 3/20/19 4:40 PM, Dalon Westergreen wrote:
> From: Dalon Westergreen <dalon.westergreen@intel.com>
>
> The sfp file is only valid for Gen5 (Cyclone5 & Arria5) and Arria10
> devices. The file should only be built for these devices.
>
> Signed-off-by: Dalon Westergreen <dalon.westergreen@intel.com>
> ---
> Kconfig | 3 ++-
> scripts/Makefile.spl | 6 +++++-
> 2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Kconfig b/Kconfig
> index 512c7beb89..305b265ed7 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -226,7 +226,8 @@ config BUILD_ROM
>
> config BUILD_TARGET
> string "Build target special images"
> - default "u-boot-with-spl.sfp" if ARCH_SOCFPGA
> + default "u-boot-with-spl.sfp" if TARGET_SOCFPGA_ARRIA10
> + default "u-boot-with-spl.sfp" if TARGET_SOCFPGA_GEN5
> default "u-boot-spl.kwb" if ARCH_MVEBU && SPL
> default "u-boot-elf.srec" if RCAR_GEN3
> default "u-boot.itb" if SPL_LOAD_FIT && ARCH_SUNXI
> diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl
> index 9d5921606e..592c5dfe57 100644
> --- a/scripts/Makefile.spl
> +++ b/scripts/Makefile.spl
> @@ -212,7 +212,11 @@ ifdef CONFIG_SAMSUNG
> ALL-y += $(obj)/$(BOARD)-spl.bin
> endif
>
> -ifdef CONFIG_ARCH_SOCFPGA
> +ifdef CONFIG_TARGET_SOCFPGA_ARRIA10
ifneq ($(CONFIG_TARGET_SOCFPGA_GEN5)$(CONFIG_TARGET_SOCFPGA_ARRIA10),)
ALL-y ...
endif
Then you don't need to duplicate the entry.
> +ALL-y += $(obj)/$(SPL_BIN).sfp
> +endif
> +
> +ifdef CONFIG_TARGET_SOCFPGA_GEN5
> ALL-y += $(obj)/$(SPL_BIN).sfp
> endif
>
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] ARM: socfpga: Build sfp image only for Gen5 and Arria10 devices
2019-03-20 17:09 ` Marek Vasut
@ 2019-03-20 19:05 ` Dalon L Westergreen
0 siblings, 0 replies; 3+ messages in thread
From: Dalon L Westergreen @ 2019-03-20 19:05 UTC (permalink / raw)
To: u-boot
On Wed, 2019-03-20 at 18:09 +0100, Marek Vasut wrote:
> On 3/20/19 4:40 PM, Dalon Westergreen wrote:
> > From: Dalon Westergreen <dalon.westergreen@intel.com>
> >
> > The sfp file is only valid for Gen5 (Cyclone5 & Arria5) and Arria10
> > devices. The file should only be built for these devices.
> >
> > Signed-off-by: Dalon Westergreen <dalon.westergreen@intel.com>
> > ---
> > Kconfig | 3 ++-
> > scripts/Makefile.spl | 6 +++++-
> > 2 files changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/Kconfig b/Kconfig
> > index 512c7beb89..305b265ed7 100644
> > --- a/Kconfig
> > +++ b/Kconfig
> > @@ -226,7 +226,8 @@ config BUILD_ROM
> >
> > config BUILD_TARGET
> > string "Build target special images"
> > - default "u-boot-with-spl.sfp" if ARCH_SOCFPGA
> > + default "u-boot-with-spl.sfp" if TARGET_SOCFPGA_ARRIA10
> > + default "u-boot-with-spl.sfp" if TARGET_SOCFPGA_GEN5
> > default "u-boot-spl.kwb" if ARCH_MVEBU && SPL
> > default "u-boot-elf.srec" if RCAR_GEN3
> > default "u-boot.itb" if SPL_LOAD_FIT && ARCH_SUNXI
> > diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl
> > index 9d5921606e..592c5dfe57 100644
> > --- a/scripts/Makefile.spl
> > +++ b/scripts/Makefile.spl
> > @@ -212,7 +212,11 @@ ifdef CONFIG_SAMSUNG
> > ALL-y += $(obj)/$(BOARD)-spl.bin
> > endif
> >
> > -ifdef CONFIG_ARCH_SOCFPGA
> > +ifdef CONFIG_TARGET_SOCFPGA_ARRIA10
>
> ifneq ($(CONFIG_TARGET_SOCFPGA_GEN5)$(CONFIG_TARGET_SOCFPGA_ARRIA10),)
> ALL-y ...
> endif
>
> Then you don't need to duplicate the entry.
sure thing.
>
> > +ALL-y += $(obj)/$(SPL_BIN).sfp
> > +endif
> > +
> > +ifdef CONFIG_TARGET_SOCFPGA_GEN5
> > ALL-y += $(obj)/$(SPL_BIN).sfp
> > endif
> >
> >
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-20 19:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-20 15:40 [U-Boot] [PATCH] ARM: socfpga: Build sfp image only for Gen5 and Arria10 devices Dalon Westergreen
2019-03-20 17:09 ` Marek Vasut
2019-03-20 19:05 ` Dalon L Westergreen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox