public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Urja Rannikko <urjaman@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] rk3288-board: remove pinctrl call for debug uart
Date: Fri, 22 Mar 2019 19:14:34 +0000	[thread overview]
Message-ID: <20190322191436.6268-3-urjaman@gmail.com> (raw)
In-Reply-To: <20190322191436.6268-1-urjaman@gmail.com>

This failed and caused a boot failure on c201, and afaik
the pins should be setup by the new pinctrl driver.

Signed-off-by: Urja Rannikko <urjaman@gmail.com>
---
 arch/arm/mach-rockchip/rk3288-board.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/arch/arm/mach-rockchip/rk3288-board.c b/arch/arm/mach-rockchip/rk3288-board.c
index 9c4f7f219f..f5df44dab1 100644
--- a/arch/arm/mach-rockchip/rk3288-board.c
+++ b/arch/arm/mach-rockchip/rk3288-board.c
@@ -321,7 +321,6 @@ int board_early_init_f(void)
 {
 	const uintptr_t GRF_SOC_CON0 = 0xff770244;
 	const uintptr_t GRF_SOC_CON2 = 0xff77024c;
-	struct udevice *pinctrl;
 	struct udevice *dev;
 	int ret;
 
@@ -335,18 +334,7 @@ int board_early_init_f(void)
 		debug("CLK init failed: %d\n", ret);
 		return ret;
 	}
-	ret = uclass_get_device(UCLASS_PINCTRL, 0, &pinctrl);
-	if (ret) {
-		debug("%s: Cannot find pinctrl device\n", __func__);
-		return ret;
-	}
 
-	/* Enable debug UART */
-	ret = pinctrl_request_noflags(pinctrl, PERIPH_ID_UART_DBG);
-	if (ret) {
-		debug("%s: Failed to set up console UART\n", __func__);
-		return ret;
-	}
 	rk_setreg(GRF_SOC_CON2, 1 << 0);
 
 	/*
-- 
2.21.0

  parent reply	other threads:[~2019-03-22 19:14 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-22 19:14 [U-Boot] [PATCH 0/4] Veyron Speedy / ASUS C201 fixes Urja Rannikko
2019-03-22 19:14 ` [U-Boot] [PATCH 1/4] pinctrl: exit pinconfig_post_bind if there are no subnodes Urja Rannikko
2019-03-30 21:18   ` Simon Glass
2019-04-21 18:41   ` [U-Boot] [U-Boot, " Philipp Tomsich
2019-04-23 14:33   ` Philipp Tomsich
2019-03-22 19:14 ` Urja Rannikko [this message]
2019-03-30 21:18   ` [U-Boot] [PATCH 2/4] rk3288-board: remove pinctrl call for debug uart Simon Glass
2019-03-31 21:54     ` Urja Rannikko
2019-04-21 18:41   ` [U-Boot] [U-Boot, " Philipp Tomsich
2019-04-23 14:33   ` Philipp Tomsich
2019-03-22 19:14 ` [U-Boot] [PATCH 3/4] rk3288-board: cosmetic: document selecting RK PWM Urja Rannikko
2019-03-30 21:18   ` Simon Glass
2019-03-31 21:46     ` Urja Rannikko
2019-03-22 19:14 ` [U-Boot] [PATCH 4/4] dw_mmc: turn on the IO supply Urja Rannikko
2019-03-29 14:09   ` Heiko Stübner
2019-03-31 19:45     ` Urja Rannikko
2019-04-02  8:25       ` Heiko Stuebner
2019-04-01 17:44   ` [U-Boot] [PATCH v2] " Urja Rannikko
2019-04-11 20:07     ` Urja Rannikko
2019-05-13 12:25       ` Urja Rannikko
2019-05-13 12:54     ` Heiko Stuebner
2019-05-13 13:25       ` [U-Boot] [PATCH v3] " Urja Rannikko
2019-05-18 16:08         ` Simon Glass
2019-05-20  7:03         ` Peng Fan
2019-07-26  7:06           ` Kever Yang
2019-07-30  0:47             ` Peng Fan
2019-03-29 13:56 ` [U-Boot] [PATCH 0/4] Veyron Speedy / ASUS C201 fixes Heiko Stübner
2019-03-31 19:34   ` Urja Rannikko
2019-03-31 20:44     ` Heiko Stübner
2019-03-31 22:19 ` Urja Rannikko
2019-04-11 20:14 ` Urja Rannikko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190322191436.6268-3-urjaman@gmail.com \
    --to=urjaman@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox