From: Thierry Reding <thierry.reding@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 01/13] libfdt: Add phandle generation helper
Date: Mon, 25 Mar 2019 08:27:08 +0100 [thread overview]
Message-ID: <20190325072708.GA22420@ulmo> (raw)
In-Reply-To: <CAPnjgZ0Z9tySBOMEgJghCJxnkW4eGUT0SLq0+YbHZGApHEvg0Q@mail.gmail.com>
On Fri, Mar 22, 2019 at 03:52:59PM +0800, Simon Glass wrote:
> On Fri, 22 Mar 2019 at 02:10, Thierry Reding <thierry.reding@gmail.com> wrote:
> >
> > From: Thierry Reding <treding@nvidia.com>
> >
> > The new fdt_generate_phandle() function can be used to generate a new,
> > unused phandle given a specific device tree blob. The implementation is
> > somewhat naive in that it simply walks the entire device tree to find
> > the highest phandle value and then returns a phandle value one higher
> > than that. A more clever implementation might try to find holes in the
> > current set of phandle values and fill them. But this implementation is
> > relatively simple and works reliably.
> >
> > Also add a test that validates that phandles generated by this new API
> > are indeed unique.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> > Changes in v3:
> > - update to latest upstream commit
> >
> > lib/libfdt/fdt_ro.c | 31 +++++++++++++++++++++++++++++++
> > scripts/dtc/libfdt/fdt_ro.c | 31 +++++++++++++++++++++++++++++++
> > scripts/dtc/libfdt/libfdt.h | 19 +++++++++++++++++++
> > scripts/dtc/libfdt/libfdt_env.h | 1 +
> > 4 files changed, 82 insertions(+)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Looks like this was reverted again upstream (for, in my opinion, dubious
reasons). Shall I just move it to fdtdec again and we can convert to
whatever we end up with upstream, if anything, later on?
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190325/98b657b1/attachment.sig>
next prev parent reply other threads:[~2019-03-25 7:27 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 18:09 [U-Boot] [PATCH v3 00/13] ARM: tegra: Add support for framebuffer carveouts Thierry Reding
2019-03-21 18:09 ` [U-Boot] [PATCH v3 01/13] libfdt: Add phandle generation helper Thierry Reding
2019-03-22 7:52 ` Simon Glass
2019-03-25 7:27 ` Thierry Reding [this message]
2019-03-30 21:18 ` Simon Glass
2019-04-12 21:50 ` sjg at google.com
2019-03-21 18:09 ` [U-Boot] [PATCH v3 02/13] fdtdec: Add cpu_to_fdt_{addr, size}() macros Thierry Reding
2019-04-12 21:48 ` Simon Glass
2019-03-21 18:10 ` [U-Boot] [PATCH v3 03/13] fdtdec: Add fdt_{addr, size}_unpack() helpers Thierry Reding
2019-03-22 7:53 ` Simon Glass
2019-03-22 8:31 ` Thierry Reding
2019-04-12 21:45 ` Simon Glass
2019-04-15 8:18 ` Thierry Reding
2019-03-21 18:10 ` [U-Boot] [PATCH v3 04/13] fdtdec: Implement fdtdec_set_phandle() Thierry Reding
2019-03-22 7:53 ` Simon Glass
2019-03-22 8:34 ` Thierry Reding
2019-03-23 0:52 ` Simon Glass
2019-04-12 21:50 ` sjg at google.com
2019-03-21 18:10 ` [U-Boot] [PATCH v3 05/13] fdtdec: Implement fdtdec_add_reserved_memory() Thierry Reding
2019-04-12 21:50 ` sjg at google.com
2019-03-21 18:10 ` [U-Boot] [PATCH v3 06/13] fdtdec: Implement carveout support functions Thierry Reding
2019-04-12 21:50 ` sjg at google.com
2019-03-21 18:10 ` [U-Boot] [PATCH v3 07/13] fdtdec: Add Kconfig symbol for tests Thierry Reding
2019-03-22 7:53 ` Simon Glass
2019-04-12 21:50 ` sjg at google.com
2019-03-21 18:10 ` [U-Boot] [PATCH v3 08/13] fdtdec: test: Fix build warning Thierry Reding
2019-03-22 7:53 ` Simon Glass
2019-04-12 21:49 ` sjg at google.com
2019-03-21 18:10 ` [U-Boot] [PATCH v3 09/13] fdtdec: test: Use compound statement macros Thierry Reding
2019-03-22 7:53 ` Simon Glass
2019-04-12 21:49 ` sjg at google.com
2019-03-21 18:10 ` [U-Boot] [PATCH v3 10/13] fdtdec: test: Add carveout tests Thierry Reding
2019-03-22 7:53 ` Simon Glass
2019-03-22 8:45 ` Thierry Reding
2019-04-12 21:49 ` sjg at google.com
2019-03-21 18:10 ` [U-Boot] [PATCH v3 11/13] sandbox: Enable fdtdec tests Thierry Reding
2019-03-22 7:53 ` Simon Glass
2019-04-12 21:49 ` sjg at google.com
2019-03-21 18:10 ` [U-Boot] [PATCH v3 12/13] p2371-2180: Add support for framebuffer carveouts Thierry Reding
2019-03-22 7:53 ` Simon Glass
2019-04-12 2:12 ` Simon Glass
2019-04-15 8:20 ` Thierry Reding
2019-03-21 18:10 ` [U-Boot] [PATCH v3 13/13] p2771-0000: " Thierry Reding
2019-03-22 7:53 ` Simon Glass
2019-04-12 2:12 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325072708.GA22420@ulmo \
--to=thierry.reding@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox