[U-Boot] [REGRESSION: PATCH 34/34] drivers/net/fec: phy_init: remove redundant logic

[Lukasz Majewski <lukma@denx.de>]

Dear Tom, Marcel, Stefano

> Hi Marcel,
> 
> > Hi Stefano
> > 
> > On Wed, 2019-03-13 at 08:28 +0000, sbabic at denx.de wrote:  
> > > > The phy_connect_dev(...) function from phy.c does all the
> > > > handling (inclusive catching fixed-link).
> > > > So we drop here the single steps and call just
> > > > phy_connect_dev(...).
> > > > Signed-off-by: Hannes Schmelzer
> > > > <hannes.schmelzer@br-automation.com    
> > > > >    
> > > > Acked-by: Joe Hershberger <joe.hershberger@ni.com>    
> > > 
> > > Applied to u-boot-imx, master, thanks !
> > > 
> > > Best regards,
> > > Stefano Babic    
> > 
> > Unfortunately, this commit broke Ethernet on the Vybrid. When
> > re-basing my Colibri VF50/VF61 clean-up patch set ("colibri vybrid
> > fixes, device tree enablement and driver model conversion") I
> > noticed that Ethernet no longer works giving the following error
> > messages:
> > 
> > Net:   Could not get PHY for FEC0: addr -19
> > eth-1: fec at 400d1000
> > Colibri VFxx # dhcp
> > Could not get PHY for FEC0: addr -19
> > Could not get PHY for FEC0: addr -19
> > Could not get PHY for FEC0: addr -19
> > Could not get PHY for FEC0: addr -19
> > No ethernet found.
> > Could not get PHY for FEC0: addr -19
> > Colibri VFxx # 
> > 
> > Bisecting points to this commit and reverting it indeed makes it
> > work again.
> > 
> > Has anybody else seen a similar issue (e.g. @Lukasz on pcm052)?  
> 
> I did not checked yet - as I was waiting for the code to settle down
> to mainline (after the v2019.04 u-boot release).
> 
> I will check it on bk4.

Maybe not on BK4, but surely on (HSC):
CPU:   Freescale i.MX53 rev2.1 at 800 MHz

=> dhcp
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
No ethernet found.
Could not get PHY for FEC0: addr -19

I can confirm the error.

So I do expect that we have some more IMX boards broken (imx53, vybrid).

I think that it would be best to revert this patch before v2019.04
release and look for clean up opportunities afterwards.



> 
> > 
> > Cheers
> > 
> > Marcel  
> 
> 
> 
> 
> Best regards,
> 
> Lukasz Majewski
> 
> --
> 
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
> lukma at denx.de




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190328/38c557e0/attachment.sig>