From: Eugeniu Rosca <roscaeugeniu@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: rmobile: rcar-gen2: Activate bootm_size
Date: Sat, 30 Mar 2019 22:01:22 +0100 [thread overview]
Message-ID: <20190330210122.GA6158@x230> (raw)
In-Reply-To: <20190330064734.11989-1-marek.vasut+renesas@gmail.com>
Hi Marek,
On Sat, Mar 30, 2019 at 07:47:34AM +0100, Marek Vasut wrote:
> Commit d245059ff797 ("ARM: rmobile: rcar-gen3: Activate bootm_size")
> only fixed the superfluous CONFIG_SYS_BOOTMAPSZ for R-Car Gen3 [..]
I don't think 'superfluous' is the best wording here, since
(according to its README description) CONFIG_SYS_BOOTMAPSZ
invalidates/overrides the user-provided 'bootm_size' by taking
precedence over the latter.
But I agree with the contents of this patch, since it resembles the
aforementioned commit and brings more harmony between Gen2 and Gen3.
I don't have any Gen2 board to test it, but from code review standpoint:
Reviewed-by: Eugeniu Rosca <rosca.eugeniu@gmail.com>
Best regards,
Eugeniu.
prev parent reply other threads:[~2019-03-30 21:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-30 6:47 [U-Boot] [PATCH] ARM: rmobile: rcar-gen2: Activate bootm_size Marek Vasut
2019-03-30 21:01 ` Eugeniu Rosca [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190330210122.GA6158@x230 \
--to=roscaeugeniu@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox