* [U-Boot] [PATCH] ARM: rmobile: rcar-gen2: Activate bootm_size
@ 2019-03-30 6:47 Marek Vasut
2019-03-30 21:01 ` Eugeniu Rosca
0 siblings, 1 reply; 2+ messages in thread
From: Marek Vasut @ 2019-03-30 6:47 UTC (permalink / raw)
To: u-boot
Commit d245059ff797 ("ARM: rmobile: rcar-gen3: Activate bootm_size")
only fixed the superfluous CONFIG_SYS_BOOTMAPSZ for R-Car Gen3, even
though it listed all affected boards. Apply the same fix to Gen2.
Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Fixes: d245059ff797 ("ARM: rmobile: rcar-gen3: Activate bootm_size")
Cc: Eugeniu Rosca <erosca@de.adit-jv.com>
---
include/configs/rcar-gen2-common.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/configs/rcar-gen2-common.h b/include/configs/rcar-gen2-common.h
index 9213d33e21..7f72ff2e11 100644
--- a/include/configs/rcar-gen2-common.h
+++ b/include/configs/rcar-gen2-common.h
@@ -38,7 +38,6 @@
#define CONFIG_SYS_MONITOR_BASE 0x00000000
#define CONFIG_SYS_MONITOR_LEN (256 * 1024)
#define CONFIG_SYS_MALLOC_LEN (1 * 1024 * 1024)
-#define CONFIG_SYS_BOOTMAPSZ (8 * 1024 * 1024)
/* ENV setting */
#define CONFIG_ENV_ADDR 0xC0000
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] ARM: rmobile: rcar-gen2: Activate bootm_size
2019-03-30 6:47 [U-Boot] [PATCH] ARM: rmobile: rcar-gen2: Activate bootm_size Marek Vasut
@ 2019-03-30 21:01 ` Eugeniu Rosca
0 siblings, 0 replies; 2+ messages in thread
From: Eugeniu Rosca @ 2019-03-30 21:01 UTC (permalink / raw)
To: u-boot
Hi Marek,
On Sat, Mar 30, 2019 at 07:47:34AM +0100, Marek Vasut wrote:
> Commit d245059ff797 ("ARM: rmobile: rcar-gen3: Activate bootm_size")
> only fixed the superfluous CONFIG_SYS_BOOTMAPSZ for R-Car Gen3 [..]
I don't think 'superfluous' is the best wording here, since
(according to its README description) CONFIG_SYS_BOOTMAPSZ
invalidates/overrides the user-provided 'bootm_size' by taking
precedence over the latter.
But I agree with the contents of this patch, since it resembles the
aforementioned commit and brings more harmony between Gen2 and Gen3.
I don't have any Gen2 board to test it, but from code review standpoint:
Reviewed-by: Eugeniu Rosca <rosca.eugeniu@gmail.com>
Best regards,
Eugeniu.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-30 21:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-30 6:47 [U-Boot] [PATCH] ARM: rmobile: rcar-gen2: Activate bootm_size Marek Vasut
2019-03-30 21:01 ` Eugeniu Rosca
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox