From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: dwc3: Handle case where setup_phy is not needed
Date: Mon, 1 Apr 2019 09:32:43 +0200 [thread overview]
Message-ID: <20190401093243.655b20e4@jawa> (raw)
In-Reply-To: <1554099055-12817-1-git-send-email-siva.durga.paladugu@xilinx.com>
Hi Siva Durga Prasad Paladugu,
> If CONFIG_PHY is not enabled then the dwc3_setup_phy()
> returns ENOTSUPP which can be still valid and intentional
^^^^^^^^^^^^^^^^^^^^^^^^^^^ - could you
elaborate on this a bit more?
What is the use case when -ENOTSUPP is valid and intentional ?
> so modify error check to handle this -ENOTSUPP.
>
> Signed-off-by: Siva Durga Prasad Paladugu
> <siva.durga.paladugu@xilinx.com> ---
> drivers/usb/dwc3/dwc3-generic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-generic.c
> b/drivers/usb/dwc3/dwc3-generic.c index 3e6c494..a261d8d 100644
> --- a/drivers/usb/dwc3/dwc3-generic.c
> +++ b/drivers/usb/dwc3/dwc3-generic.c
> @@ -47,7 +47,7 @@ static int dwc3_generic_peripheral_probe(struct
> udevice *dev) struct dwc3 *dwc3 = &priv->dwc3;
>
> rc = dwc3_setup_phy(dev, &priv->phys, &priv->num_phys);
> - if (rc)
> + if (rc && rc != -ENOTSUPP)
> return rc;
>
> dwc3->regs = map_physmem(priv->base, DWC3_OTG_REGS_END,
> MAP_NOCACHE);
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190401/d89f7183/attachment.sig>
next prev parent reply other threads:[~2019-04-01 7:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 6:10 [U-Boot] [PATCH] usb: dwc3: Handle case where setup_phy is not needed Siva Durga Prasad Paladugu
2019-04-01 7:32 ` Lukasz Majewski [this message]
2019-04-01 10:23 ` Siva Durga Prasad Paladugu
2019-04-01 10:34 ` Lukasz Majewski
2019-04-01 10:38 ` Siva Durga Prasad Paladugu
2019-04-01 10:39 ` Michal Simek
2019-05-28 10:06 ` Siva Durga Prasad Paladugu
2019-06-06 10:13 ` Siva Durga Prasad Paladugu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401093243.655b20e4@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox