From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 0/4] configs: rk3288: Tinker Board SPL file must fit into 32 KiB
Date: Tue, 2 Apr 2019 13:47:33 -0400 [thread overview]
Message-ID: <20190402174733.GT4664@bill-the-cat> (raw)
In-Reply-To: <34f2f8ec-04a3-9309-5478-f691ab2f5a6f@gmx.de>
On Tue, Apr 02, 2019 at 07:33:42PM +0200, Heinrich Schuchardt wrote:
> On 4/2/19 7:29 PM, Tom Rini wrote:
> > On Tue, Apr 02, 2019 at 07:19:03PM +0200, Heinrich Schuchardt wrote:
> >
> >> The SPL image for the Tinker Board has to fit into 32 KiB. This includes
> >> up to 2 KiB for the file header.
> >>
> >> A new configuration variable CONFIG_SPL_SIZE_LIMIT is introduced to define
> >> the board specific limit.
> >>
> >> A common Makefile function is used for this test and the test against
> >> CONFIG_BOARD_SIZE_LIMIT.
> >>
> >> Move the board size check from arch/arm/mach-imx/Makefile to Makefile.
> >
> > I'm sorry you weren't Cc'd on Simon's thread where we're trying to
> > improve the size check stuff to be generic enough to use everywhere. We
> > can't generically use a shell script as we need to know some processed
> > values too. I don't know if Simon got to the point of writing a C based
> > helper to use or not.
> >
>
> Hello Tom,
>
> could you, please, provide a link to the thread.
https://patchwork.ozlabs.org/patch/1050465/ (and no, I didn't apply it,
I forgot to delete my email before I sent out that batch of applieds).
> Is the test prior to my patch incorrect? Or do you want to imply that
> after my patch we get different results?
The problem is that I don't want to make wider use of the shell checking
notion. It's not as complete as we'd like and can't be used on as many
platforms as need it either, due to needing cpp to actually determine
values in some cases.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190402/1a067864/attachment.sig>
next prev parent reply other threads:[~2019-04-02 17:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 17:19 [U-Boot] [PATCH v4 0/4] configs: rk3288: Tinker Board SPL file must fit into 32 KiB Heinrich Schuchardt
2019-04-02 17:19 ` [U-Boot] [PATCH v4 1/4] Makefile: reusable function for BOARD_SIZE_CHECK Heinrich Schuchardt
2019-06-07 22:04 ` Tom Rini
2019-04-02 17:19 ` [U-Boot] [PATCH v4 2/4] imx: move BOARD_SIZE_CHECK to main Makefile Heinrich Schuchardt
2019-04-04 20:53 ` Heinrich Schuchardt
2019-04-05 13:05 ` Fabio Estevam
2019-04-07 21:10 ` Heinrich Schuchardt
2019-06-07 22:04 ` Tom Rini
2019-04-02 17:19 ` [U-Boot] [PATCH v4 3/4] configs: define CONFIG_SPL_SIZE_LIMIT Heinrich Schuchardt
2019-06-07 22:05 ` Tom Rini
2019-06-07 22:13 ` Fabio Estevam
2019-06-08 0:38 ` Tom Rini
2019-04-02 17:19 ` [U-Boot] [PATCH v4 4/4] configs: rk3288: Tinker Board SPL file must fit into 32 KiB Heinrich Schuchardt
2019-06-07 22:05 ` Tom Rini
2019-04-02 17:29 ` [U-Boot] [PATCH v4 0/4] " Tom Rini
2019-04-02 17:33 ` Heinrich Schuchardt
2019-04-02 17:47 ` Tom Rini [this message]
2019-04-02 18:17 ` Heinrich Schuchardt
2019-04-02 18:08 ` Simon Goldschmidt
2019-04-03 0:59 ` Kever Yang
2019-04-03 6:19 ` Heinrich Schuchardt
2019-04-03 20:50 ` Benoît Thébaudeau
2019-04-18 20:12 ` Simon Goldschmidt
2019-04-22 14:36 ` Tom Rini
2019-04-22 18:40 ` Simon Goldschmidt
2019-04-22 19:29 ` Tom Rini
2019-04-22 19:50 ` Simon Goldschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402174733.GT4664@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox