From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 3 Apr 2019 07:29:22 -0400 Subject: [U-Boot] Riscv: CONFIG_DEFAULT_DEVICE_TREE failures In-Reply-To: References: <20190330061548.GE9699@bc.grid.coop> <20190331220230.GB4664@bill-the-cat> <20190403111843.GD4664@bill-the-cat> Message-ID: <20190403112922.GE4664@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Apr 03, 2019 at 08:21:34PM +0900, Masahiro Yamada wrote: > On Wed, Apr 3, 2019 at 8:19 PM Tom Rini wrote: > > > > On Tue, Apr 02, 2019 at 03:16:10PM -0500, Troy Benjegerdes wrote: > > > > > > > On Mar 31, 2019, at 5:02 PM, Tom Rini wrote: > > > > > > > > On Fri, Mar 29, 2019 at 11:15:48PM -0700, Troy Benjegerdes wrote: > > > > > > > >> I attempted to merge in the latest master branch into > > > >> https://github.com/sifive/u-boot/tree/sandbox and I got > > > >> the following error, which seems somewhat broken.. > > > >> > > > >> > > > >> Device Tree Source is not correctly specified. > > > >> Please define 'CONFIG_DEFAULT_DEVICE_TREE' > > > >> or build with 'DEVICE_TREE=' argument > > > >> > > > >> dts/Makefile:28: recipe for target 'arch/riscv/dts/fu540.dtb' failed > > > >> > > > >> > > > >> Does anyone have any idea what would have caused that? > > > >> > > > >> Also any feedback or pointers on why the serial_sifive.c > > > >> driver with CONFIG_DM_SERIAL would not work, but serial_hifive.c > > > >> without CONFIG_DM_SERIAL does seem to work might be appreciated. > > > > > > > > You'll need to do something like > > > > > > > > commit 89c2b5c02049aea746b1edee0b4e1d8519dec2f4 > > > > Author: Masahiro Yamada > > > > Date: Thu Mar 14 14:58:33 2019 +0900 > > > > > > > > ARM: fix arch/arm/dts/Makefile > > > > > > > > Since commit 27cb7300ffda ("Ensure device tree DTS is compiled"), > > > > build succeeds irrespective of the correctness of Makefile. > > > > > > > > In fact, you can compile any defconfig without adding any entry in > > > > arch/*/dts/Makefile. > > > > > > > > As a result, a lot of wrong code have been merged unnoticed. > > > > > > > > I am going to revert that commit, and lots of hidden issues have > > > > come to light: > > > > > > > > [1] Typos > > > > > > > > armada-3720-uDPU.dts, sun8i-a83t-tbs-a711.dts > > > > > > > > use the extension ".dts" instead of ".dtb" > > > > > > > > [2] DTB is associated to undefined CONFIG option > > > > > > > > For example, mx6sllevk_defconfig defines CONFIG_MX6SLL, but > > > > associates its device tree to CONFIG_MX6SL, which is undefined. > > > > > > > > [3] Lots of entries are missing > > > > > > > > Signed-off-by: Masahiro Yamada > > > > Reviewed-by: Chris Packham > > > > [trini: add imx6ul pico dtbs] > > > > Signed-off-by: Tom Rini > > > > > > > > But to arch/riscv/dts/Makefile > > > > > > I ended up reverting that commit, and we now have > > > https://github.com/sifive/u-boot/tree/sandbox booting to a prompt > > > based on upstream master. > > > > Note that you just need something like: > > obj-y += first.dtb \ > > second.dtb > > It should be: > > dtb-y += first.dtb \ > second.dtb Ah right, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: