* [U-Boot] [PATCH] ARM: dts: i.MX6ULL: U-Boot specific dts for u-boot, dm-spl
@ 2019-04-07 18:32 Parthiban Nallathambi
2019-04-08 13:53 ` Marcel Ziswiler
2019-06-10 9:41 ` [U-Boot] [PATCH] ARM: dts: i.MX6ULL: U-Boot specific dts for u-boot, sbabic at denx.de
0 siblings, 2 replies; 4+ messages in thread
From: Parthiban Nallathambi @ 2019-04-07 18:32 UTC (permalink / raw)
To: u-boot
u-boot,dm-spl property is specific to U-Boot, so created one
for i.MX6ULL platforms.
Signed-off-by: Parthiban Nallathambi <parthitce@gmail.com>
---
arch/arm/dts/imx6ull-u-boot.dtsi | 34 ++++++++++++++++++++++++++++++++
board/phytec/pcl063/MAINTAINERS | 1 +
2 files changed, 35 insertions(+)
create mode 100644 arch/arm/dts/imx6ull-u-boot.dtsi
diff --git a/arch/arm/dts/imx6ull-u-boot.dtsi b/arch/arm/dts/imx6ull-u-boot.dtsi
new file mode 100644
index 0000000000..74ca95fa2c
--- /dev/null
+++ b/arch/arm/dts/imx6ull-u-boot.dtsi
@@ -0,0 +1,34 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2019 Parthiban Nallathambi <parthitce@gmail.com>
+ */
+
+/ {
+ soc {
+ u-boot,dm-spl;
+ };
+};
+
+&aips1 {
+ u-boot,dm-spl;
+};
+
+&aips2 {
+ u-boot,dm-spl;
+};
+
+&aips3 {
+ u-boot,dm-spl;
+};
+
+&gpio1 {
+ u-boot,dm-spl;
+};
+
+&gpio4 {
+ u-boot,dm-spl;
+};
+
+&iomuxc {
+ u-boot,dm-spl;
+};
diff --git a/board/phytec/pcl063/MAINTAINERS b/board/phytec/pcl063/MAINTAINERS
index 70e03cfe71..7d9978c339 100644
--- a/board/phytec/pcl063/MAINTAINERS
+++ b/board/phytec/pcl063/MAINTAINERS
@@ -3,6 +3,7 @@ M: Martyn Welch <martyn.welch@collabora.com>
M: Parthiban Nallathambi <parthitce@gmail.com>
S: Maintained
F: arch/arm/dts/imx6ul-phycore-segin.dts
+F: arch/arm/dts/imx6ull-u-boot.dtsi
F: arch/arm/dts/imx6ull-phycore-segin.dts
F: arch/arm/dts/pcl063-common.dtsi
F: board/phytec/pcl063/
--
2.17.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] ARM: dts: i.MX6ULL: U-Boot specific dts for u-boot, dm-spl
2019-04-07 18:32 [U-Boot] [PATCH] ARM: dts: i.MX6ULL: U-Boot specific dts for u-boot, dm-spl Parthiban Nallathambi
@ 2019-04-08 13:53 ` Marcel Ziswiler
2019-04-09 16:57 ` Parthiban Nallathambi
2019-06-10 9:41 ` [U-Boot] [PATCH] ARM: dts: i.MX6ULL: U-Boot specific dts for u-boot, sbabic at denx.de
1 sibling, 1 reply; 4+ messages in thread
From: Marcel Ziswiler @ 2019-04-08 13:53 UTC (permalink / raw)
To: u-boot
Hi Parthiban
On Sun, 2019-04-07 at 20:32 +0200, Parthiban Nallathambi wrote:
> u-boot,dm-spl property is specific to U-Boot, so created one
> for i.MX6ULL platforms.
What exactly makes you so sure others do want your exact configuration
thereof as well? Shouldn't you make this board specific instead like
e.g. done elsewhere [1]?
[1]
https://git.denx.de/?p=u-boot.git;a=blob;f=arch/arm/dts/am335x-chiliboard-u-boot.dtsi;h=4f9d3080394be001f79731b736c5eac934c07ebf;hb=HEAD
Cheers
Marcel
> Signed-off-by: Parthiban Nallathambi <parthitce@gmail.com>
> ---
> arch/arm/dts/imx6ull-u-boot.dtsi | 34
> ++++++++++++++++++++++++++++++++
> board/phytec/pcl063/MAINTAINERS | 1 +
> 2 files changed, 35 insertions(+)
> create mode 100644 arch/arm/dts/imx6ull-u-boot.dtsi
>
> diff --git a/arch/arm/dts/imx6ull-u-boot.dtsi b/arch/arm/dts/imx6ull-
> u-boot.dtsi
> new file mode 100644
> index 0000000000..74ca95fa2c
> --- /dev/null
> +++ b/arch/arm/dts/imx6ull-u-boot.dtsi
> @@ -0,0 +1,34 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2019 Parthiban Nallathambi <parthitce@gmail.com>
> + */
> +
> +/ {
> + soc {
> + u-boot,dm-spl;
> + };
> +};
> +
> +&aips1 {
> + u-boot,dm-spl;
> +};
> +
> +&aips2 {
> + u-boot,dm-spl;
> +};
> +
> +&aips3 {
> + u-boot,dm-spl;
> +};
> +
> +&gpio1 {
> + u-boot,dm-spl;
> +};
> +
> +&gpio4 {
> + u-boot,dm-spl;
> +};
> +
> +&iomuxc {
> + u-boot,dm-spl;
> +};
> diff --git a/board/phytec/pcl063/MAINTAINERS
> b/board/phytec/pcl063/MAINTAINERS
> index 70e03cfe71..7d9978c339 100644
> --- a/board/phytec/pcl063/MAINTAINERS
> +++ b/board/phytec/pcl063/MAINTAINERS
> @@ -3,6 +3,7 @@ M: Martyn Welch <martyn.welch@collabora.com>
> M: Parthiban Nallathambi <parthitce@gmail.com>
> S: Maintained
> F: arch/arm/dts/imx6ul-phycore-segin.dts
> +F: arch/arm/dts/imx6ull-u-boot.dtsi
> F: arch/arm/dts/imx6ull-phycore-segin.dts
> F: arch/arm/dts/pcl063-common.dtsi
> F: board/phytec/pcl063/
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] ARM: dts: i.MX6ULL: U-Boot specific dts for u-boot, dm-spl
2019-04-08 13:53 ` Marcel Ziswiler
@ 2019-04-09 16:57 ` Parthiban Nallathambi
0 siblings, 0 replies; 4+ messages in thread
From: Parthiban Nallathambi @ 2019-04-09 16:57 UTC (permalink / raw)
To: u-boot
Hi Marcel,
On 4/8/19 3:53 PM, Marcel Ziswiler wrote:
> Hi Parthiban
>
> On Sun, 2019-04-07 at 20:32 +0200, Parthiban Nallathambi wrote:
>> u-boot,dm-spl property is specific to U-Boot, so created one
>> for i.MX6ULL platforms.
>
> What exactly makes you so sure others do want your exact configuration
> thereof as well? Shouldn't you make this board specific instead like
> e.g. done elsewhere [1]?
Sure, thanks for pointing it. I will move them to my board specific
files.
Thanks,
Parthiban N
>
> [1]
> https://git.denx.de/?p=u-boot.git;a=blob;f=arch/arm/dts/am335x-chiliboard-u-boot.dtsi;h=4f9d3080394be001f79731b736c5eac934c07ebf;hb=HEAD
>
> Cheers
>
> Marcel
>
>> Signed-off-by: Parthiban Nallathambi <parthitce@gmail.com>
>> ---
>> arch/arm/dts/imx6ull-u-boot.dtsi | 34
>> ++++++++++++++++++++++++++++++++
>> board/phytec/pcl063/MAINTAINERS | 1 +
>> 2 files changed, 35 insertions(+)
>> create mode 100644 arch/arm/dts/imx6ull-u-boot.dtsi
>>
>> diff --git a/arch/arm/dts/imx6ull-u-boot.dtsi b/arch/arm/dts/imx6ull-
>> u-boot.dtsi
>> new file mode 100644
>> index 0000000000..74ca95fa2c
>> --- /dev/null
>> +++ b/arch/arm/dts/imx6ull-u-boot.dtsi
>> @@ -0,0 +1,34 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>> +/*
>> + * Copyright (C) 2019 Parthiban Nallathambi <parthitce@gmail.com>
>> + */
>> +
>> +/ {
>> + soc {
>> + u-boot,dm-spl;
>> + };
>> +};
>> +
>> +&aips1 {
>> + u-boot,dm-spl;
>> +};
>> +
>> +&aips2 {
>> + u-boot,dm-spl;
>> +};
>> +
>> +&aips3 {
>> + u-boot,dm-spl;
>> +};
>> +
>> +&gpio1 {
>> + u-boot,dm-spl;
>> +};
>> +
>> +&gpio4 {
>> + u-boot,dm-spl;
>> +};
>> +
>> +&iomuxc {
>> + u-boot,dm-spl;
>> +};
>> diff --git a/board/phytec/pcl063/MAINTAINERS
>> b/board/phytec/pcl063/MAINTAINERS
>> index 70e03cfe71..7d9978c339 100644
>> --- a/board/phytec/pcl063/MAINTAINERS
>> +++ b/board/phytec/pcl063/MAINTAINERS
>> @@ -3,6 +3,7 @@ M: Martyn Welch <martyn.welch@collabora.com>
>> M: Parthiban Nallathambi <parthitce@gmail.com>
>> S: Maintained
>> F: arch/arm/dts/imx6ul-phycore-segin.dts
>> +F: arch/arm/dts/imx6ull-u-boot.dtsi
>> F: arch/arm/dts/imx6ull-phycore-segin.dts
>> F: arch/arm/dts/pcl063-common.dtsi
>> F: board/phytec/pcl063/
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] ARM: dts: i.MX6ULL: U-Boot specific dts for u-boot,
2019-04-07 18:32 [U-Boot] [PATCH] ARM: dts: i.MX6ULL: U-Boot specific dts for u-boot, dm-spl Parthiban Nallathambi
2019-04-08 13:53 ` Marcel Ziswiler
@ 2019-06-10 9:41 ` sbabic at denx.de
1 sibling, 0 replies; 4+ messages in thread
From: sbabic at denx.de @ 2019-06-10 9:41 UTC (permalink / raw)
To: u-boot
> u-boot,dm-spl property is specific to U-Boot, so created one
> for i.MX6ULL platforms.
> Signed-off-by: Parthiban Nallathambi <parthitce@gmail.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-10 9:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-07 18:32 [U-Boot] [PATCH] ARM: dts: i.MX6ULL: U-Boot specific dts for u-boot, dm-spl Parthiban Nallathambi
2019-04-08 13:53 ` Marcel Ziswiler
2019-04-09 16:57 ` Parthiban Nallathambi
2019-06-10 9:41 ` [U-Boot] [PATCH] ARM: dts: i.MX6ULL: U-Boot specific dts for u-boot, sbabic at denx.de
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox