From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eugeniu Rosca <roscaeugeniu@gmail.com>
Date: Mon, 8 Apr 2019 00:43:39 +0200
Subject: [U-Boot] [PATCH 2/2] cmd: Add 'bcb' command to
 read/modify/write BCB fields
In-Reply-To: <19665b50-6d52-fc96-0612-f1f390ecd88f@gmx.de>
References: <20190407220206.7655-1-erosca@de.adit-jv.com>
 <20190407220206.7655-3-erosca@de.adit-jv.com>
 <19665b50-6d52-fc96-0612-f1f390ecd88f@gmx.de>
Message-ID: <20190407224339.GA9481@x230>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Heinrich,

On Mon, Apr 08, 2019 at 12:11:59AM +0200, Heinrich Schuchardt wrote:
[..]
> > +	switch (bcb_cmd_get(argv[0])) {
> > +	case BCB_CMD_LOAD:
> > +		return bcb_load(argc, argv, &bcb, &bcb_dev, &bcb_part);
> > +	case BCB_CMD_FIELD_SET:
> > +		return bcb_field_set(argc, argv, &bcb, bcb_dev, bcb_part);
> > +	case BCB_CMD_FIELD_CLEAR:
> > +		return bcb_field_clear(argc, argv, &bcb, bcb_dev, bcb_part);
> > +	case BCB_CMD_FIELD_TEST:
> > +		return bcb_field_test(argc, argv, &bcb, bcb_dev, bcb_part);
> > +	case BCB_CMD_FIELD_DUMP:
> > +		return bcb_field_dump(argc, argv, &bcb, bcb_dev, bcb_part);
> > +	case BCB_CMD_STORE:
> > +		return bcb_store(argc, argv, &bcb, bcb_dev, bcb_part);
> > +	default:
> > +		return CMD_RET_USAGE;
> > +	}
> 
> Please, implement the sub-commands as described in doc/README.commands
> using the U_BOOT_CMD_MKENT macro.

Thanks for the lightning-fast reply. Will fix in v2, once hopefully
more review comments are collected.

> Best regards
> 
> Heinrich

Best regards,
Eugeniu.