[U-Boot] [PATCH] mtd: nand: let the raw NAND devices be compiled upon selection

Tom Rini
2019-04-08T11:54:47Z

On Mon, Apr 08, 2019 at 11:52:31AM +0200, Miquel Raynal wrote:
> Hi Jagan,
>
> Miquel Raynal <miquel.raynal@bootlin.com> wrote on Mon, 29 Oct 2018
> 10:07:28 +0100:
>
> > Hi Jagan,
> >
> > Jagan Teki <jagan@amarulasolutions.com> wrote on Tue, 23 Oct 2018
> > 16:40:05 +0530:
> >
> > > On Thu, Oct 11, 2018 at 3:05 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> > > >
> > > > Today way is to rely on CMD_NAND to be selected and from the root
> > > > Makefile compile what is in drivers/mtd/nand/raw.
> > > >
> > > > While this will work most of the time with decent configurations, it
> > > > is better to also compile this subsystem upon simple request in the
> > > > configuration. Otherwise, a user not selecting CMD_NAND but selecting
> > > > NAND and any of the controller drivers will not see their build. Fix
> > > > this weird situation by adding a single line in the nand/ directory
> > > > Kconfig file.
> > > >
> > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > > > ---
> > > > drivers/mtd/nand/Makefile | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile
> > > > index a358bc680e..2c33447995 100644
> > > > --- a/drivers/mtd/nand/Makefile
> > > > +++ b/drivers/mtd/nand/Makefile
> > > > @@ -2,4 +2,5 @@
> > > >
> > > > nandcore-objs := core.o bbt.o
> > > > obj-$(CONFIG_MTD_NAND_CORE) += nandcore.o
> > > > +obj-$(CONFIG_NAND) += raw/
> > >
> > > But we even source raw Kconfig path, isn't it? and also how about
> > > remove this from root Makefile?
> >
> > What do you mean by "we even source raw Kconfig path"? It was not
> > sourced before this modification unless CMD_NAND was selected.
> >
> > I agree we should also remove this link between a path being
> > compiled and a CMD_* symbol in the root Makefile. It will probably
> > produce a lot of errors though. I'll try when I'll have some time.
>
> Yet another patch you ignored. All these are real fixes, not just some
> kind of sandbox leisure, please consider this change.

Yes, what's going on here? Thanks!

--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190408/87dc41d7/attachment.sig>