public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] efi_loader: debug output file handle in efi_file_open()
Date: Tue, 9 Apr 2019 11:37:28 +0900	[thread overview]
Message-ID: <20190409023727.GE21650@linaro.org> (raw)
In-Reply-To: <20190406144256.31117-1-xypron.glpk@gmx.de>

On Sat, Apr 06, 2019 at 04:42:56PM +0200, Heinrich Schuchardt wrote:
> For debugging it is helpful to know the address of the file handle created
> by the Open() method of the EFI file protocol. So let's write it with
> EFI_PRINT().

Just a question.
How will you use the address for debugging?

-Takahiro Akashi

> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  lib/efi_loader/efi_file.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/efi_loader/efi_file.c b/lib/efi_loader/efi_file.c
> index 0483403be0d..39e37749fe2 100644
> --- a/lib/efi_loader/efi_file.c
> +++ b/lib/efi_loader/efi_file.c
> @@ -257,10 +257,12 @@ static efi_status_t EFIAPI efi_file_open(struct efi_file_handle *file,
> 
>  	/* Open file */
>  	*new_handle = file_open(fh->fs, fh, file_name, open_mode, attributes);
> -	if (*new_handle)
> +	if (*new_handle) {
> +		EFI_PRINT("file handle %p\n", *new_handle);
>  		ret = EFI_SUCCESS;
> -	else
> +	} else {
>  		ret = EFI_NOT_FOUND;
> +	}
>  out:
>  	return EFI_EXIT(ret);
>  }
> --
> 2.20.1
> 

  reply	other threads:[~2019-04-09  2:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-06 14:42 [U-Boot] [PATCH 1/1] efi_loader: debug output file handle in efi_file_open() Heinrich Schuchardt
2019-04-09  2:37 ` AKASHI Takahiro [this message]
2019-04-09  3:43   ` Heinrich Schuchardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190409023727.GE21650@linaro.org \
    --to=takahiro.akashi@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox