From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, RESEND, v5, 3/7] test: fs: Add filesystem integrity checks
Date: Tue, 9 Apr 2019 16:03:29 -0400 [thread overview]
Message-ID: <20190409200329.GV4664@bill-the-cat> (raw)
In-Reply-To: <20190213111527.1525-4-jjhiblot@ti.com>
On Wed, Feb 13, 2019 at 12:15:23PM +0100, Jean-Jacques Hiblot wrote:
> We need to make sure that file writes,file creation, etc. are properly
> performed and do not corrupt the filesystem.
> To help with this, introduce the assert_fs_integrity() function that
> executes the appropriate fsck tool. It should be called at the end of any
> test that modify the content/organization of the filesystem.
> Currently only supports FATs and EXT4.
>
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
OK, I'm adding in a bunch of people to CC here. The issue with this
patch is that by adding fsck to our tests we see 34 FAT16/FAT32
failures:
TestFsBasic.test_fs13[fat16]
TestFsBasic.test_fs11[fat32]
TestFsBasic.test_fs12[fat32]
TestFsBasic.test_fs13[fat32]
TestFsExt.test_fs_ext1[fat32]
TestFsExt.test_fs_ext2[fat32]
TestFsExt.test_fs_ext3[fat32]
TestFsExt.test_fs_ext4[fat32]
TestFsExt.test_fs_ext5[fat32]
TestFsExt.test_fs_ext6[fat32]
TestFsExt.test_fs_ext7[fat32]
TestFsExt.test_fs_ext8[fat32]
TestFsExt.test_fs_ext9[fat32]
TestMkdir.test_mkdir6[fat16]
TestMkdir.test_mkdir1[fat32]
TestMkdir.test_mkdir2[fat32]
TestMkdir.test_mkdir3[fat32]
TestMkdir.test_mkdir4[fat32]
TestMkdir.test_mkdir5[fat32]
TestMkdir.test_mkdir6[fat32]
TestUnlink.test_unlink1[fat16]
TestUnlink.test_unlink2[fat16]
TestUnlink.test_unlink3[fat16]
TestUnlink.test_unlink4[fat16]
TestUnlink.test_unlink5[fat16]
TestUnlink.test_unlink6[fat16]
TestUnlink.test_unlink7[fat16]
TestUnlink.test_unlink1[fat32]
TestUnlink.test_unlink2[fat32]
TestUnlink.test_unlink3[fat32]
TestUnlink.test_unlink4[fat32]
TestUnlink.test_unlink5[fat32]
TestUnlink.test_unlink6[fat32]
TestUnlink.test_unlink7[fat32]
So... I'm inclined to say that to start with, I bring this patch in and
then disable FAT fsck (as I cannot see how to mark these as xfail with
a comment that we need to fix them, only for FAT). But we should get
these FAT problems fixed.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190409/23986eae/attachment.sig>
next prev parent reply other threads:[~2019-04-09 20:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 11:15 [U-Boot] [RESEND PATCH v5 0/7] Add support for symlink creation in EXT4 Jean-Jacques Hiblot
2019-02-13 11:15 ` [U-Boot] [RESEND PATCH v5 1/7] fs: ext4: do not allow writes if metadata checksum is active Jean-Jacques Hiblot
2019-04-09 19:34 ` [U-Boot] [U-Boot, RESEND, v5, " Tom Rini
2019-04-10 8:10 ` Jean-Jacques Hiblot
2019-02-13 11:15 ` [U-Boot] [RESEND PATCH v5 2/7] test: fs: disable the metadata checksums on ext4 filesystems Jean-Jacques Hiblot
2019-04-10 12:19 ` [U-Boot] [U-Boot, RESEND, v5, " Tom Rini
2019-02-13 11:15 ` [U-Boot] [RESEND PATCH v5 3/7] test: fs: Add filesystem integrity checks Jean-Jacques Hiblot
2019-02-13 18:58 ` Tom Rini
2019-04-09 20:03 ` Tom Rini [this message]
2019-04-10 0:10 ` [U-Boot] [U-Boot, RESEND, v5, " Heinrich Schuchardt
2019-04-10 0:19 ` Tom Rini
2019-04-10 1:37 ` Takahiro Akashi
2019-04-10 2:25 ` Tom Rini
2019-04-10 2:51 ` Takahiro Akashi
2019-04-10 4:30 ` Takahiro Akashi
2019-04-09 20:10 ` [U-Boot] [PATCH] test.py: Disable fsck for FAT tests for now Tom Rini
2019-04-10 12:19 ` [U-Boot] [U-Boot, RESEND, v5, 3/7] test: fs: Add filesystem integrity checks Tom Rini
2019-02-13 11:15 ` [U-Boot] [RESEND PATCH v5 4/7] fs: ext4: constify the buffer passed to write functions Jean-Jacques Hiblot
2019-04-10 12:19 ` [U-Boot] [U-Boot, RESEND, v5, " Tom Rini
2019-02-13 11:15 ` [U-Boot] [RESEND PATCH v5 5/7] fs: ext4: Add support for the creation of symbolic links Jean-Jacques Hiblot
2019-04-10 12:19 ` [U-Boot] [U-Boot, RESEND, v5, " Tom Rini
2019-02-13 11:15 ` [U-Boot] [RESEND PATCH v5 6/7] fs: Add a new command to create " Jean-Jacques Hiblot
2019-04-10 12:19 ` [U-Boot] [U-Boot, RESEND, v5, " Tom Rini
2019-02-13 11:15 ` [U-Boot] [RESEND PATCH v5 7/7] test: fs: Added tests for symlinks Jean-Jacques Hiblot
2019-04-10 12:20 ` [U-Boot] [U-Boot, RESEND, v5, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409200329.GV4664@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox