From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/8] video/console: Fix DM_VIDEO font glyph array indexing
Date: Tue, 9 Apr 2019 23:03:43 +0200 [thread overview]
Message-ID: <20190409230343.7639ccb2@crub> (raw)
In-Reply-To: <20190323013002.27117-2-andre.przywara@arm.com>
On Sat, 23 Mar 2019 01:29:55 +0000
Andre Przywara andre.przywara at arm.com wrote:
> When the character to be printed on a DM_VIDEO console is from the
> "extended ASCII" range (0x80 - 0xff), it will be treated as a negative
> number, as it's declared as a signed char. This leads to negative array
> indicies into the glyph bitmap array, and random garbled characters.
>
> Cast the character to an unsigned type to make the index always positive
> and avoid an out-of-bounds access.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
> drivers/video/console_normal.c | 3 ++-
> drivers/video/console_rotate.c | 7 ++++---
> 2 files changed, 6 insertions(+), 4 deletions(-)
Applied (with s/uint8_t/u8/) to u-boot-video/master, thanks!
--
Anatolij
next prev parent reply other threads:[~2019-04-09 21:03 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-23 1:29 [U-Boot] [PATCH 0/8] video/console: Fix various DM_VIDEO console issues Andre Przywara
2019-03-23 1:29 ` [U-Boot] [PATCH 1/8] video/console: Fix DM_VIDEO font glyph array indexing Andre Przywara
2019-03-30 21:18 ` Simon Glass
2019-04-09 21:03 ` Anatolij Gustschin [this message]
2019-03-23 1:29 ` [U-Boot] [PATCH 2/8] video/console: Implement reverse video ANSI sequence for DM_VIDEO Andre Przywara
2019-03-30 21:18 ` Simon Glass
2019-04-09 21:04 ` Anatolij Gustschin
2019-04-14 13:05 ` [U-Boot] [PATCH v2 " Anatolij Gustschin
2019-04-17 13:36 ` Anatolij Gustschin
2019-03-23 1:29 ` [U-Boot] [PATCH 3/8] video/console: Implement relative cursor movement ANSI handling Andre Przywara
2019-03-30 21:18 ` Simon Glass
2019-04-09 21:05 ` Anatolij Gustschin
2019-04-11 12:09 ` Anatolij Gustschin
2019-04-13 21:40 ` André Przywara
2019-04-14 12:54 ` Anatolij Gustschin
2019-04-14 21:49 ` André Przywara
2019-03-23 1:29 ` [U-Boot] [PATCH 4/8] video/console: Implement ANSI clear line command Andre Przywara
2019-03-30 21:18 ` Simon Glass
2019-04-09 21:05 ` Anatolij Gustschin
2019-03-23 1:29 ` [U-Boot] [PATCH 5/8] video/console: Factor out actual character output Andre Przywara
2019-03-30 21:18 ` Simon Glass
2019-04-09 21:06 ` Anatolij Gustschin
2019-03-23 1:30 ` [U-Boot] [PATCH 6/8] video/console: Convert UTF-8 codes to CP437 code points Andre Przywara
2019-03-30 21:18 ` Simon Glass
2019-03-31 18:28 ` Alexander Graf
2019-03-31 23:54 ` André Przywara
2019-03-23 1:30 ` [U-Boot] [PATCH 7/8] usb: kbd: Properly translate up/down arrow keys Andre Przywara
2019-03-30 21:18 ` Simon Glass
2019-04-01 0:04 ` André Przywara
2019-04-01 1:58 ` Simon Glass
2019-04-09 21:06 ` Anatolij Gustschin
2019-03-23 1:30 ` [U-Boot] [PATCH 8/8] sunxi: allow boards to de-select SYS_WHITE_ON_BLACK font scheme Andre Przywara
2019-03-30 21:18 ` Simon Glass
2019-04-09 21:07 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409230343.7639ccb2@crub \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox