public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] efi_loader: enable HII protocols by default
Date: Fri, 12 Apr 2019 11:29:00 +0900	[thread overview]
Message-ID: <20190412022859.GF7158@linaro.org> (raw)
In-Reply-To: <20190407220301.8645-1-xypron.glpk@gmx.de>

On Mon, Apr 08, 2019 at 12:03:01AM +0200, Heinrich Schuchardt wrote:
> As the UEFI shell requires the HII protocols let's enable them by default.

Is there still any reason that we have this config option at all?

> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  lib/efi_loader/Kconfig | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
> index 23487b8130..a6489ca534 100644
> --- a/lib/efi_loader/Kconfig
> +++ b/lib/efi_loader/Kconfig
> @@ -38,14 +38,11 @@ config EFI_LOADER_BOUNCE_BUFFER
>  config EFI_LOADER_HII
>  	bool "Expose HII protocols to EFI applications"
>  	depends on EFI_LOADER
> -	default n
> +	default y
>  	help
>  	  The Human Interface Infrastructure is a complicated framework that
>  	  allows UEFI applications to draw fancy menus and hook strings using
>  	  a translation framework.
> 
>  	  U-Boot implements enough of its features to be able to run the UEFI
> -	  Shell, but not more than that. The code is experimental still, so
> -	  beware that your system might break with HII enabled.

I don't think it's experimental, but just not fully implemented
in terms of UEFI specification. This is also true for other UEFI features
on U-Boot.
Since a some kind of bug regarding HII was reported, I haven't seen
any bug fix relating to that. (I doubt it was a bug.)

-Takahiro Akashi

> -	  If unsure, say n.
> +	  Shell, but not more than that.
> --
> 2.20.1
> 

  reply	other threads:[~2019-04-12  2:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-07 22:03 [U-Boot] [PATCH 1/1] efi_loader: enable HII protocols by default Heinrich Schuchardt
2019-04-12  2:29 ` AKASHI Takahiro [this message]
2019-04-12  4:25   ` Heinrich Schuchardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190412022859.GF7158@linaro.org \
    --to=takahiro.akashi@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox