public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] efi_selftest: expect boot services data for fdt
Date: Fri, 12 Apr 2019 23:17:59 +0300	[thread overview]
Message-ID: <20190412201759.GA17390@Iliass-MBP.lan> (raw)
In-Reply-To: <20190412201406.10020-1-xypron.glpk@gmx.de>

Hi Heinrich,
> In a previous patch the memory type used for the FDT has been changed to
> boot services data. We have to adjust the test.
> 
> Correct an incorrect comment. The tested services are boot services.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  lib/efi_selftest/efi_selftest_memory.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/efi_selftest/efi_selftest_memory.c b/lib/efi_selftest/efi_selftest_memory.c
> index d41227b605..5eeb42a9be 100644
> --- a/lib/efi_selftest/efi_selftest_memory.c
> +++ b/lib/efi_selftest/efi_selftest_memory.c
> @@ -4,7 +4,7 @@
>   *
>   * Copyright (c) 2018 Heinrich Schuchardt <xypron.glpk@gmx.de>
>   *
> - * This unit test checks the following runtime services:
> + * This unit test checks the following boottime services:
>   * AllocatePages, FreePages, GetMemoryMap
>   *
>   * The memory type used for the device tree is checked.
> @@ -176,9 +176,9 @@ static int execute(void)
>  	/* Check memory reservation for the device tree */
>  	if (fdt_addr &&
>  	    find_in_memory_map(map_size, memory_map, desc_size, fdt_addr,
> -			       EFI_RUNTIME_SERVICES_DATA) != EFI_ST_SUCCESS) {
> +			       EFI_BOOT_SERVICES_DATA) != EFI_ST_SUCCESS) {
>  		efi_st_error
> -			("Device tree not marked as runtime services data\n");
> +			("Device tree not marked as boot services data\n");
>  		return EFI_ST_FAILURE;
>  	}
>  	return EFI_ST_SUCCESS;
> --
> 2.20.1
> 
I probably should have updated that myself. Thanks for catching this

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>

      reply	other threads:[~2019-04-12 20:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-12 20:14 [U-Boot] [PATCH 1/1] efi_selftest: expect boot services data for fdt Heinrich Schuchardt
2019-04-12 20:17 ` Ilias Apalodimas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190412201759.GA17390@Iliass-MBP.lan \
    --to=ilias.apalodimas@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox