From: Chris Packham <judge.packham@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/4] Remove select CRC32 and CONFIG_CRC32
Date: Sat, 13 Apr 2019 21:13:55 +1200 [thread overview]
Message-ID: <20190413091359.29612-1-judge.packham@gmail.com> (raw)
Robert points out that we have code selecting CRC32 but nothing that
actually defines this config option. Similarly image.h #defines
CONFIG_CRC32 but nothing tests for it.
lib/Makefile has had obj-y += crc32.o for some time. I can't find any
evidence that u-boot ever had CONFIG_CRC32.
I suspect some of this may have come in when code has been imported from
Linux (particularly the UBI/UBIFS code).
Chris Packham (4):
cmd: ubifs: Remove select for non-existent option
mtd: ubi: Remove select for non existent option
Remove #define CONFIG_CRC32
Remove whitelist entry for CONFIG_CRC32
cmd/Kconfig | 2 --
drivers/mtd/ubi/Kconfig | 1 -
include/image.h | 1 -
scripts/config_whitelist.txt | 1 -
4 files changed, 5 deletions(-)
--
2.21.0
next reply other threads:[~2019-04-13 9:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-13 9:13 Chris Packham [this message]
2019-04-13 9:13 ` [U-Boot] [PATCH 1/4] cmd: ubifs: Remove select for non-existent option Chris Packham
2019-04-15 4:03 ` Heiko Schocher
2019-05-10 15:10 ` Tom Rini
2019-04-13 9:13 ` [U-Boot] [PATCH 2/4] mtd: ubi: Remove select for non existent option Chris Packham
2019-04-15 4:03 ` Heiko Schocher
2019-05-10 15:11 ` Tom Rini
2019-04-13 9:13 ` [U-Boot] [PATCH 3/4] Remove #define CONFIG_CRC32 Chris Packham
2019-04-14 16:20 ` stefano babic
2019-04-15 4:04 ` Heiko Schocher
2019-05-10 15:11 ` Tom Rini
2019-04-13 9:13 ` [U-Boot] [PATCH 4/4] Remove whitelist entry for CONFIG_CRC32 Chris Packham
2019-04-15 4:05 ` Heiko Schocher
2019-05-10 15:11 ` Tom Rini
2019-04-13 10:44 ` [U-Boot] [PATCH 0/4] Remove select CRC32 and CONFIG_CRC32 Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190413091359.29612-1-judge.packham@gmail.com \
--to=judge.packham@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox