From: Markus Klotzbuecher <mk@mkio.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/6] ubi: fix UBI_SILENCE_MSG
Date: Mon, 15 Apr 2019 17:32:03 +0200 [thread overview]
Message-ID: <20190415153206.3472-4-mk@mkio.de> (raw)
In-Reply-To: <20190415153206.3472-1-mk@mkio.de>
From: Markus Klotzbuecher <markus.klotzbuecher@kistler.com>
- drop CONFIG_ prefix from kconfig entry
- fix small compilation issue with CONFIG_UBI_SILENCE_MSG
Signed-off-by: Markus Klotzbuecher <markus.klotzbuecher@kistler.com>
Cc: Heiko Schocher <hs@denx.de>
Cc: Kyungmin Park <kmpark@infradead.org>
---
drivers/mtd/ubi/Kconfig | 2 +-
drivers/mtd/ubi/io.c | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/ubi/Kconfig b/drivers/mtd/ubi/Kconfig
index cf84783356..e22dda8564 100644
--- a/drivers/mtd/ubi/Kconfig
+++ b/drivers/mtd/ubi/Kconfig
@@ -1,6 +1,6 @@
menu "UBI support"
-config CONFIG_UBI_SILENCE_MSG
+config UBI_SILENCE_MSG
bool "UBI silence verbose messages"
default ENV_IS_IN_UBI
help
diff --git a/drivers/mtd/ubi/io.c b/drivers/mtd/ubi/io.c
index 8ef7823b37..688fb509d2 100644
--- a/drivers/mtd/ubi/io.c
+++ b/drivers/mtd/ubi/io.c
@@ -1351,6 +1351,7 @@ static int self_check_write(struct ubi_device *ubi, const void *buf, int pnum,
ubi_err(ubi, "self-check failed for PEB %d:%d, len %d",
pnum, offset, len);
+#if !defined(CONFIG_UBI_SILENCE_MSG)
ubi_msg(ubi, "data differ at position %d", i);
ubi_msg(ubi, "hex dump of the original buffer from %d to %d",
i, i + dump_len);
@@ -1360,6 +1361,7 @@ static int self_check_write(struct ubi_device *ubi, const void *buf, int pnum,
i, i + dump_len);
print_hex_dump("", DUMP_PREFIX_OFFSET, 32, 1,
buf1 + i, dump_len, 1);
+#endif
dump_stack();
err = -EINVAL;
goto out_free;
--
2.20.1
next prev parent reply other threads:[~2019-04-15 15:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 15:32 [U-Boot] [PATCH 0/6] miscellaneous ubispl and ubi improvements Markus Klotzbuecher
2019-04-15 15:32 ` [U-Boot] [PATCH 1/6] env: ubi: KConfig: add CONFIG_ENV_UBI_VOLUME_REDUND Markus Klotzbuecher
2019-04-30 4:54 ` Heiko Schocher
2019-05-02 7:15 ` Markus Klotzbuecher
2019-05-09 8:59 ` Markus Klotzbuecher
2019-05-09 11:17 ` Heiko Schocher
2019-05-09 15:49 ` Markus Klotzbuecher
2019-05-09 18:42 ` mk at mkio.de
2019-04-15 15:32 ` [U-Boot] [PATCH 2/6] env: ubi: support configurable VID offset Markus Klotzbuecher
2019-04-30 4:57 ` Heiko Schocher
2019-04-15 15:32 ` Markus Klotzbuecher [this message]
2019-04-30 4:59 ` [U-Boot] [PATCH 3/6] ubi: fix UBI_SILENCE_MSG Heiko Schocher
2019-04-15 15:32 ` [U-Boot] [PATCH 4/6] ubispl: migrate configuration to Kconfig Markus Klotzbuecher
2019-04-30 4:59 ` Heiko Schocher
2019-04-15 15:32 ` [U-Boot] [PATCH 5/6] ubispl: add support for loading volumes by name Markus Klotzbuecher
2019-04-30 5:15 ` Heiko Schocher
2019-04-15 15:32 ` [U-Boot] [PATCH 6/6] ubispl: introduce separate CONFIG_UBI_SPL_SILENCE_MSG Markus Klotzbuecher
2019-04-30 5:16 ` Heiko Schocher
2019-04-16 3:52 ` [U-Boot] [PATCH 0/6] miscellaneous ubispl and ubi improvements Heiko Schocher
2019-04-16 4:03 ` Heiko Schocher
2019-04-16 5:14 ` Markus Klotzbuecher
2019-04-17 6:34 ` Markus Klotzbuecher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415153206.3472-4-mk@mkio.de \
--to=mk@mkio.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox