From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Support boot Android image without address on bootm command
Date: Wed, 24 Apr 2019 09:22:23 -0400 [thread overview]
Message-ID: <20190424132223.GS31207@bill-the-cat> (raw)
In-Reply-To: <20190222082806.4169-1-shawn.guo@linaro.org>
On Fri, Feb 22, 2019 at 04:28:06PM +0800, Shawn Guo wrote:
> It works perfectly fine to boot an Android boot.img with bootm command
> followed by an explicit address argument that holds the image. But if
> we have boot.img downloaded into default 'loadaddr', and then boot it
> using bootm command without the address argument, we will run into
> problem, because U-Boot fails to find ramdisk and fdt (second area) in
> boot.img.
>
> The current Android image support assumes there is always an address
> argument on bootm command. However just like booting any other images,
> 'loadaddr' should be used when address argument is missing from bootm
> command. It patches boot_get_ramdisk() and boot_get_fdt() a bit to
> support this quite common usage of bootm command for Android image.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> Reviewed-by: Tom Rini <trini@konsulko.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190424/706e9a8a/attachment.sig>
prev parent reply other threads:[~2019-04-24 13:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 8:28 [U-Boot] [PATCH] Support boot Android image without address on bootm command Shawn Guo
2019-02-22 13:56 ` Tom Rini
2019-04-24 13:22 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424132223.GS31207@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox