From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 02/11] lib: charset: add u16_strncmp()
Date: Thu, 25 Apr 2019 09:16:17 +0900 [thread overview]
Message-ID: <20190425001615.GC7158@linaro.org> (raw)
In-Reply-To: <fbb83387-7be8-6b4d-a3ae-6b83623bf8ed@gmx.de>
On Wed, Apr 24, 2019 at 08:36:09PM +0200, Heinrich Schuchardt wrote:
> On 4/24/19 8:30 AM, AKASHI Takahiro wrote:
> >u16_strncmp() works like u16_strcmp() but only at most n characters
> >(in u16) are compared.
> >This function will be used in a later patch.
> >
> >Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
>
> The only usage of u16_strncmp() is in patch 3.
> u16_strcmp() is not used at all.
The fact is that u16_strcmp() is already used in my 'secure boot' patch
and then I moved on to non-volatile patch.
> In patch 3 'memcmp(var_name16, L"BOOT", 8)' will do the job.
>
> I am not sure if in other cases we wouldn't prefer to compare Unicode
> codepoints instead of u16.
That is my concern, too :)
> So I suggest to skip patches 1 and 2 and use memcmp() in patch 3.
Okay, patch#1 will be planned to be included in 'secure boot' patch.
-Takahiro Akashi
> Best regards
>
> Heinrich
next prev parent reply other threads:[~2019-04-25 0:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 6:30 [U-Boot] [PATCH v2 00/11] efi_loader: non-volatile variables support AKASHI Takahiro
2019-04-24 6:30 ` [U-Boot] [PATCH v2 01/11] lib: charset: add u16_strcmp() AKASHI Takahiro
2019-04-24 16:24 ` Heinrich Schuchardt
2019-04-25 0:38 ` AKASHI Takahiro
2019-04-24 6:30 ` [U-Boot] [PATCH v2 02/11] lib: charset: add u16_strncmp() AKASHI Takahiro
2019-04-24 17:40 ` Heinrich Schuchardt
2019-04-24 18:36 ` Heinrich Schuchardt
2019-04-25 0:16 ` AKASHI Takahiro [this message]
2019-04-24 6:30 ` [U-Boot] [PATCH v2 03/11] cmd: efidebug: rework "boot dump" sub-command using GetNextVariableName() AKASHI Takahiro
2019-04-24 20:13 ` Heinrich Schuchardt
2019-04-25 0:30 ` AKASHI Takahiro
2019-04-24 6:30 ` [U-Boot] [PATCH v2 04/11] efi_loader: set OsIndicationsSupported at init AKASHI Takahiro
2019-04-24 6:30 ` [U-Boot] [PATCH v2 05/11] env: save UEFI non-volatile variables in dedicated storage AKASHI Takahiro
2019-04-25 18:44 ` Heinrich Schuchardt
2019-04-24 6:30 ` [U-Boot] [PATCH v2 06/11] efi_loader: variable: support non-volatile attribute AKASHI Takahiro
2019-04-24 6:30 ` [U-Boot] [PATCH v2 07/11] efi_loader: variable: split UEFI variables from U-Boot environment AKASHI Takahiro
2019-04-24 6:30 ` [U-Boot] [PATCH v2 08/11] efi_loader: load saved non-volatile variables at init AKASHI Takahiro
2019-04-24 6:30 ` [U-Boot] [PATCH v2 09/11] efi_loader: bootmgr: handle BootNext as non-volatile AKASHI Takahiro
2019-04-24 6:30 ` [U-Boot] [PATCH v2 10/11] cmd: env: add -nv option for UEFI non-volatile variable AKASHI Takahiro
2019-04-24 6:30 ` [U-Boot] [PATCH v2 11/11] cmd: efidebug: make some boot variables non-volatile AKASHI Takahiro
2019-04-24 22:12 ` [U-Boot] [PATCH v2 00/11] efi_loader: non-volatile variables support Heinrich Schuchardt
2019-04-25 1:12 ` AKASHI Takahiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425001615.GC7158@linaro.org \
--to=takahiro.akashi@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox