From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v2, 2/2] dtb_platdata.py: prevent define generation of alias
Date: Sat, 27 Apr 2019 10:46:43 -0400 [thread overview]
Message-ID: <20190427144643.GP31207@bill-the-cat> (raw)
In-Reply-To: <20190416113158.289833-3-hs@denx.de>
On Tue, Apr 16, 2019 at 01:31:58PM +0200, Heiko Schocher wrote:
> generate define for an alias only if the struct is not
> created already.
>
> This prevents compilerwarning:
> PLAT spl/dts/dt-platdata.o
> spl/dts/dt-platdata.c:11:46: error: missing braces around initializer [-Werror=missing-braces]
> static const struct dtd_simple_bus dtv_ahb = {
> ^
> spl/dts/dt-platdata.c:20:46: error: missing braces around initializer [-Werror=missing-braces]
> static const struct dtd_simple_bus dtv_apb = {
> ^
> cc1: all warnings being treated as errors
>
> on the at91 based taurus board. Reason is in at91sam9260.dtsi
> is defined:
>
> ahb {
> compatible = "simple-bus";
> ranges;
>
> and later:
>
> pinctrl: pinctrl at fffff400 {
> compatible = "atmel,at91rm9200-pinctrl", "simple-bus";
> ranges = <0xfffff400 0xfffff400 0x600>;
>
> without this patch dtoc generates:
>
> struct dtd_atmel_at91rm9200_pinctrl {
> fdt32_t atmel_mux_mask[6];
> fdt32_t ranges[3];
> fdt32_t reg[6];
> };
>
> struct dtd_simple_bus {
> bool ranges;
> };
>
> "#define dtd_simple_bus dtd_atmel_at91rm9200_pinctrl"
>
> and the line with "define dtd_simple_bus..." introduces
> the warning. This define is not needed.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190427/f6d7bdde/attachment.sig>
prev parent reply other threads:[~2019-04-27 14:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 11:31 [U-Boot] [PATCH v2 0/2] at91: taurus: Fix the build warnings Heiko Schocher
2019-04-16 11:31 ` [U-Boot] [PATCH v2 1/2] at91: cleanup taurus port Heiko Schocher
2019-04-27 14:48 ` [U-Boot] [U-Boot,v2,1/2] " Tom Rini
2019-04-16 11:31 ` [U-Boot] [PATCH v2 2/2] dtb_platdata.py: prevent define generation of alias Heiko Schocher
2019-04-27 14:46 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190427144643.GP31207@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox