From: Jagan Teki <jagan@amarulasolutions.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/8] Makefile: Trigger a warning for legcay spi drivers
Date: Mon, 29 Apr 2019 02:17:56 +0530 [thread overview]
Message-ID: <20190428204801.9578-4-jagan@amarulasolutions.com> (raw)
In-Reply-To: <20190428204801.9578-1-jagan@amarulasolutions.com>
We have a warning text for non dm converted spi drivers,
but the plan is to mark all these respetive drivers into
CONFIG_BROKEN.
So, trigger a warning saying that these driver configurations
and associated code will remove in v2019.07 (earlier plan is
to remove it from v2019.04)
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Makefile | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/Makefile b/Makefile
index 02c9a73d33..4971f211ff 100644
--- a/Makefile
+++ b/Makefile
@@ -920,6 +920,11 @@ cmd_cfgcheck = $(srctree)/scripts/check-config.sh $2 \
all: $(ALL-y)
ifeq ($(CONFIG_BROKEN),y)
$(warning "You have broken configuration in your .config! Please check your configuration.")
+ifeq ($(CONFIG_SPI),y)
+ifneq ($(CONFIG_DM_SPI)$(CONFIG_OF_CONTROL),yy)
+ $(warning "The relevant config item with associated code will remove in v2019.07 release.")
+endif
+endif
endif # broken
ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y)
@echo >&2 "===================== WARNING ======================"
@@ -997,17 +1002,6 @@ ifeq ($(CONFIG_OF_EMBED),y)
@echo >&2 "See doc/README.fdt-control for more info."
@echo >&2 "===================================================="
endif
-ifeq ($(CONFIG_SPI),y)
-ifneq ($(CONFIG_DM_SPI)$(CONFIG_OF_CONTROL),yy)
- @echo >&2 "===================== WARNING ======================"
- @echo >&2 "This board does not use CONFIG_DM_SPI. Please update"
- @echo >&2 "the board before v2019.04 for no dm conversion"
- @echo >&2 "and v2019.07 for partially dm converted drivers."
- @echo >&2 "Failure to update can lead to driver/board removal"
- @echo >&2 "See doc/driver-model/MIGRATION.txt for more info."
- @echo >&2 "===================================================="
-endif
-endif
ifeq ($(CONFIG_SPI_FLASH),y)
ifneq ($(CONFIG_DM_SPI_FLASH)$(CONFIG_OF_CONTROL),yy)
@echo >&2 "===================== WARNING ======================"
--
2.18.0.321.gffc6fa0e3
next prev parent reply other threads:[~2019-04-28 20:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-28 20:47 [U-Boot] [PATCH 0/8] spi: Mark non-dm spi drivers as BROKEN Jagan Teki
2019-04-28 20:47 ` [U-Boot] [PATCH 1/8] Kconfig: Update CONFIG_BROKEN help text Jagan Teki
2019-04-29 5:56 ` Heinrich Schuchardt
2019-04-28 20:47 ` [U-Boot] [PATCH 2/8] Makefile: Trigger a Warning if BROKEN defined Jagan Teki
2019-04-29 6:00 ` Heinrich Schuchardt
2019-04-28 20:47 ` Jagan Teki [this message]
2019-04-28 20:47 ` [U-Boot] [PATCH 4/8] spi: Kconfig: Mark MXS_SPI has BROKEN Jagan Teki
2019-04-29 7:58 ` Marek Vasut
2019-04-29 10:40 ` Jagan Teki
2019-04-29 10:58 ` Marek Vasut
2019-04-29 11:02 ` Jagan Teki
2019-04-29 11:06 ` Marek Vasut
2019-04-29 11:24 ` Tom Rini
2019-04-29 11:27 ` Marek Vasut
2019-04-29 12:34 ` Michael Nazzareno Trimarchi
2019-04-29 12:47 ` Tom Rini
2019-04-29 12:53 ` Marek Vasut
2019-04-29 14:02 ` Jagan Teki
2019-05-14 14:16 ` Jagan Teki
2019-05-14 14:45 ` Tom Rini
2019-05-14 17:33 ` Marek Vasut
2019-05-14 17:37 ` Tom Rini
2019-05-14 17:41 ` Marek Vasut
2019-05-14 18:00 ` Tom Rini
2019-04-28 20:47 ` [U-Boot] [PATCH 5/8] spi: Kconfig: Mark SH_SPI " Jagan Teki
2019-04-28 20:47 ` [U-Boot] [PATCH 6/8] spi: Kconfig: Mark SOFT_SPI " Jagan Teki
2019-04-28 20:48 ` [U-Boot] [PATCH 7/8] spi: Kconfig: Mark FSL_ESPI " Jagan Teki
2019-04-28 20:48 ` [U-Boot] [PATCH 8/8] spi: Kconfig: Mark LPC32XX_SSP " Jagan Teki
2019-04-30 20:48 ` Vladimir Zapolskiy
2019-05-09 14:11 ` Sylvain Lemieux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190428204801.9578-4-jagan@amarulasolutions.com \
--to=jagan@amarulasolutions.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox