* [U-Boot] [PATCH] ARM: dts: logicpd-som-lv: Fix MMC1 card detect
@ 2019-04-30 12:53 Adam Ford
2019-05-03 18:21 ` Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Adam Ford @ 2019-04-30 12:53 UTC (permalink / raw)
To: u-boot
The card detect pin was incorrectly using IRQ_TYPE_LEVEL_LOW
instead of GPIO_ACTIVE_LOW when reading the state of the CD pin.
Without this patch, MMC1 won't be detected.
This is the same patch submitted to linux-omap, but I was hoping
to get it applied to U-Boot without having to wait for the
linux adoption and then backporting.
Fixes: 5448ff33f281 ("ARM: DTS: Resync Logic PD SOM-LV 37xx
devkit with Linux 4.18-RC4")
Signed-off-by: Adam Ford <aford173@gmail.com>
diff --git a/arch/arm/dts/logicpd-som-lv-baseboard.dtsi b/arch/arm/dts/logicpd-som-lv-baseboard.dtsi
index 4990ed90dc..3524766515 100644
--- a/arch/arm/dts/logicpd-som-lv-baseboard.dtsi
+++ b/arch/arm/dts/logicpd-som-lv-baseboard.dtsi
@@ -152,8 +152,8 @@
interrupts-extended = <&intc 83 &omap3_pmx_core 0x11a>;
pinctrl-names = "default";
pinctrl-0 = <&mmc1_pins>;
- wp-gpios = <&gpio4 30 GPIO_ACTIVE_HIGH>; /* gpio_126 */
- cd-gpios = <&gpio4 14 IRQ_TYPE_LEVEL_LOW>; /* gpio_110 */
+ wp-gpios = <&gpio4 30 GPIO_ACTIVE_HIGH>; /* gpio_126 */
+ cd-gpios = <&gpio4 14 GPIO_ACTIVE_LOW>; /* gpio_110 */
vmmc-supply = <&vmmc1>;
bus-width = <4>;
cap-power-off-card;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] ARM: dts: logicpd-som-lv: Fix MMC1 card detect
2019-04-30 12:53 [U-Boot] [PATCH] ARM: dts: logicpd-som-lv: Fix MMC1 card detect Adam Ford
@ 2019-05-03 18:21 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2019-05-03 18:21 UTC (permalink / raw)
To: u-boot
On Tue, Apr 30, 2019 at 07:53:16AM -0500, Adam Ford wrote:
> The card detect pin was incorrectly using IRQ_TYPE_LEVEL_LOW
> instead of GPIO_ACTIVE_LOW when reading the state of the CD pin.
>
> Without this patch, MMC1 won't be detected.
>
> This is the same patch submitted to linux-omap, but I was hoping
> to get it applied to U-Boot without having to wait for the
> linux adoption and then backporting.
>
> Fixes: 5448ff33f281 ("ARM: DTS: Resync Logic PD SOM-LV 37xx
> devkit with Linux 4.18-RC4")
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> diff --git a/arch/arm/dts/logicpd-som-lv-baseboard.dtsi b/arch/arm/dts/logicpd-som-lv-baseboard.dtsi
> index 4990ed90dc..3524766515 100644
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190503/cd15243c/attachment.sig>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-03 18:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-30 12:53 [U-Boot] [PATCH] ARM: dts: logicpd-som-lv: Fix MMC1 card detect Adam Ford
2019-05-03 18:21 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox