From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 3 May 2019 09:59:09 -0400 Subject: [U-Boot] [PATCH] imx: Use a convenient default value for SYS_MALLOC_F_LEN In-Reply-To: <9cc932cc4ea2c1f31e27209d80b0c019c1e3c6dd.camel@aisec.fraunhofer.de> References: <20190503122503.6283-1-festevam@gmail.com> <9cc932cc4ea2c1f31e27209d80b0c019c1e3c6dd.camel@aisec.fraunhofer.de> Message-ID: <20190503135909.GU31207@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, May 03, 2019 at 12:51:24PM +0000, Auer, Lukas wrote: > On Fri, 2019-05-03 at 09:25 -0300, Fabio Estevam wrote: > > Commit 3a7c45f6a772 ("simple-bus: add DM_FLAG_PRE_RELOC flag to > > simple-bus driver") causes some i.MX boards that were converted > > to DM, such as warp7, to fail to boot. > > > > As explained by Lukas Auer: > > > > "With the patch, U-Boot probes the drivers for devices under simple-bus > > device tree nodes in the pre-relocation device model. The default value > > of CONFIG_SYS_MALLOC_F_LEN (0x400) leaves U-Boot with not enough memory to > > do this, causing it to hang." > > > > Fix this problem by providing a convenient default value for > > CONFIG_SYS_MALLOC_F_LEN. > > > > Reported-by: Pierre-Jean Texier > > Suggested-by: Lukas Auer > > Signed-off-by: Fabio Estevam > > --- > > arch/arm/mach-imx/Kconfig | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig > > index ec09ef240f..a7a7d84b7a 100644 > > --- a/arch/arm/mach-imx/Kconfig > > +++ b/arch/arm/mach-imx/Kconfig > > @@ -90,3 +90,6 @@ config DDRMC_VF610_CALIBRATION > > NXP does NOT recommend to perform this calibration at each boot. One > > shall perform it on a new PCB and then use those values to program > > the ddrmc_cr_setting on relevant board file. > > + > > +config SYS_MALLOC_F_LEN > > + default 0x2000 > > The file arch/arm/mach-imx/Kconfig is unconditionally include, so this > will set SYS_MALLOC_F_LEN for other boards as well. What I have done > locally is to include a depends on with all sub-families with DM > support. If you want you can just use it or I can also submit it as > well. > > config SYS_MALLOC_F_LEN > default 0x2000 > depends on ARCH_IMX8 || ARCH_IMX8M || ARCH_MX7 || ARCH_MX7ULP || \ > ARCH_MX6 || ARCH_MX5 But really we should do that in ./Kconfig with the other places that have a default value for SYS_MALLOC_F_LEN. And then once we've gotten everyone converted we can try and figure out a perhaps cleaner way to handle these kind of "default per SoC" values. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: