From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] env: Exit tools when invalid CRC found
Date: Sun, 5 May 2019 08:50:49 -0400 [thread overview]
Message-ID: <20190505125049.GJ31207@bill-the-cat> (raw)
In-Reply-To: <7f3c6ea239a26e247c43d1ddf6698f9f43973f76.camel@idexx.com>
On Wed, Apr 03, 2019 at 01:30:47PM +0000, Molloy, Philip wrote:
> fw_setenv and fw_printenv currently print a warning and use a default
> environment compiled into the binary when an invalid CRC is found. This
> modifies the default behavior to print an error and exit. This is
> especially important when calling the tools from a script since the
> script depends on the exit code of the tool to know something went
> wrong.
>
> If the default environment is desired it should be read explicitly by
> the caller. A better model is to store a default environment as a
> separate binary or text file rather than storing it in the executable.
>
> Signed-off-by: Philip Molloy <philip-molloy@idexx.com>
Conceptually, yes, this is correct. However, the behavior in question
has been deployed for so long that I don't feel that we can change it at
this point, so I'm going to NAK this. Sorry.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190505/1dba6435/attachment.sig>
next prev parent reply other threads:[~2019-05-05 12:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 13:30 [U-Boot] [PATCH 1/1] env: Exit tools when invalid CRC found Molloy, Philip
2019-05-05 12:50 ` Tom Rini [this message]
2019-05-07 15:09 ` Molloy, Philip
2019-11-20 0:06 ` Joe Hershberger
2019-11-20 0:45 ` Tom Rini
2019-11-25 9:19 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190505125049.GJ31207@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox