From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 2/2] dlmalloc: fix malloc range at end of ram
Date: Sun, 5 May 2019 14:12:30 -0400 [thread overview]
Message-ID: <20190505181230.GM31207@bill-the-cat> (raw)
In-Reply-To: <7e9e36ca-5b86-df5f-3565-d5fbaeeab2e1@gmail.com>
On Sun, May 05, 2019 at 07:55:10PM +0200, Simon Goldschmidt wrote:
> Am 05.05.2019 um 13:38 schrieb Tom Rini:
> >On Sat, May 04, 2019 at 08:16:38PM +0200, Simon Goldschmidt wrote:
> >>Tom,
> >>
> >>Am 26.04.2019 um 13:00 schrieb Marek Vasut:
> >>>On 4/26/19 12:19 PM, Simon Goldschmidt wrote:
> >>>>On Fri, Apr 26, 2019 at 11:56 AM Marek Vasut <marek.vasut@gmail.com> wrote:
> >>>>>
> >>>>>On 4/26/19 11:36 AM, Simon Goldschmidt wrote:
> >>>>>>On Fri, Apr 26, 2019 at 11:32 AM Marek Vasut <marek.vasut@gmail.com> wrote:
> >>>>>>>
> >>>>>>>On 4/26/19 8:19 AM, Simon Goldschmidt wrote:
> >>>>>>>>Marek Vasut <marek.vasut@gmail.com> schrieb am Fr., 26. Apr. 2019, 00:22:
> >>>>>>>>
> >>>>>>>>>On 4/25/19 9:22 PM, Simon Goldschmidt wrote:
> >>>>>>>>>>If the malloc range passed to mem_malloc_init() is at the end of address
> >>>>>>>>>>range and 'start + size' overflows to 0, following allocations fail as
> >>>>>>>>>>mem_malloc_end is zero (which looks like uninitialized).
> >>>>>>>>>>
> >>>>>>>>>>Fix this by subtracting 1 of 'start + size' overflows to zero.
> >>>>>>>>>>
> >>>>>>>>>>Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> >>
> >>Since there's no way this fits without breaking smartweb, I'd rather drop
> >>this for now in order to get 1/2 accepted.
> >
> >I thought that with 1/2 this fit again, with gcc-7.3 at least? Thanks!
>
> I'm not sure, as I don't have it here to test. But as this patch doesn't
> actually fix a board but fixes an issue in the code that *might* appear in
> the future, I'm not convinced it would be the right thing to merge it like
> it is.
>
> And I'm also a little short on time to investigate this further, as it's not
> a real bug, currently.
OK, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190505/862d365b/attachment.sig>
next prev parent reply other threads:[~2019-05-05 18:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 19:22 [U-Boot] [PATCH v5 1/2] spl: fix linker size check off-by-one errors Simon Goldschmidt
2019-04-25 19:22 ` [U-Boot] [PATCH v5 2/2] dlmalloc: fix malloc range at end of ram Simon Goldschmidt
2019-04-25 22:22 ` Marek Vasut
2019-04-26 6:19 ` Simon Goldschmidt
2019-04-26 9:32 ` Marek Vasut
2019-04-26 9:36 ` Simon Goldschmidt
2019-04-26 9:56 ` Marek Vasut
2019-04-26 10:19 ` Simon Goldschmidt
2019-04-26 11:00 ` Marek Vasut
2019-05-04 18:16 ` Simon Goldschmidt
2019-05-05 11:38 ` Tom Rini
2019-05-05 17:55 ` Simon Goldschmidt
2019-05-05 18:12 ` Tom Rini [this message]
2019-04-27 20:17 ` [U-Boot] [PATCH v5 1/2] spl: fix linker size check off-by-one errors Simon Goldschmidt
2019-05-06 11:14 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190505181230.GM31207@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox