public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [RFC PATCH 0/1] riscv: qemu-riscv environment size
@ 2019-05-05 21:36 Karsten Merker
  2019-05-05 21:36 ` [U-Boot] [RFC PATCH 1/1] riscv: increase the environment size for the qemu-riscv platform to 128kB Karsten Merker
  0 siblings, 1 reply; 4+ messages in thread
From: Karsten Merker @ 2019-05-05 21:36 UTC (permalink / raw)
  To: u-boot

Hello,

currently the environment size for the qemu-riscv platform is set
to only 4kB.  The default environment (with distro_bootcmd
support) has already nearly 4kB, so defining additional
environment variables very quickly exceeds the allocated space. 
Is there a specific reason to use only 4kB for the environment? 
If not, I would like to propose to increase the environment size
to 128kB similar to what we have on a number of other platforms.

Regards,
Karsten

Karsten Merker (1):
  riscv: increase the environment size for the qemu-riscv platform to
    128kB

 include/configs/qemu-riscv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.20.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [RFC PATCH 1/1] riscv: increase the environment size for the qemu-riscv platform to 128kB
  2019-05-05 21:36 [U-Boot] [RFC PATCH 0/1] riscv: qemu-riscv environment size Karsten Merker
@ 2019-05-05 21:36 ` Karsten Merker
  2019-05-08 13:39   ` Bin Meng
  0 siblings, 1 reply; 4+ messages in thread
From: Karsten Merker @ 2019-05-05 21:36 UTC (permalink / raw)
  To: u-boot

The existing default size of 4kB is too small as the default environment
has already nearly that size and defining a single additional environment
variable can exceed the available space.

Signed-off-by: Karsten Merker <merker@debian.org>
---
 include/configs/qemu-riscv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/configs/qemu-riscv.h b/include/configs/qemu-riscv.h
index 2588c5a0b2..3d9208bab2 100644
--- a/include/configs/qemu-riscv.h
+++ b/include/configs/qemu-riscv.h
@@ -20,7 +20,7 @@
 #define CONFIG_STANDALONE_LOAD_ADDR	0x80200000
 
 /* Environment options */
-#define CONFIG_ENV_SIZE			SZ_4K
+#define CONFIG_ENV_SIZE			SZ_128K
 
 #define BOOT_TARGET_DEVICES(func) \
 	func(QEMU, qemu, na) \
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [RFC PATCH 1/1] riscv: increase the environment size for the qemu-riscv platform to 128kB
  2019-05-05 21:36 ` [U-Boot] [RFC PATCH 1/1] riscv: increase the environment size for the qemu-riscv platform to 128kB Karsten Merker
@ 2019-05-08 13:39   ` Bin Meng
       [not found]     ` <752D002CFF5D0F4FA35C0100F1D73F3FA40CBB2F@ATCPCS16.andestech.com>
  0 siblings, 1 reply; 4+ messages in thread
From: Bin Meng @ 2019-05-08 13:39 UTC (permalink / raw)
  To: u-boot

On Mon, May 6, 2019 at 5:49 AM Karsten Merker <merker@debian.org> wrote:
>
> The existing default size of 4kB is too small as the default environment
> has already nearly that size and defining a single additional environment
> variable can exceed the available space.
>
> Signed-off-by: Karsten Merker <merker@debian.org>
> ---
>  include/configs/qemu-riscv.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [RFC PATCH 1/1] riscv: increase the environment size for the qemu-riscv platform to 128kB
       [not found]     ` <752D002CFF5D0F4FA35C0100F1D73F3FA40CBB2F@ATCPCS16.andestech.com>
@ 2019-06-04  5:43       ` Rick Chen
  0 siblings, 0 replies; 4+ messages in thread
From: Rick Chen @ 2019-06-04  5:43 UTC (permalink / raw)
  To: u-boot

> From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Bin Meng
> Sent: Wednesday, May 08, 2019 9:39 PM
> To: Karsten Merker
> Cc: U-Boot Mailing List
> Subject: Re: [U-Boot] [RFC PATCH 1/1] riscv: increase the environment size for
> the qemu-riscv platform to 128kB
>
> On Mon, May 6, 2019 at 5:49 AM Karsten Merker <merker@debian.org> wrote:
> >
> > The existing default size of 4kB is too small as the default
> > environment has already nearly that size and defining a single
> > additional environment variable can exceed the available space.
> >
> > Signed-off-by: Karsten Merker <merker@debian.org>
> > ---
> >  include/configs/qemu-riscv.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Applied to u-boot-riscv/master, thanks!

> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-06-04  5:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-05 21:36 [U-Boot] [RFC PATCH 0/1] riscv: qemu-riscv environment size Karsten Merker
2019-05-05 21:36 ` [U-Boot] [RFC PATCH 1/1] riscv: increase the environment size for the qemu-riscv platform to 128kB Karsten Merker
2019-05-08 13:39   ` Bin Meng
     [not found]     ` <752D002CFF5D0F4FA35C0100F1D73F3FA40CBB2F@ATCPCS16.andestech.com>
2019-06-04  5:43       ` Rick Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox