From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 6 May 2019 17:27:09 -0400 Subject: [U-Boot] [v4 PATCH] RISCV: image: Add booti support In-Reply-To: References: <20190506181134.9575-1-atish.patra@wdc.com> <251ea152-6407-02e2-076c-7ee377f6181d@gmx.de> <20190506203956.ty6gkmhm4dlylld4@excalibur.cnev.de> Message-ID: <20190506212709.GD31207@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, May 06, 2019 at 11:10:57PM +0200, Heinrich Schuchardt wrote: > On 5/6/19 10:39 PM, Karsten Merker wrote: > >On Mon, May 06, 2019 at 10:06:39PM +0200, Heinrich Schuchardt wrote: > >>On 5/6/19 8:11 PM, Atish Patra wrote: > >>>This patch adds booti support for RISC-V Linux kernel. The existing > >>>bootm method will also continue to work as it is. > >[...] > >>>+ "boot arm64/riscv Linux Image image from memory", booti_help_text > >> > >>%s/Image image/image/ > >> > >>"arm64/riscv" is distracting. If I am on RISC-V I cannot boot an ARM64 > >>image here. Remove the reference to the architecture, please. > > > >Hello, > > > >I'm not sure about the last point - ISTR (please correct me if my > >memory betrays me here) that an arm64 U-Boot can in principle be > >used to boot either an arm64 or an armv7 kernel, but the commands > >are different in those cases (booti for an arm64 "Image" format > >kernel and bootz for an armv7 "zImage" format kernel), so having > >the information which kernel format is supported by the > >respective commands appears useful to me. If the arm64 kernel > >image format would have a distinctive name (like "zImage" on > >armv7 or "bzImage" on x86) that would be less problematic, but > >with the confusion potential of "boot a Linux Image" (as in the > >arm64/riscv-specific "Image" format) vs "boot a Linux image" (as > >in generally some form of kernel image), I think explicitly > >mentioning the supported architectures makes sense. > > In this case you have to ensure that only the *supported* architectures > are mentioned. RISC-V is not supported on ARM64. The help should be re-worded to be both architecture agnostic and clear that it is for the Linux Kernel 'Image' format images. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: