[U-Boot] [i.MX8MM+CCF 12/41] clk: fixed_rate: add pre reloc flag

Lukasz Majewski
2019-05-08T06:57:53Z

On Tue, 7 May 2019 13:29:41 +0000
Peng Fan <peng.fan@nxp.com> wrote:

> > Subject: Re: [i.MX8MM+CCF 12/41] clk: fixed_rate: add pre reloc flag
> >
> > On Tue, 30 Apr 2019 10:18:12 +0000
> > Peng Fan <peng.fan@nxp.com> wrote:
> >
> > > Add pre reloc flag to use this driver before relocation
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > > drivers/clk/clk_fixed_rate.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/clk/clk_fixed_rate.c
> > > b/drivers/clk/clk_fixed_rate.c index 069e643fbc..debada1463 100644
> > > --- a/drivers/clk/clk_fixed_rate.c
> > > +++ b/drivers/clk/clk_fixed_rate.c
> > > @@ -45,4 +45,5 @@ U_BOOT_DRIVER(clk_fixed_rate) = {
> > > .ofdata_to_platdata = clk_fixed_rate_ofdata_to_platdata,
> > > .platdata_auto_alloc_size = sizeof(struct
> > > clk_fixed_rate), .ops = &clk_fixed_rate_ops,
> > > + .flags = DM_FLAG_PRE_RELOC,
> > > };
> >
> > This probably shall be done with proper dts file (from TPC70 - imx6q
> > conversion code):
>
> My understanding is DM_FLAG_PRE_RELOC will let the driver could be
> used before relocation.

I think that there is OR -> DM_FLAG_PRE_RELOC OR DTS
attribute (u-boot,dm-spl {pre-reloc}) to use device in early SPL.

Please look into drivers/core/lists.c Line 175:

if (pre_reloc_only) {
if (!dm_ofnode_pre_reloc(node)Â·&&
!(entry->flags & DM_FLAG_PRE_RELOC))
return 0;
}

We do not bind device only if there is NO DM_FLAG_PRE_RELOC set AND the
u-boot,dm-* property is not set in corresponding DTS node.

> The dts u-boot,dm-spl or u-boot,dm-pre-reloc
> is just to mark the device could be used at the corresponding stage.
> Only modify dts will not make it work without the DM_FLAG_PRE_RELOC,
> Right?
>
> Thanks,
> Peng.
>
> >
> > +#include "imx6qdl-u-boot.dtsi"
> > +
> > +/ {
> > + clocks {
> > + u-boot,dm-spl;
> > + osc {
> > + u-boot,dm-spl;
> > + };
> > + };
> > +};
> > +
> > +&clks {
> > + u-boot,dm-pre-reloc;
> > +};
> >
> >
> >
> > Best regards,
> >
> > Lukasz Majewski
> >
> > --
> >
> > DENX Software Engineering GmbH, Managing Director: Wolfgang
> > Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
> > Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
> > lukma at denx.de

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190508/e44944fb/attachment.sig>