From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 04/13] clk: Extend struct clk to provide information regarding clock rate
Date: Fri, 17 May 2019 08:42:00 +0200 [thread overview]
Message-ID: <20190517084200.1f092845@jawa> (raw)
In-Reply-To: <66b7e1e5-4ee9-fd2d-d66b-97e71bbb03b8@denx.de>
Hi Marek,
> On 5/17/19 12:10 AM, Lukasz Majewski wrote:
> > This commit extends the struct clk to provide information regarding
> > the clock rate.
> > As a result the clock tree traversal is performed at most once, and
> > further reads are using the cached value.
> >
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> >
> > ---
> >
> > Changes in v4:
> > - None
> >
> > Changes in v3: None
> >
> > include/clk.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/include/clk.h b/include/clk.h
> > index a909b71f1a..1f2fd15bb5 100644
> > --- a/include/clk.h
> > +++ b/include/clk.h
> > @@ -40,6 +40,7 @@ struct udevice;
> > * other clock APIs to identify which clock signal to operate upon.
> > *
> > * @dev: The device which implements the clock signal.
> > + * @rate: The clock rate (in HZ).
> > * @id: The clock signal ID within the provider.
> > * @data: An optional data field for scenarios where a single
> > integer ID is not
> > * sufficient. If used, it can be populated through
> > an .of_xlate op and @@ -55,6 +56,7 @@ struct udevice;
> > */
> > struct clk {
> > struct udevice *dev;
> > + unsigned long rate; /* in HZ */
>
> Can this be unsigned long long ? Think of 3 GHz PLL on arm32 in IDT
> Versaclock line of clock synthesisers ; this would overflow right
> here.
>
Thanks for spotting this - I will use unsigned long long instead.
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190517/760800bf/attachment.sig>
next prev parent reply other threads:[~2019-05-17 6:42 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 22:10 [U-Boot] [PATCH v4 00/13] clk: Port Linux common clock framework [CCF] to U-boot (tag: 5.0-rc3) Lukasz Majewski
2019-05-16 22:10 ` [U-Boot] [PATCH v4 01/13] clk: doc: Add documentation entry for Common Clock Framework [CCF] (i.MX) Lukasz Majewski
2019-05-16 23:22 ` Marek Vasut
2019-05-17 6:15 ` Peng Fan
2019-06-10 9:40 ` [U-Boot] [PATCH v4 01/13] clk: doc: Add documentation entry for sbabic at denx.de
2019-05-16 22:10 ` [U-Boot] [PATCH v4 02/13] dm: Fix documentation entry as there is no UCLASS_CLOCK uclass Lukasz Majewski
2019-05-17 5:52 ` Peng Fan
2019-06-10 9:59 ` [U-Boot] [PATCH v4 02/13] dm: Fix documentation entry as there is sbabic at denx.de
2019-05-16 22:10 ` [U-Boot] [PATCH v4 03/13] clk: Remove clock ID check in .get_rate() of clk_fixed_* Lukasz Majewski
2019-05-17 5:53 ` Peng Fan
2019-06-08 15:22 ` Stefano Babic
2019-06-10 9:39 ` [U-Boot] [PATCH v4 03/13] clk: Remove clock ID check in .get_rate() sbabic at denx.de
2019-05-16 22:10 ` [U-Boot] [PATCH v4 04/13] clk: Extend struct clk to provide information regarding clock rate Lukasz Majewski
2019-05-16 23:23 ` Marek Vasut
2019-05-17 6:42 ` Lukasz Majewski [this message]
2019-06-08 15:22 ` Stefano Babic
2019-06-10 9:59 ` [U-Boot] [PATCH v4 04/13] clk: Extend struct clk to provide sbabic at denx.de
2019-05-16 22:10 ` [U-Boot] [PATCH v4 05/13] clk: Extend struct clk to provide clock type agnostic flags Lukasz Majewski
2019-05-17 5:54 ` Peng Fan
2019-06-08 15:22 ` Stefano Babic
2019-06-10 9:40 ` [U-Boot] [PATCH v4 05/13] clk: Extend struct clk to provide clock sbabic at denx.de
2019-05-16 22:10 ` [U-Boot] [PATCH v4 06/13] clk: Provide struct clk for fixed rate clock (clk_fixed_rate.c) Lukasz Majewski
2019-05-17 5:55 ` Peng Fan
2019-06-08 15:23 ` Stefano Babic
2019-06-10 9:40 ` [U-Boot] [PATCH v4 06/13] clk: Provide struct clk for fixed rate sbabic at denx.de
2019-05-16 22:10 ` [U-Boot] [PATCH v4 07/13] dm: clk: Define clk_get_parent() for clk operations Lukasz Majewski
2019-05-17 5:46 ` Peng Fan
2019-05-17 5:56 ` Peng Fan
2019-05-17 5:57 ` Peng Fan
2019-05-18 16:08 ` Simon Glass
2019-05-18 20:52 ` Lukasz Majewski
2019-05-18 22:04 ` Simon Glass
2019-06-08 15:24 ` Stefano Babic
2019-06-10 9:40 ` [U-Boot] [PATCH v4 07/13] dm: clk: Define clk_get_parent() for clk sbabic at denx.de
2019-05-16 22:10 ` [U-Boot] [PATCH v4 08/13] dm: clk: Define clk_get_parent_rate() for clk operations Lukasz Majewski
2019-05-17 5:58 ` Peng Fan
2019-05-18 16:08 ` Simon Glass
2019-05-18 20:45 ` Lukasz Majewski
2019-06-10 9:39 ` [U-Boot] [PATCH v4 08/13] dm: clk: Define clk_get_parent_rate() for sbabic at denx.de
2019-05-16 22:10 ` [U-Boot] [PATCH v4 09/13] dm: clk: Define clk_get_by_id() for clk operations Lukasz Majewski
2019-05-17 5:58 ` Peng Fan
2019-05-18 16:08 ` Simon Glass
2019-05-18 20:44 ` Lukasz Majewski
2019-06-08 15:24 ` Stefano Babic
2019-06-10 9:39 ` [U-Boot] [PATCH v4 09/13] dm: clk: Define clk_get_by_id() for clk sbabic at denx.de
2019-05-16 22:10 ` [U-Boot] [PATCH v4 10/13] clk: test: Provide unit test for clk_get_by_id() method Lukasz Majewski
2019-05-17 6:00 ` Peng Fan
2019-06-10 9:41 ` [U-Boot] [PATCH v4 10/13] clk: test: Provide unit test for sbabic at denx.de
2019-05-16 22:10 ` [U-Boot] [PATCH v4 11/13] clk: test: Provide unit test for clk_get_parent_rate() method Lukasz Majewski
2019-05-18 16:33 ` Simon Glass
2019-06-10 9:49 ` [U-Boot] [PATCH v4 11/13] clk: test: Provide unit test for sbabic at denx.de
2019-05-16 22:10 ` [U-Boot] [PATCH v4 12/13] clk: Port Linux common clock framework [CCF] for imx6q to U-boot (tag: 5.0-rc3) Lukasz Majewski
2019-05-17 2:48 ` Bin Meng
2019-05-17 12:31 ` Adam Ford
2019-05-17 13:19 ` Lukasz Majewski
2019-06-10 9:40 ` [U-Boot] [PATCH v4 12/13] clk: Port Linux common clock framework sbabic at denx.de
2019-06-10 21:36 ` Lukasz Majewski
2019-06-11 8:29 ` Stefano Babic
2019-05-16 22:10 ` [U-Boot] [PATCH v4 13/13] dm: clk: Extend clk_get_parent_rate() to support CLK_GET_RATE_NOCACHE flag Lukasz Majewski
2019-05-17 6:03 ` Peng Fan
2019-06-10 9:39 ` [U-Boot] [PATCH v4 13/13] dm: clk: Extend clk_get_parent_rate() to sbabic at denx.de
2019-05-18 16:08 ` [U-Boot] [PATCH v4 00/13] clk: Port Linux common clock framework [CCF] to U-boot (tag: 5.0-rc3) Simon Glass
2019-05-18 20:49 ` Lukasz Majewski
2019-05-18 22:02 ` Simon Glass
2019-05-19 14:34 ` Lukasz Majewski
2019-05-20 15:35 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190517084200.1f092845@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox