From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 12/13] clk: Port Linux common clock framework [CCF] for imx6q to U-boot (tag: 5.0-rc3)
Date: Fri, 17 May 2019 15:19:59 +0200 [thread overview]
Message-ID: <20190517151959.65016a47@jawa> (raw)
In-Reply-To: <CAHCN7xKOO5kC85BErsb5mPQ0d_-33SxSc1ZgLZBdwL1ALgO1+g@mail.gmail.com>
On Fri, 17 May 2019 07:31:38 -0500
Adam Ford <aford173@gmail.com> wrote:
> On Thu, May 16, 2019 at 9:48 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> >
> > Hi Lukasz,
> >
> > On Fri, May 17, 2019 at 6:16 AM Lukasz Majewski <lukma@denx.de>
> > wrote:
> > >
> > > This commit brings the files from Linux kernel to provide clocks
> > > support as it is used on the Linux kernel with common clock
> > > framework [CCF] setup.
>
>
> Two issues / questions:
>
> 1) I tried to test this on the imx6q_logic board, and I enabled
> CLK_IMX6Q in the menu config, but when I save the defconfig, it
> appears there are unmet dependencies.
>
> WARNING: unmet direct dependencies detected for SPL_CLK_CCF
> Depends on [n]: SPL_CLK [=n]
> Selected by [y]:
> - CLK_IMX6Q [=y] && ARCH_MX6 [=y]
>
> WARNING: unmet direct dependencies detected for SPL_CLK_CCF
> Depends on [n]: SPL_CLK [=n]
> Selected by [y]:
> - CLK_IMX6Q [=y] && ARCH_MX6 [=y]
>
> you may want to consider implying the correct functions if ARCH_MX6 &&
> CLK_IMX6Q or select the proper SPL_CLK info. My board doesn't do DM
> in SPL right now, but I assume the CLK driver you ported is using DM.
Ok. I will look into the Kconfig options.
>
> 2) I didn't attempt to load the SPL portion, but when I loaded the
> u-boot-dtb.img file, it didn't appear to boot.
>
>
> U-Boot SPL 2019.01 (May 13 2019 - 16:57:41 -0500)
> Trying to boot from MMC1
> spl_load_image_fat_os: error reading image args, err - -2
>
>
> (hang)
>
> Other than enabling CLK_IMX6Q, are there other items I need to enable?
> My board has OF_CONTROL in U-Boot with DM support working in the
> U-Boot portion.
>
The CCF shall work also with a setup where it is enabled only in u-boot
proper (CONFIG_CLK_CCF).
Please look into following TPC DM/DTS port as a reference:
https://github.com/lmajewski/u-boot-dfu/commits/DM-SPL-TPC70
This board is fully converted and uses DM/DTS in SPL and u-boot proper
(with CCF).
> adam
> > > The directory structure has been preserved. The ported code only
> > > supports reading information from PLL, MUX, Divider, etc and
> > > enabling/disabling the clocks USDHCx/ECSPIx depending on used
> > > bus. Moreover, it is agnostic to the alias numbering as the
> > > information about the clock is read from device tree.
> > >
> > > One needs to pay attention to the comments indicating necessary
> > > for U-boot's
> >
> > nits: it's U-Boot. Please fix this globally in the commit message,
> > as well as in the code comments in this commit.
> >
> > > DM changes.
> > >
> > > If needed the code can be extended to support the "set" part of
> > > the clock management.
> > >
> > >
> > > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > > ---
> > >
> > > Changes in v4:
> > > - Port some more Linux code to facilitate imx8 code porting (most
> > > notably flags)
> > > - Explicitly use container_of() based macro to provide struct clk
> > > in various places (e.g. gate2, mux, etc)
> > > Following patches has been squashed:
> > > http://patchwork.ozlabs.org/patch/1093141/
> > > http://patchwork.ozlabs.org/patch/1093142/
> > > http://patchwork.ozlabs.org/patch/1093146/
> > >
> > > Changes in v3: None
> > >
> > > drivers/clk/Kconfig | 14 ++++
> > > drivers/clk/Makefile | 2 +
> > > drivers/clk/clk-divider.c | 148
> > > ++++++++++++++++++++++++++++++++++ drivers/clk/clk-fixed-factor.c
> > > | 87 ++++++++++++++++++++ drivers/clk/clk-mux.c | 164
> > > +++++++++++++++++++++++++++++++++++++
> > > drivers/clk/clk.c | 56 +++++++++++++
> > > drivers/clk/imx/Kconfig | 9 +++
> > > drivers/clk/imx/Makefile | 2 +
> > > drivers/clk/imx/clk-gate2.c | 113 ++++++++++++++++++++++++++
> > > drivers/clk/imx/clk-imx6q.c | 179
> > > +++++++++++++++++++++++++++++++++++++++++
> > > drivers/clk/imx/clk-pfd.c | 91 +++++++++++++++++++++
> > > drivers/clk/imx/clk-pllv3.c | 83 +++++++++++++++++++
> > > drivers/clk/imx/clk.h | 75 +++++++++++++++++
> > > include/linux/clk-provider.h | 115 ++++++++++++++++++++++++++
> > > 14 files changed, 1138 insertions(+) create mode 100644
> > > drivers/clk/clk-divider.c create mode 100644
> > > drivers/clk/clk-fixed-factor.c create mode 100644
> > > drivers/clk/clk-mux.c create mode 100644 drivers/clk/clk.c create
> > > mode 100644 drivers/clk/imx/clk-gate2.c create mode 100644
> > > drivers/clk/imx/clk-imx6q.c create mode 100644
> > > drivers/clk/imx/clk-pfd.c create mode 100644
> > > drivers/clk/imx/clk-pllv3.c create mode 100644
> > > drivers/clk/imx/clk.h create mode 100644
> > > include/linux/clk-provider.h
> >
> > Regards,
> > Bin
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190517/f6a15a84/attachment.sig>
next prev parent reply other threads:[~2019-05-17 13:19 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 22:10 [U-Boot] [PATCH v4 00/13] clk: Port Linux common clock framework [CCF] to U-boot (tag: 5.0-rc3) Lukasz Majewski
2019-05-16 22:10 ` [U-Boot] [PATCH v4 01/13] clk: doc: Add documentation entry for Common Clock Framework [CCF] (i.MX) Lukasz Majewski
2019-05-16 23:22 ` Marek Vasut
2019-05-17 6:15 ` Peng Fan
2019-06-10 9:40 ` [U-Boot] [PATCH v4 01/13] clk: doc: Add documentation entry for sbabic at denx.de
2019-05-16 22:10 ` [U-Boot] [PATCH v4 02/13] dm: Fix documentation entry as there is no UCLASS_CLOCK uclass Lukasz Majewski
2019-05-17 5:52 ` Peng Fan
2019-06-10 9:59 ` [U-Boot] [PATCH v4 02/13] dm: Fix documentation entry as there is sbabic at denx.de
2019-05-16 22:10 ` [U-Boot] [PATCH v4 03/13] clk: Remove clock ID check in .get_rate() of clk_fixed_* Lukasz Majewski
2019-05-17 5:53 ` Peng Fan
2019-06-08 15:22 ` Stefano Babic
2019-06-10 9:39 ` [U-Boot] [PATCH v4 03/13] clk: Remove clock ID check in .get_rate() sbabic at denx.de
2019-05-16 22:10 ` [U-Boot] [PATCH v4 04/13] clk: Extend struct clk to provide information regarding clock rate Lukasz Majewski
2019-05-16 23:23 ` Marek Vasut
2019-05-17 6:42 ` Lukasz Majewski
2019-06-08 15:22 ` Stefano Babic
2019-06-10 9:59 ` [U-Boot] [PATCH v4 04/13] clk: Extend struct clk to provide sbabic at denx.de
2019-05-16 22:10 ` [U-Boot] [PATCH v4 05/13] clk: Extend struct clk to provide clock type agnostic flags Lukasz Majewski
2019-05-17 5:54 ` Peng Fan
2019-06-08 15:22 ` Stefano Babic
2019-06-10 9:40 ` [U-Boot] [PATCH v4 05/13] clk: Extend struct clk to provide clock sbabic at denx.de
2019-05-16 22:10 ` [U-Boot] [PATCH v4 06/13] clk: Provide struct clk for fixed rate clock (clk_fixed_rate.c) Lukasz Majewski
2019-05-17 5:55 ` Peng Fan
2019-06-08 15:23 ` Stefano Babic
2019-06-10 9:40 ` [U-Boot] [PATCH v4 06/13] clk: Provide struct clk for fixed rate sbabic at denx.de
2019-05-16 22:10 ` [U-Boot] [PATCH v4 07/13] dm: clk: Define clk_get_parent() for clk operations Lukasz Majewski
2019-05-17 5:46 ` Peng Fan
2019-05-17 5:56 ` Peng Fan
2019-05-17 5:57 ` Peng Fan
2019-05-18 16:08 ` Simon Glass
2019-05-18 20:52 ` Lukasz Majewski
2019-05-18 22:04 ` Simon Glass
2019-06-08 15:24 ` Stefano Babic
2019-06-10 9:40 ` [U-Boot] [PATCH v4 07/13] dm: clk: Define clk_get_parent() for clk sbabic at denx.de
2019-05-16 22:10 ` [U-Boot] [PATCH v4 08/13] dm: clk: Define clk_get_parent_rate() for clk operations Lukasz Majewski
2019-05-17 5:58 ` Peng Fan
2019-05-18 16:08 ` Simon Glass
2019-05-18 20:45 ` Lukasz Majewski
2019-06-10 9:39 ` [U-Boot] [PATCH v4 08/13] dm: clk: Define clk_get_parent_rate() for sbabic at denx.de
2019-05-16 22:10 ` [U-Boot] [PATCH v4 09/13] dm: clk: Define clk_get_by_id() for clk operations Lukasz Majewski
2019-05-17 5:58 ` Peng Fan
2019-05-18 16:08 ` Simon Glass
2019-05-18 20:44 ` Lukasz Majewski
2019-06-08 15:24 ` Stefano Babic
2019-06-10 9:39 ` [U-Boot] [PATCH v4 09/13] dm: clk: Define clk_get_by_id() for clk sbabic at denx.de
2019-05-16 22:10 ` [U-Boot] [PATCH v4 10/13] clk: test: Provide unit test for clk_get_by_id() method Lukasz Majewski
2019-05-17 6:00 ` Peng Fan
2019-06-10 9:41 ` [U-Boot] [PATCH v4 10/13] clk: test: Provide unit test for sbabic at denx.de
2019-05-16 22:10 ` [U-Boot] [PATCH v4 11/13] clk: test: Provide unit test for clk_get_parent_rate() method Lukasz Majewski
2019-05-18 16:33 ` Simon Glass
2019-06-10 9:49 ` [U-Boot] [PATCH v4 11/13] clk: test: Provide unit test for sbabic at denx.de
2019-05-16 22:10 ` [U-Boot] [PATCH v4 12/13] clk: Port Linux common clock framework [CCF] for imx6q to U-boot (tag: 5.0-rc3) Lukasz Majewski
2019-05-17 2:48 ` Bin Meng
2019-05-17 12:31 ` Adam Ford
2019-05-17 13:19 ` Lukasz Majewski [this message]
2019-06-10 9:40 ` [U-Boot] [PATCH v4 12/13] clk: Port Linux common clock framework sbabic at denx.de
2019-06-10 21:36 ` Lukasz Majewski
2019-06-11 8:29 ` Stefano Babic
2019-05-16 22:10 ` [U-Boot] [PATCH v4 13/13] dm: clk: Extend clk_get_parent_rate() to support CLK_GET_RATE_NOCACHE flag Lukasz Majewski
2019-05-17 6:03 ` Peng Fan
2019-06-10 9:39 ` [U-Boot] [PATCH v4 13/13] dm: clk: Extend clk_get_parent_rate() to sbabic at denx.de
2019-05-18 16:08 ` [U-Boot] [PATCH v4 00/13] clk: Port Linux common clock framework [CCF] to U-boot (tag: 5.0-rc3) Simon Glass
2019-05-18 20:49 ` Lukasz Majewski
2019-05-18 22:02 ` Simon Glass
2019-05-19 14:34 ` Lukasz Majewski
2019-05-20 15:35 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190517151959.65016a47@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox