public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fit: Add support for printing more than one FPGA node name
Date: Sun, 19 May 2019 16:44:51 -0400	[thread overview]
Message-ID: <20190519204451.GW22232@bill-the-cat> (raw)
In-Reply-To: <1550061144-20888-1-git-send-email-tien.fong.chee@intel.com>

On Wed, Feb 13, 2019 at 08:32:24PM +0800, tien.fong.chee at intel.com wrote:

> From: Tien Fong Chee <tien.fong.chee@intel.com>
> 
> This would print out all the FPGA node names setting to fpga property.
> 
> Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> ---
>  common/image-fit.c |   14 +++++++++++---
>  1 files changed, 11 insertions(+), 3 deletions(-)
> 
> diff --git a/common/image-fit.c b/common/image-fit.c
> index ac901e1..816e17d 100644
> --- a/common/image-fit.c
> +++ b/common/image-fit.c
> @@ -263,6 +263,7 @@ static void fit_conf_print(const void *fit, int noffset, const char *p)
>  	int ret;
>  	int fdt_index, loadables_index;
>  	int ndepth;
> +	ulong count;
>  
>  	/* Mandatory properties */
>  	ret = fit_get_desc(fit, noffset, &desc);
> @@ -299,9 +300,16 @@ static void fit_conf_print(const void *fit, int noffset, const char *p)
>  		printf("%s\n", uname);
>  	}
>  
> -	uname = fdt_getprop(fit, noffset, FIT_FPGA_PROP, NULL);
> -	if (uname)
> -		printf("%s  FPGA:         %s\n", p, uname);
> +	count = fit_conf_get_prop_node_count(fit, noffset, FIT_FPGA_PROP);
> +
> +	for (ndepth = 0; ndepth < count; ndepth++) {
> +		int images_noffset = fit_conf_get_prop_node_index(fit, noffset,
> +						FIT_FPGA_PROP, ndepth);
> +		uname = fit_get_name(fit, images_noffset, NULL);
> +
> +		if (uname)
> +			printf("%s  FPGA:         %s\n", p, uname);
> +	}
>  
>  	/* Print out all of the specified loadables */
>  	for (loadables_index = 0;

There's a problem here.  When I use buildman to make multiple boards
(say 'arm', but something smaller should trigger it too), all of my
builds get stuck on mkimage doing something.  A build of a single board
is fine.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190519/84c90e31/attachment.sig>

      parent reply	other threads:[~2019-05-19 20:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-13 12:32 [U-Boot] [PATCH] fit: Add support for printing more than one FPGA node name tien.fong.chee at intel.com
2019-04-22 17:29 ` [U-Boot] " Tom Rini
2019-04-26  6:12   ` Chee, Tien Fong
2019-04-27 14:43     ` Tom Rini
2019-05-15  4:20       ` Chee, Tien Fong
2019-05-19 20:44 ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190519204451.GW22232@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox