public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd: define CMD_DATA_SIZE when CONFIG_CMD_SETEXPR is selected
Date: Mon, 20 May 2019 10:22:14 +0200	[thread overview]
Message-ID: <20190520082214.15821-1-brgl@bgdev.pl> (raw)

From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

The setexpr shell command calls cmd_get_data_size() which is only built
when CMD_DATA_SIZE is defined. We need to define CMD_DATA_SIZE if
CONFIG_CMD_SETEXPR is selected or the build will fail if no other
command selecting this option is enabled.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
 include/command.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/command.h b/include/command.h
index be74f6ac92..2bfee89df3 100644
--- a/include/command.h
+++ b/include/command.h
@@ -109,7 +109,8 @@ int cmd_process_error(cmd_tbl_t *cmdtp, int err);
 #if defined(CONFIG_CMD_MEMORY) || \
 	defined(CONFIG_CMD_I2C) || \
 	defined(CONFIG_CMD_ITEST) || \
-	defined(CONFIG_CMD_PCI)
+	defined(CONFIG_CMD_PCI) || \
+	defined(CONFIG_CMD_SETEXPR)
 #define CMD_DATA_SIZE
 extern int cmd_get_data_size(char* arg, int default_size);
 #endif
-- 
2.21.0

             reply	other threads:[~2019-05-20  8:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20  8:22 Bartosz Golaszewski [this message]
2019-06-15 17:00 ` [U-Boot] [PATCH] cmd: define CMD_DATA_SIZE when CONFIG_CMD_SETEXPR is selected Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190520082214.15821-1-brgl@bgdev.pl \
    --to=brgl@bgdev.pl \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox