public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCHv2 2/2] SPL: Default to disabling legacy image support when using FIT
Date: Thu, 23 May 2019 09:34:18 -0400	[thread overview]
Message-ID: <20190523133418.GX22232@bill-the-cat> (raw)
In-Reply-To: <4d996293-460d-f490-340d-107a5ba2c12e@ti.com>

On Thu, May 23, 2019 at 02:18:13PM +0200, Jean-Jacques Hiblot wrote:
> 
> On 23/05/2019 13:14, Tom Rini wrote:
> >When we have a FIT image being used by SPL by default that means the
> >most common case is that we'll never run into a legacy image.  Disable
> >legacy image support by default in that case to reclaim space.
> >
> >Signed-off-by: Tom Rini <trini@konsulko.com>
> >---
> >  common/spl/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/common/spl/Kconfig b/common/spl/Kconfig
> >index c7cd34449a52..55dba0d42069 100644
> >--- a/common/spl/Kconfig
> >+++ b/common/spl/Kconfig
> >@@ -101,7 +101,7 @@ config SPL_RAW_IMAGE_SUPPORT
> >  config SPL_LEGACY_IMAGE_SUPPORT
> >  	bool "Support SPL loading and booting of Legacy images"
> >-	default y if !TI_SECURE_DEVICE
> >+	default y if !TI_SECURE_DEVICE && !SPL_LOAD_FIT
> >  	help
> >  	  SPL will support loading and booting Legacy images when this option
> >  	  is y. If this is not set, SPL will move on to other available
> 
> reviewed-by and tested-by : Jean-Jacques Hiblot <jjhiblot@ti.com>

Thanks!

> Building for arm, the reduction in size is around 50 bytes

Yup, with gcc-7.3, on the platforms that set SPL_LOAD_FIT it's generally
an 84 bytes savings on aarch64 and 40 bytes on arm32.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190523/6447768b/attachment.sig>

  reply	other threads:[~2019-05-23 13:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23 11:14 [U-Boot] [PATCHv2 1/2] configs: Rename CONFIG_IMAGE_FORMAT_LEGACY to CONFIG_LEGACY_IMAGE_FORMAT Tom Rini
2019-05-23 11:14 ` [U-Boot] [PATCHv2 2/2] SPL: Default to disabling legacy image support when using FIT Tom Rini
2019-05-23 12:18   ` Jean-Jacques Hiblot
2019-05-23 13:34     ` Tom Rini [this message]
2019-07-11 22:06   ` Tom Rini
2019-07-11 22:06 ` [U-Boot] [PATCHv2 1/2] configs: Rename CONFIG_IMAGE_FORMAT_LEGACY to CONFIG_LEGACY_IMAGE_FORMAT Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190523133418.GX22232@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox