* [U-Boot] [PATCH] configs/legoev3: define CONFIG_SKIP_LOWLEVEL_INIT
@ 2019-05-29 0:02 David Lechner
2019-05-29 1:52 ` Adam Ford
0 siblings, 1 reply; 4+ messages in thread
From: David Lechner @ 2019-05-29 0:02 UTC (permalink / raw)
To: u-boot
This adds a define for CONFIG_SKIP_LOWLEVEL_INIT in the legoev3 config.
On the EV3, U-Boot is loaded into RAM by another bootloader, so we
don't need the lowlevel init in U-Boot.
Signed-off-by: David Lechner <david@lechnology.com>
---
include/configs/legoev3.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/configs/legoev3.h b/include/configs/legoev3.h
index 1e239ecadd..36ca3b201e 100644
--- a/include/configs/legoev3.h
+++ b/include/configs/legoev3.h
@@ -22,6 +22,7 @@
#define CONFIG_SYS_OSCIN_FREQ 24000000
#define CONFIG_SYS_TIMERBASE DAVINCI_TIMER0_BASE
#define CONFIG_SYS_HZ_CLOCK clk_get(DAVINCI_AUXCLK_CLKID)
+#define CONFIG_SKIP_LOWLEVEL_INIT
/*
* Memory Info
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] configs/legoev3: define CONFIG_SKIP_LOWLEVEL_INIT
2019-05-29 0:02 [U-Boot] [PATCH] configs/legoev3: define CONFIG_SKIP_LOWLEVEL_INIT David Lechner
@ 2019-05-29 1:52 ` Adam Ford
2019-05-29 1:55 ` David Lechner
0 siblings, 1 reply; 4+ messages in thread
From: Adam Ford @ 2019-05-29 1:52 UTC (permalink / raw)
To: u-boot
On Tue, May 28, 2019 at 7:03 PM David Lechner <david@lechnology.com> wrote:
>
> This adds a define for CONFIG_SKIP_LOWLEVEL_INIT in the legoev3 config.
> On the EV3, U-Boot is loaded into RAM by another bootloader, so we
> don't need the lowlevel init in U-Boot.
>
> Signed-off-by: David Lechner <david@lechnology.com>
> ---
> include/configs/legoev3.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/configs/legoev3.h b/include/configs/legoev3.h
> index 1e239ecadd..36ca3b201e 100644
> --- a/include/configs/legoev3.h
> +++ b/include/configs/legoev3.h
> @@ -22,6 +22,7 @@
> #define CONFIG_SYS_OSCIN_FREQ 24000000
> #define CONFIG_SYS_TIMERBASE DAVINCI_TIMER0_BASE
> #define CONFIG_SYS_HZ_CLOCK clk_get(DAVINCI_AUXCLK_CLKID)
> +#define CONFIG_SKIP_LOWLEVEL_INIT
If that's the case, does this mean that the NAK'd patch from Bartosz
removing the dead code can be accepted?
adam
>
> /*
> * Memory Info
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] configs/legoev3: define CONFIG_SKIP_LOWLEVEL_INIT
2019-05-29 1:52 ` Adam Ford
@ 2019-05-29 1:55 ` David Lechner
2019-05-29 7:51 ` Bartosz Golaszewski
0 siblings, 1 reply; 4+ messages in thread
From: David Lechner @ 2019-05-29 1:55 UTC (permalink / raw)
To: u-boot
On 5/28/19 8:52 PM, Adam Ford wrote:
> On Tue, May 28, 2019 at 7:03 PM David Lechner <david@lechnology.com> wrote:
>>
>> This adds a define for CONFIG_SKIP_LOWLEVEL_INIT in the legoev3 config.
>> On the EV3, U-Boot is loaded into RAM by another bootloader, so we
>> don't need the lowlevel init in U-Boot.
>>
>> Signed-off-by: David Lechner <david@lechnology.com>
>> ---
>> include/configs/legoev3.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/configs/legoev3.h b/include/configs/legoev3.h
>> index 1e239ecadd..36ca3b201e 100644
>> --- a/include/configs/legoev3.h
>> +++ b/include/configs/legoev3.h
>> @@ -22,6 +22,7 @@
>> #define CONFIG_SYS_OSCIN_FREQ 24000000
>> #define CONFIG_SYS_TIMERBASE DAVINCI_TIMER0_BASE
>> #define CONFIG_SYS_HZ_CLOCK clk_get(DAVINCI_AUXCLK_CLKID)
>> +#define CONFIG_SKIP_LOWLEVEL_INIT
>
> If that's the case, does this mean that the NAK'd patch from Bartosz
> removing the dead code can be accepted?
Probably
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] configs/legoev3: define CONFIG_SKIP_LOWLEVEL_INIT
2019-05-29 1:55 ` David Lechner
@ 2019-05-29 7:51 ` Bartosz Golaszewski
0 siblings, 0 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2019-05-29 7:51 UTC (permalink / raw)
To: u-boot
śr., 29 maj 2019 o 03:55 David Lechner <david@lechnology.com> napisał(a):
>
> On 5/28/19 8:52 PM, Adam Ford wrote:
> > On Tue, May 28, 2019 at 7:03 PM David Lechner <david@lechnology.com> wrote:
> >>
> >> This adds a define for CONFIG_SKIP_LOWLEVEL_INIT in the legoev3 config.
> >> On the EV3, U-Boot is loaded into RAM by another bootloader, so we
> >> don't need the lowlevel init in U-Boot.
> >>
> >> Signed-off-by: David Lechner <david@lechnology.com>
> >> ---
> >> include/configs/legoev3.h | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/include/configs/legoev3.h b/include/configs/legoev3.h
> >> index 1e239ecadd..36ca3b201e 100644
> >> --- a/include/configs/legoev3.h
> >> +++ b/include/configs/legoev3.h
> >> @@ -22,6 +22,7 @@
> >> #define CONFIG_SYS_OSCIN_FREQ 24000000
> >> #define CONFIG_SYS_TIMERBASE DAVINCI_TIMER0_BASE
> >> #define CONFIG_SYS_HZ_CLOCK clk_get(DAVINCI_AUXCLK_CLKID)
> >> +#define CONFIG_SKIP_LOWLEVEL_INIT
> >
> > If that's the case, does this mean that the NAK'd patch from Bartosz
> > removing the dead code can be accepted?
>
> Probably
I will resend the two patches in a single series to avoid confusion.
Bart
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-29 7:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-29 0:02 [U-Boot] [PATCH] configs/legoev3: define CONFIG_SKIP_LOWLEVEL_INIT David Lechner
2019-05-29 1:52 ` Adam Ford
2019-05-29 1:55 ` David Lechner
2019-05-29 7:51 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox