From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 3 Jun 2019 09:56:12 -0400 Subject: [U-Boot] [EXT] Re: [PATCH v2 1/5] spl: dm: disable SPI DM flash for non-DM SPL In-Reply-To: References: <20190524044057.47076-1-chuanhua.han@nxp.com> <20190524142427.GA7665@bill-the-cat> <20190530194311.GV20781@bill-the-cat> Message-ID: <20190603135612.GC7705@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de On Mon, Jun 03, 2019 at 04:18:29AM +0000, Chuanhua Han wrote: > > > > -----Original Message----- > > From: Tom Rini > > Sent: 2019年5月31日 3:43 > > To: Chuanhua Han > > Cc: jagan at openedev.com; wd at denx.de; Shengzhou Liu > > ; Ruchika Gupta ; Pan > > Jiafei ; u-boot at lists.denx.de; Jiafei Pan > > ; Yinbo Zhu > > Subject: Re: [EXT] Re: [U-Boot] [PATCH v2 1/5] spl: dm: disable SPI DM flash for > > non-DM SPL > > > > On Thu, May 30, 2019 at 10:45:10AM +0000, Chuanhua Han wrote: > > > > > > > > > > -----Original Message----- > > > > From: Tom Rini > > > > Sent: 2019年5月24日 22:24 > > > > To: Chuanhua Han > > > > Cc: jagan at openedev.com; wd at denx.de; Shengzhou Liu > > > > ; Ruchika Gupta ; Pan > > > > Jiafei ; u-boot at lists.denx.de; Jiafei Pan > > > > ; Yinbo Zhu > > > > Subject: [EXT] Re: [U-Boot] [PATCH v2 1/5] spl: dm: disable SPI DM > > > > flash for non-DM SPL > > > > > > > > On Fri, May 24, 2019 at 12:40:53PM +0800, Chuanhua Han wrote: > > > > > > > > > This patch solves the problem that spiboot cannot be performed in > > > > > non-DM SPL. > > > > > > > > > > Signed-off-by: Pan Jiafei > > > > > Signed-off-by: Chuanhua Han > > > > > --- > > > > > Changes in v2: > > > > > - No change. > > > > > > > > > > include/config_uncmd_spl.h | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > diff --git a/include/config_uncmd_spl.h > > > > > b/include/config_uncmd_spl.h index c2f9735ce7..da94b3d9df 100644 > > > > > --- a/include/config_uncmd_spl.h > > > > > +++ b/include/config_uncmd_spl.h > > > > > @@ -15,6 +15,7 @@ > > > > > #undef CONFIG_DM_GPIO > > > > > #undef CONFIG_DM_I2C > > > > > #undef CONFIG_DM_SPI > > > > > +#undef CONFIG_DM_SPI_FLASH > > > > > #endif > > > > > > > > > > #undef CONFIG_DM_WARN > > > > > > > > Long term, this shows places where we need CONFIG_SPL_DM_xxx and > > > > code should be using CONFIG_IS_ENABLED(DM_xxx). Please update at > > > > least the DM_SPI_FLASH case you're finding to behave like that, thanks! > > > I don't understand you very much. Are you saying to modify the spi-flash > > related code? > > > > Correct. include/config_uncmd_spl.h should be removed as there should, > > long term, be no cases of code in SPL that we can / should exclude not > > guarded by CONFIG_SPL_xxx instead. > Do you mean include/config_uncmd_spl.h will be deleted in the future? > Why did you start adding this file? The file config_uncmd_spl.h predates the CONFIG_IS_ENABLED() macro and whats left in that file should have code in question migrated to use CONFIG_IS_ENABLED(xxx) and as needed new CONFIG_SPL_xxx symbols added, in case some places _do_ need it. I'm not asking you to do this migrated, but I don't want to see more technical debt added here. We can solve the problem you're seeing around CONFIG_DM_SPI_FLASH in another easier to maintain manner. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: