* [U-Boot] [PATCH] video: meson: hdmi-supply regulator should be optional
@ 2019-06-04 20:26 Maxime Jourdan
2019-06-05 7:24 ` Neil Armstrong
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Maxime Jourdan @ 2019-06-04 20:26 UTC (permalink / raw)
To: u-boot
Some boards don't have such a regulator, and don't need one to enable
HDMI display. Make it optional, fixing hdmi display for those boards.
Also surround the regulator code with a config check on DM_REGULATOR.
Reported-by: Mohammad Rasim <mohammad.rasim96@gmail.com>
Signed-off-by: Maxime Jourdan <mjourdan@baylibre.com>
---
drivers/video/meson/meson_dw_hdmi.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/video/meson/meson_dw_hdmi.c b/drivers/video/meson/meson_dw_hdmi.c
index 7a1c060856..483c93f6b6 100644
--- a/drivers/video/meson/meson_dw_hdmi.c
+++ b/drivers/video/meson/meson_dw_hdmi.c
@@ -361,13 +361,19 @@ static int meson_dw_hdmi_probe(struct udevice *dev)
priv->hdmi.i2c_clk_high = 0x67;
priv->hdmi.i2c_clk_low = 0x78;
+#if CONFIG_IS_ENABLED(DM_REGULATOR)
ret = device_get_supply_regulator(dev, "hdmi-supply", &supply);
- if (ret)
+ if (ret && ret != -ENOENT) {
+ pr_err("Failed to get HDMI regulator\n");
return ret;
+ }
- ret = regulator_set_enable(supply, true);
- if (ret)
- return ret;
+ if (!ret) {
+ ret = regulator_set_enable(supply, true);
+ if (ret)
+ return ret;
+ }
+#endif
ret = reset_get_bulk(dev, &resets);
if (ret)
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] video: meson: hdmi-supply regulator should be optional
2019-06-04 20:26 [U-Boot] [PATCH] video: meson: hdmi-supply regulator should be optional Maxime Jourdan
@ 2019-06-05 7:24 ` Neil Armstrong
2019-06-05 8:17 ` Mohammad Rasim
2019-06-05 8:54 ` Anatolij Gustschin
2 siblings, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2019-06-05 7:24 UTC (permalink / raw)
To: u-boot
On 04/06/2019 22:26, Maxime Jourdan wrote:
> Some boards don't have such a regulator, and don't need one to enable
> HDMI display. Make it optional, fixing hdmi display for those boards.
>
> Also surround the regulator code with a config check on DM_REGULATOR.
>
> Reported-by: Mohammad Rasim <mohammad.rasim96@gmail.com>
> Signed-off-by: Maxime Jourdan <mjourdan@baylibre.com>
> ---
> drivers/video/meson/meson_dw_hdmi.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/meson/meson_dw_hdmi.c b/drivers/video/meson/meson_dw_hdmi.c
> index 7a1c060856..483c93f6b6 100644
> --- a/drivers/video/meson/meson_dw_hdmi.c
> +++ b/drivers/video/meson/meson_dw_hdmi.c
> @@ -361,13 +361,19 @@ static int meson_dw_hdmi_probe(struct udevice *dev)
> priv->hdmi.i2c_clk_high = 0x67;
> priv->hdmi.i2c_clk_low = 0x78;
>
> +#if CONFIG_IS_ENABLED(DM_REGULATOR)
> ret = device_get_supply_regulator(dev, "hdmi-supply", &supply);
> - if (ret)
> + if (ret && ret != -ENOENT) {
> + pr_err("Failed to get HDMI regulator\n");
> return ret;
> + }
>
> - ret = regulator_set_enable(supply, true);
> - if (ret)
> - return ret;
> + if (!ret) {
> + ret = regulator_set_enable(supply, true);
> + if (ret)
> + return ret;
> + }
> +#endif
>
> ret = reset_get_bulk(dev, &resets);
> if (ret)
>
Good catch !
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] video: meson: hdmi-supply regulator should be optional
2019-06-04 20:26 [U-Boot] [PATCH] video: meson: hdmi-supply regulator should be optional Maxime Jourdan
2019-06-05 7:24 ` Neil Armstrong
@ 2019-06-05 8:17 ` Mohammad Rasim
2019-06-05 8:54 ` Anatolij Gustschin
2 siblings, 0 replies; 4+ messages in thread
From: Mohammad Rasim @ 2019-06-05 8:17 UTC (permalink / raw)
To: u-boot
On 19/06/04 10:26PM, Maxime Jourdan wrote:
> Some boards don't have such a regulator, and don't need one to enable
> HDMI display. Make it optional, fixing hdmi display for those boards.
>
> Also surround the regulator code with a config check on DM_REGULATOR.
>
> Reported-by: Mohammad Rasim <mohammad.rasim96@gmail.com>
> Signed-off-by: Maxime Jourdan <mjourdan@baylibre.com>
> ---
> drivers/video/meson/meson_dw_hdmi.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/meson/meson_dw_hdmi.c b/drivers/video/meson/meson_dw_hdmi.c
> index 7a1c060856..483c93f6b6 100644
> --- a/drivers/video/meson/meson_dw_hdmi.c
> +++ b/drivers/video/meson/meson_dw_hdmi.c
> @@ -361,13 +361,19 @@ static int meson_dw_hdmi_probe(struct udevice *dev)
> priv->hdmi.i2c_clk_high = 0x67;
> priv->hdmi.i2c_clk_low = 0x78;
>
> +#if CONFIG_IS_ENABLED(DM_REGULATOR)
> ret = device_get_supply_regulator(dev, "hdmi-supply", &supply);
> - if (ret)
> + if (ret && ret != -ENOENT) {
> + pr_err("Failed to get HDMI regulator\n");
> return ret;
> + }
>
> - ret = regulator_set_enable(supply, true);
> - if (ret)
> - return ret;
> + if (!ret) {
> + ret = regulator_set_enable(supply, true);
> + if (ret)
> + return ret;
> + }
> +#endif
>
> ret = reset_get_bulk(dev, &resets);
> if (ret)
> --
> 2.21.0
>
Tested-by: Mohammad Rasim <mohammad.rasim96@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] video: meson: hdmi-supply regulator should be optional
2019-06-04 20:26 [U-Boot] [PATCH] video: meson: hdmi-supply regulator should be optional Maxime Jourdan
2019-06-05 7:24 ` Neil Armstrong
2019-06-05 8:17 ` Mohammad Rasim
@ 2019-06-05 8:54 ` Anatolij Gustschin
2 siblings, 0 replies; 4+ messages in thread
From: Anatolij Gustschin @ 2019-06-05 8:54 UTC (permalink / raw)
To: u-boot
On Tue, 4 Jun 2019 22:26:19 +0200
Maxime Jourdan mjourdan at baylibre.com wrote:
> ---
> drivers/video/meson/meson_dw_hdmi.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
Applied to u-boot-video/master, thanks!
--
Anatolij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-05 8:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-04 20:26 [U-Boot] [PATCH] video: meson: hdmi-supply regulator should be optional Maxime Jourdan
2019-06-05 7:24 ` Neil Armstrong
2019-06-05 8:17 ` Mohammad Rasim
2019-06-05 8:54 ` Anatolij Gustschin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox