From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 03/11] ARM: display5: Fix CS check after moving some SPI related CONFIGs to Kconfig
Date: Sun, 9 Jun 2019 22:54:39 +0200 [thread overview]
Message-ID: <20190609205447.11212-4-lukma@denx.de> (raw)
In-Reply-To: <20190609205447.11212-1-lukma@denx.de>
After commit 14453fbfadc2 ("Convert CONFIG_SF_DEFAULT_* to Kconfig")
and commit abe66b1b5dec ("Convert CONFIG_ENV_SPI_* to Kconfig") ,which
moved some SPI related CONFIG_* defines to Kconfig the display5 board has
become unbootable as the SPI CS check condition had wrong value.
This commit fixes this check and allows proper SPI NOR flash operation in
SPL.
Signed-off-by: Lukasz Majewski <lukma@denx.de>
---
board/liebherr/display5/common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/liebherr/display5/common.c b/board/liebherr/display5/common.c
index 4eb86d8c5d..48b5c1a6f5 100644
--- a/board/liebherr/display5/common.c
+++ b/board/liebherr/display5/common.c
@@ -68,7 +68,7 @@ iomux_v3_cfg_t const ecspi2_pads[] = {
int board_spi_cs_gpio(unsigned int bus, unsigned int cs)
{
- if (bus != 1 || cs != (IMX_GPIO_NR(5, 29) << 8))
+ if (bus != 1 || cs != 0)
return -EINVAL;
return IMX_GPIO_NR(5, 29);
--
2.11.0
next prev parent reply other threads:[~2019-06-09 20:54 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-09 20:54 [U-Boot] [PATCH v1 00/11] DM: display5: Convert display5 board to DM/DTS (including 'factory' setup) Lukasz Majewski
2019-06-09 20:54 ` [U-Boot] [PATCH v1 01/11] cosmetic: display5: Remove not needed comments Lukasz Majewski
2019-06-10 1:36 ` Peng Fan
2019-07-20 8:57 ` sbabic at denx.de
2019-06-09 20:54 ` [U-Boot] [PATCH v1 02/11] cosmetic: Update comment in cmd/eeprom.c Lukasz Majewski
2019-06-10 1:36 ` Peng Fan
2019-07-20 8:45 ` sbabic at denx.de
2019-06-09 20:54 ` Lukasz Majewski [this message]
2019-07-20 8:46 ` [U-Boot] [PATCH v1 03/11] ARM: display5: Fix CS check after moving some SPI related CONFIGs to Kconfig sbabic at denx.de
2019-06-09 20:54 ` [U-Boot] [PATCH v1 04/11] gpio: Add missing parenthesis to the GPIO_TO_PORT define Lukasz Majewski
2019-06-10 1:38 ` Peng Fan
2019-07-20 8:46 ` sbabic at denx.de
2019-06-09 20:54 ` [U-Boot] [PATCH v1 05/11] ARM: display5: Increase the pre-relocation malloc pool size to 4KiB Lukasz Majewski
2019-06-10 1:41 ` Peng Fan
2019-06-10 6:04 ` Lukasz Majewski
2019-06-10 6:43 ` Peng Fan
2019-07-20 8:46 ` sbabic at denx.de
2019-06-09 20:54 ` [U-Boot] [PATCH v1 06/11] DTS: imx: Add display5 board (imx6q based) device tree description (v5.1) Lukasz Majewski
2019-06-10 1:41 ` Peng Fan
2019-07-20 8:57 ` sbabic at denx.de
2019-06-09 20:54 ` [U-Boot] [PATCH v1 07/11] DTS: Add imx6q-display5-u-boot.dtsi file with u-boot specific properties Lukasz Majewski
2019-06-10 1:43 ` Peng Fan
2019-06-10 10:52 ` Adam Ford
2019-06-10 12:23 ` Lukasz Majewski
2019-07-20 8:45 ` sbabic at denx.de
2019-06-09 20:54 ` [U-Boot] [PATCH v1 08/11] ARM: display5: Remove U_BOOT_DEVICE definition of serial_mxc Lukasz Majewski
2019-06-10 1:44 ` Peng Fan
2019-07-20 8:45 ` sbabic at denx.de
2019-06-09 20:54 ` [U-Boot] [PATCH v1 09/11] DM: display5: Convert display5 board to use DM/DTS Lukasz Majewski
2019-06-10 1:45 ` Peng Fan
2019-06-09 20:54 ` [U-Boot] [PATCH v1 10/11] ARM: display5: Remove UART initialization code after DM/DTS conversion (non-console) Lukasz Majewski
2019-06-10 1:44 ` Peng Fan
2019-06-09 20:54 ` [U-Boot] [PATCH v1 11/11] ARM: display5: Remove common.c file (after DM/DTS U-Boot proper conversion) Lukasz Majewski
2019-06-10 1:46 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190609205447.11212-4-lukma@denx.de \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox