* [U-Boot] [PATCH] net: fec_mxc: not access reserved register on i.MX8
@ 2019-04-15 5:18 Peng Fan
2019-04-15 21:19 ` Joe Hershberger
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Peng Fan @ 2019-04-15 5:18 UTC (permalink / raw)
To: u-boot
We should not access reserved register on i.MX8, otherwise met SERROR
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/net/fec_mxc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
index 84f010d805..097bbd090f 100644
--- a/drivers/net/fec_mxc.c
+++ b/drivers/net/fec_mxc.c
@@ -604,7 +604,7 @@ static int fec_init(struct eth_device *dev, bd_t *bd)
writel(0x00000000, &fec->eth->gaddr2);
/* Do not access reserved register */
- if (!is_mx6ul() && !is_mx6ull() && !is_imx8m()) {
+ if (!is_mx6ul() && !is_mx6ull() && !is_imx8() && !is_imx8m()) {
/* clear MIB RAM */
for (i = mib_ptr; i <= mib_ptr + 0xfc; i += 4)
writel(0, i);
--
2.16.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] net: fec_mxc: not access reserved register on i.MX8
2019-04-15 5:18 [U-Boot] [PATCH] net: fec_mxc: not access reserved register on i.MX8 Peng Fan
@ 2019-04-15 21:19 ` Joe Hershberger
2019-05-06 6:31 ` Peng Fan
2019-06-10 11:24 ` Anatolij Gustschin
2 siblings, 0 replies; 8+ messages in thread
From: Joe Hershberger @ 2019-04-15 21:19 UTC (permalink / raw)
To: u-boot
On Mon, Apr 15, 2019 at 12:18 AM Peng Fan <peng.fan@nxp.com> wrote:
>
> We should not access reserved register on i.MX8, otherwise met SERROR
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] net: fec_mxc: not access reserved register on i.MX8
@ 2019-04-25 9:57 Peng Fan
0 siblings, 0 replies; 8+ messages in thread
From: Peng Fan @ 2019-04-25 9:57 UTC (permalink / raw)
To: u-boot
Hi Joe,
> On Mon, Apr 15, 2019 at 12:18 AM Peng Fan <peng.fan@nxp.com> wrote:
> >
> > We should not access reserved register on i.MX8, otherwise met SERROR
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Will you pick up this patch?
Thanks,
Peng.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] net: fec_mxc: not access reserved register on i.MX8
2019-04-15 5:18 [U-Boot] [PATCH] net: fec_mxc: not access reserved register on i.MX8 Peng Fan
2019-04-15 21:19 ` Joe Hershberger
@ 2019-05-06 6:31 ` Peng Fan
2019-06-10 11:24 ` Anatolij Gustschin
2 siblings, 0 replies; 8+ messages in thread
From: Peng Fan @ 2019-05-06 6:31 UTC (permalink / raw)
To: u-boot
Hi Stefano,
I do not see this patch applied to your tree, would you pick it up?
Patchwork: https://patchwork.ozlabs.org/patch/1085432/
Thanks,
Peng.
> Subject: [PATCH] net: fec_mxc: not access reserved register on i.MX8
>
> We should not access reserved register on i.MX8, otherwise met SERROR
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> drivers/net/fec_mxc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index
> 84f010d805..097bbd090f 100644
> --- a/drivers/net/fec_mxc.c
> +++ b/drivers/net/fec_mxc.c
> @@ -604,7 +604,7 @@ static int fec_init(struct eth_device *dev, bd_t *bd)
> writel(0x00000000, &fec->eth->gaddr2);
>
> /* Do not access reserved register */
> - if (!is_mx6ul() && !is_mx6ull() && !is_imx8m()) {
> + if (!is_mx6ul() && !is_mx6ull() && !is_imx8() && !is_imx8m()) {
> /* clear MIB RAM */
> for (i = mib_ptr; i <= mib_ptr + 0xfc; i += 4)
> writel(0, i);
> --
> 2.16.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] net: fec_mxc: not access reserved register on i.MX8
2019-04-15 5:18 [U-Boot] [PATCH] net: fec_mxc: not access reserved register on i.MX8 Peng Fan
2019-04-15 21:19 ` Joe Hershberger
2019-05-06 6:31 ` Peng Fan
@ 2019-06-10 11:24 ` Anatolij Gustschin
2019-06-10 13:02 ` Stefano Babic
2 siblings, 1 reply; 8+ messages in thread
From: Anatolij Gustschin @ 2019-06-10 11:24 UTC (permalink / raw)
To: u-boot
On Mon, 15 Apr 2019 05:18:33 +0000
Peng Fan peng.fan at nxp.com wrote:
> We should not access reserved register on i.MX8, otherwise met SERROR
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> drivers/net/fec_mxc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to u-boot-staging/agust at denx.de, thanks!
--
Anatolij
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] net: fec_mxc: not access reserved register on i.MX8
2019-06-10 11:24 ` Anatolij Gustschin
@ 2019-06-10 13:02 ` Stefano Babic
2019-06-10 13:12 ` Anatolij Gustschin
0 siblings, 1 reply; 8+ messages in thread
From: Stefano Babic @ 2019-06-10 13:02 UTC (permalink / raw)
To: u-boot
Hi Anatolji,
On 10/06/19 13:24, Anatolij Gustschin wrote:
> On Mon, 15 Apr 2019 05:18:33 +0000
> Peng Fan peng.fan at nxp.com wrote:
>
>> We should not access reserved register on i.MX8, otherwise met SERROR
>>
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> ---
>> drivers/net/fec_mxc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Applied to u-boot-staging/agust at denx.de, thanks!
>
I have this in u-boot-imx, too, but I do not think it is a problem when
we send PR to Tom.
Stefano
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] net: fec_mxc: not access reserved register on i.MX8
2019-06-10 13:02 ` Stefano Babic
@ 2019-06-10 13:12 ` Anatolij Gustschin
0 siblings, 0 replies; 8+ messages in thread
From: Anatolij Gustschin @ 2019-06-10 13:12 UTC (permalink / raw)
To: u-boot
Hi Stefano,
On Mon, 10 Jun 2019 15:02:37 +0200
Stefano Babic sbabic at denx.de wrote:
...
> I have this in u-boot-imx, too, but I do not think it is a problem when
> we send PR to Tom.
OK, thanks! Yes, it shouldn't be a problem.
--
Anatolij
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] net: fec_mxc: not access reserved register on i.MX8
@ 2019-06-11 8:44 sbabic at denx.de
0 siblings, 0 replies; 8+ messages in thread
From: sbabic at denx.de @ 2019-06-11 8:44 UTC (permalink / raw)
To: u-boot
> We should not access reserved register on i.MX8, otherwise met SERROR
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-06-11 8:44 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-15 5:18 [U-Boot] [PATCH] net: fec_mxc: not access reserved register on i.MX8 Peng Fan
2019-04-15 21:19 ` Joe Hershberger
2019-05-06 6:31 ` Peng Fan
2019-06-10 11:24 ` Anatolij Gustschin
2019-06-10 13:02 ` Stefano Babic
2019-06-10 13:12 ` Anatolij Gustschin
-- strict thread matches above, loose matches on Subject: below --
2019-04-25 9:57 Peng Fan
2019-06-11 8:44 sbabic at denx.de
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox