[U-Boot] Poplar broken in U-Boot v2019.07-rc4

[Shawn Guo <shawn.guo@linaro.org>]

On Mon, Jun 17, 2019 at 10:19:14AM +0800, Bin Meng wrote:
> Hi,
> 
> On Mon, Jun 17, 2019 at 10:17 AM Shawn Guo <shawn.guo@linaro.org> wrote:
> >
> > On Sun, Jun 16, 2019 at 07:36:08PM +0200, Andreas Färber wrote:
> > > Hello,
> > >
> > > Am 11.06.19 um 03:31 schrieb Tom Rini:
> > > > It's release day and here is v2019.07-rc4.   At this point, I know we
> > > > have some regression fixes for i.MX that are coming, and I'm expecting a
> > > > fix to the build time failure for tinker-rk3288.
> > > >
> > > > To repeat myself about DM migration deadlines, first, let me say again,
> > > > that DM is not required for SPL.  This comes up enough that I want to
> > > > say it again here.  Next, if there is active progress on converting
> > > > things, we'll keep from pulling the code out.  This is why for example,
> > > > we haven't yet pulled out a lot of deprecated SPI code.  Some of it is
> > > > still in progress on being converted, so I need to update the series I
> > > > posted after the last -rc to remove still less drivers.
> > >
> > > I've noticed that Poplar board is regressing with v2019.07-rc4 compared
> > > to v2019.04. It doesn't even show a U-Boot version banner:
> > >
> > > INFO:    Boot BL33 from 0x37000000 for 0 Bytes
> > > NOTICE:  BL31: v2.1(debug):
> > > NOTICE:  BL31: Built : 16:00:26, Jun 16 2019
> > > INFO:    ARM GICv2 driver initialized
> > > INFO:    BL31: Initializing runtime services
> > > WARNING: BL31: cortex_a53: CPU workaround for 819472 was missing!
> > > WARNING: BL31: cortex_a53: CPU workaround for 824069 was missing!
> > > WARNING: BL31: cortex_a53: CPU workaround for 827319 was missing!
> > > INFO:    BL31: cortex_a53: CPU workaround for 855873 was applied
> > > INFO:    BL31: InitINFO:    BL31: Preparing for EL3 exit to normal world
> > > INFO:    Entry point address = 0x37000000
> > > INFO:    SPSR = 0x3c9
> > >
> > > I'm using TF-A v2.1 with the pending eMMC fix from
> > > https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/1230
> > > but same issue without that patch.
> > >
> > > I don't see any report or fix for this yet - is this related to DM?
> >
> > Thanks for reporting, Andreas.  I just ran a git bisect which points to
> > commit below.
> >
> >   3a7c45f6a772 ("simple-bus: add DM_FLAG_PRE_RELOC flag to simple-bus driver")
> >
> > I'm not sure this indicates above commit is problematic or Poplar
> > platform is buggy on DM support though.
> 
> Please increase CONFIG_SYS_MALLOC_F_LEN and have a try. The above
> commits makes the simple-bus driver available before pre-relocation
> which requires a little more memory.

Ah, thanks much for the input, Bin.  It worked!  I will send a fix for
it shortly.

Shawn