[U-Boot] [PATCH v4 5/6] ARM: imx: pinctrl: Add support for i.MX2[38] mxs pinctrl driver

Lukasz Majewski
2019-06-19T06:51:02Z

Hi Marek,

> On 6/19/19 12:01 AM, Lukasz Majewski wrote:
> > The code responsible for setting proper values in the MUX registers
> > (in the mxs_pinctrl_set_state()) has been ported from Linux kernel
> > - SHA1: 17bb763e7eaf tag v5.1.11 from linux-stable.
>
> Maybe you want to keep the DTs and this driver based off the same
> version of Linux kernel.

I will keep and used the v5.1.11 in both drivers.

>
> Tags are "pinctrl: mxs: ".

I will fix the tags globally.

>
> > As the pinctrl node in the imx28.dtsi file has gpio pins nodes as
> > subnodes, it was necessary to use 'dm_scan_fdt_dev()' (as a .bind
> > method) to also make them 'visible' by the DM's "gpio_mxs" driver.
> >
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> >
>
> [...]
>
> > +static void mxs_pinctrl_rmwl(u32 value, u32 mask, u8 shift, void
> > __iomem *reg) +{
> > + u32 tmp;
>
> This is clrsetbits_le32() reimplementation.

Ach, right. I will leave the mxs_pinctrl_rmwl wrapper function and
replace below code with clrsetbits_le32.

>
> > + tmp = readl(reg);
> > + tmp &= ~(mask << shift);
> > + tmp |= value << shift;
> > + writel(tmp, reg);
> > +}
> [...
>

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190619/a808f0b2/attachment.sig>