From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] watchdog: tangier: Convert to use WDT class
Date: Fri, 21 Jun 2019 13:29:01 +0300 [thread overview]
Message-ID: <20190621102901.GJ9224@smile.fi.intel.com> (raw)
In-Reply-To: <CAEUhbmU4h_W+O_Lb7aWO4wRrYzgNdq0yrKMSdXOiOQc_N3Hmrg@mail.gmail.com>
On Fri, Jun 21, 2019 at 03:19:39PM +0800, Bin Meng wrote:
> On Thu, Jun 13, 2019 at 7:10 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > On Thu, Jun 13, 2019 at 06:51:34AM +0200, Stefan Roese wrote:
> > > On 12.06.19 19:28, Andy Shevchenko wrote:
> >
> > > > #define WDT_DEFAULT_TIMEOUT 90
> > >
> > > Nitpicking: If you by any chance need to re-send this patch again,
> > > please remove WDT_DEFAULT_TIMEOUT completely from this file.
> >
> > This is left in order to have some traces of what firmware default is in use.
> > I can convert this into comment.
> >
>
> Would you do a v3 to address this?
Yes. Just sent v3.
> > > Reviewed-by: Stefan Roese <sr@denx.de>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2019-06-21 10:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 17:28 [U-Boot] [PATCH v2] watchdog: tangier: Convert to use WDT class Andy Shevchenko
2019-06-13 4:51 ` Stefan Roese
2019-06-13 11:10 ` Andy Shevchenko
2019-06-13 11:57 ` Stefan Roese
2019-06-21 7:19 ` Bin Meng
2019-06-21 10:29 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190621102901.GJ9224@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox