public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] ARM: da850-evm: Remove duplicate UART initialization
@ 2019-06-23 22:48 Adam Ford
  2019-07-28 21:49 ` Tom Rini
  0 siblings, 1 reply; 2+ messages in thread
From: Adam Ford @ 2019-06-23 22:48 UTC (permalink / raw)
  To: u-boot

The Low Level init functions start the UART, so it doesn't need
to happen during board_init.  This patch removes it from
board_init.

Signed-off-by: Adam Ford <aford173@gmail.com>

diff --git a/board/davinci/da8xxevm/da850evm.c b/board/davinci/da8xxevm/da850evm.c
index a90b7a3538..c5404e6063 100644
--- a/board/davinci/da8xxevm/da850evm.c
+++ b/board/davinci/da8xxevm/da850evm.c
@@ -368,11 +368,6 @@ int board_init(void)
 	davinci_emac_mii_mode_sel(HAS_RMII);
 #endif /* CONFIG_DRIVER_TI_EMAC */
 
-	/* enable the console UART */
-	writel((DAVINCI_UART_PWREMU_MGMT_FREE | DAVINCI_UART_PWREMU_MGMT_URRST |
-		DAVINCI_UART_PWREMU_MGMT_UTRST),
-	       &davinci_uart2_ctrl_regs->pwremu_mgmt);
-
 	return 0;
 }
 
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH] ARM: da850-evm: Remove duplicate UART initialization
  2019-06-23 22:48 [U-Boot] [PATCH] ARM: da850-evm: Remove duplicate UART initialization Adam Ford
@ 2019-07-28 21:49 ` Tom Rini
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2019-07-28 21:49 UTC (permalink / raw)
  To: u-boot

On Sun, Jun 23, 2019 at 05:48:36PM -0500, Adam Ford wrote:

> The Low Level init functions start the UART, so it doesn't need
> to happen during board_init.  This patch removes it from
> board_init.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> 
> diff --git a/board/davinci/da8xxevm/da850evm.c b/board/davinci/da8xxevm/da850evm.c
> index a90b7a3538..c5404e6063 100644

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190728/e218248f/attachment.sig>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-07-28 21:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-23 22:48 [U-Boot] [PATCH] ARM: da850-evm: Remove duplicate UART initialization Adam Ford
2019-07-28 21:49 ` Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox