From: Eugeniu Rosca <roscaeugeniu@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fastboot: Remove "bootloader-version" variable
Date: Wed, 26 Jun 2019 00:12:12 +0200 [thread overview]
Message-ID: <20190625221212.GA30275@x230> (raw)
In-Reply-To: <20190620140001.12811-1-semen.protsenko@linaro.org>
Hi Sam,
On Thu, Jun 20, 2019 at 05:00:01PM +0300, Sam Protsenko wrote:
> As per [1], there is no such fastboot variable as "bootloader-version".
> Only "version-bootloader" is supported. Let's reflect this and not
> confuse users further.
>
FWIW, this could carry a Fixes line?
Fixes: 3aab70afc531d1 ("usb/gadget: add the fastboot gadget")
I strongly believe there are ongoing attempts/projects to build
relationships/dependencies between commits, which would help in the
context of bug prediction. Code Maat [2] comes to mind, but there could
be better examples.
> [1] https://android.googlesource.com/platform/system/core/+/master/fastboot/README.md#client-variables
[2] https://github.com/adamtornhill/code-maat
In case AOSP gives it a second thought and drops or renames the
"is-userspace" option or the Client Variables section (both unlikely,
but possible), then the link will point to the wrong contents. This
happened to me in the past, but I am lazy to look for some records.
[..]
> diff --git a/doc/README.android-fastboot b/doc/README.android-fastboot
> index 431191c473..ce852a4fd1 100644
> --- a/doc/README.android-fastboot
> +++ b/doc/README.android-fastboot
> @@ -169,8 +169,8 @@ On the client side you can fetch the bootloader version for instance:
>
> ::
>
> - $ fastboot getvar bootloader-version
> - bootloader-version: U-Boot 2014.04-00005-gd24cabc
> + $ fastboot getvar version-bootloader
> + version-bootloader: U-Boot 2014.04-00005-gd24cabc
I am afraid this may introduce confusion, specifically that v2014.04+
(more precisely v2014.04-207-g3aab70afc531) U-Boot responded properly
to 'fastboot getvar version-bootloader'. Please, feel free to ignore.
[..]
> @@ -37,12 +37,9 @@ static const struct {
> {
> .variable = "version",
> .dispatch = getvar_version
> - }, {
> - .variable = "bootloader-version",
> - .dispatch = getvar_bootloader_version
> }, {
On one hand, I agree with Igor that certain users might be hurt by
this change. On the other hand, it sounds good not to spend time and
effort maintaining non-AOSP options, added to U-Boot by accident.
Reviewed-by: Eugeniu Rosca <erosca@de.adit-jv.com>
Thanks!
--
Best Regards,
Eugeniu.
next prev parent reply other threads:[~2019-06-25 22:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 14:00 [U-Boot] [PATCH] fastboot: Remove "bootloader-version" variable Sam Protsenko
2019-06-20 14:54 ` Igor Opaniuk
2019-06-20 16:08 ` Sam Protsenko
2019-06-20 19:14 ` Igor Opaniuk
2019-06-25 22:12 ` Eugeniu Rosca [this message]
2019-07-03 16:34 ` Sam Protsenko
2019-07-04 15:31 ` Eugeniu Rosca
2019-07-04 15:50 ` Eugeniu Rosca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625221212.GA30275@x230 \
--to=roscaeugeniu@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox