From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michal =?UTF-8?B?U3VjaMOhbmVr?= <msuchanek@suse.de>
Date: Tue, 2 Jul 2019 15:04:00 +0200
Subject: [U-Boot] [PATCH 3/8] usb_kdb: only process events succesfully
	received
In-Reply-To: <00f68615-155e-d513-1bae-c03f2d6b8097@denx.de>
References: <5dfc00046742db978f1ae046d8855663ccf7c281.1561996556.git.msuchanek@suse.de>
 <4fd1fdcc59394509236814a45d7cd384794acaae.1561996556.git.msuchanek@suse.de>
 <00f68615-155e-d513-1bae-c03f2d6b8097@denx.de>
Message-ID: <20190702150400.090f85ba@kitsune.suse.cz>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tue, 2 Jul 2019 13:58:30 +0200
Marek Vasut <marex@denx.de> wrote:

> On 7/1/19 5:56 PM, Michal Suchanek wrote:
> > Causes unbound key repeat on error otherwise.
> > 
> > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> > ---
> >  common/usb_kbd.c | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> > 
> > diff --git a/common/usb_kbd.c b/common/usb_kbd.c
> > index cc99c6be0720..948f9fd68490 100644
> > --- a/common/usb_kbd.c
> > +++ b/common/usb_kbd.c
> > @@ -339,10 +339,9 @@ static inline void usb_kbd_poll_for_event(struct usb_device *dev)
> >  	struct usb_kbd_pdata *data = dev->privptr;
> >  
> >  	/* Submit a interrupt transfer request */
> > -	usb_submit_int_msg(dev, data->intpipe, &data->new[0], data->intpktsize,
> > -			   data->intinterval);
> > -
> > -	usb_kbd_irq_worker(dev);
> > +	if (!usb_submit_int_msg(dev, data->intpipe, &data->new[0],  
> 
> Shouldn't you propagate return value from this function ? It can return
> ENOTSUPP.
> 

If it did then probing keyboard would fail and we would not get here.

Thanks

Michal