From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michal =?UTF-8?B?U3VjaMOhbmVr?= <msuchanek@suse.de>
Date: Tue, 2 Jul 2019 16:25:07 +0200
Subject: [U-Boot] [PATCH 6/8] usb: add usb_submit_int_msg_nonblock
In-Reply-To: <CAEUhbmXZqc-fjy96+AGenN+=gmjrUseuyu+N1qA0zQqHnfLg4Q@mail.gmail.com>
References: <5dfc00046742db978f1ae046d8855663ccf7c281.1561996556.git.msuchanek@suse.de>
 <28844f682ed31648b5f0d812aeff18b2458baa6c.1561996556.git.msuchanek@suse.de>
 <8a0869a4-9c7c-9a12-e7b1-2bbf1ec17c4e@denx.de>
 <20190702161411.0dd6a80b@kitsune.suse.cz>
 <CAEUhbmXZqc-fjy96+AGenN+=gmjrUseuyu+N1qA0zQqHnfLg4Q@mail.gmail.com>
Message-ID: <20190702162507.2c772d7b@kitsune.suse.cz>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
To: u-boot@lists.denx.de

On Tue, 2 Jul 2019 22:16:02 +0800
Bin Meng <bmeng.cn@gmail.com> wrote:

> Hi Michal,
>=20
> On Tue, Jul 2, 2019 at 10:14 PM Michal Such=C3=A1nek <msuchanek@suse.de> =
wrote:
> >
> > On Tue, 2 Jul 2019 13:59:49 +0200
> > Marek Vasut <marex@denx.de> wrote:
> > =20
> > > On 7/1/19 5:56 PM, Michal Suchanek wrote: =20
> > > > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> > > > ---
> > > >  common/usb.c  | 9 +++++++++
> > > >  include/usb.h | 2 ++
> > > >  2 files changed, 11 insertions(+)
> > > >
> > > > diff --git a/common/usb.c b/common/usb.c
> > > > index 3ae71c98aaf4..d8302d39a91a 100644
> > > > --- a/common/usb.c
> > > > +++ b/common/usb.c
> > > > @@ -200,6 +200,15 @@ int usb_submit_int_msg(struct usb_device *dev,=
 unsigned long pipe,
> > > >     return submit_int_msg(dev, pipe, buffer, transfer_len, interval=
, false);
> > > >  }
> > > >
> > > > +/*
> > > > + * submits an Interrupt Message without retry
> > > > + */
> > > > +int usb_submit_int_msg_nonblock(struct usb_device *dev, unsigned l=
ong pipe,
> > > > +                   void *buffer, int transfer_len, int interval)
> > > > +{
> > > > +   return submit_int_msg(dev, pipe, buffer, transfer_len, interval=
, true);
> > > > +} =20
> > >
> > > Is this wrapper really necessary ?
> > > =20
> >
> > Avoids changing other users of the code. Not that there are that many,
> > anyway. =20
>=20
> Then I wonder why not change your codes to call submit_int_msg() instead?
>=20
Why do we have usb_submit_int_msg in the first place?

Thanks

Michal