[U-Boot] [PATCH 0/6] Extend mv88e61xx driver to support 88E6071

[U-Boot] [PATCH 0/6] Extend mv88e61xx driver to support 88E6071

[Anatolij Gustschin]

This series adds support for 88E6071 switches in the mv88e61xx
driver.

Anatolij Gustschin (6):
  net: phy: mv88e61xx: rework to enable detection of 88E6071 devices
  net: phy: mv88e61xx: add CPU port parameter init for 88E6071
  net: phy: mv88E61xx: fix ENERGY_DET init for mv88E6071
  net: phy: mv88E61xx: add config option for mv88E6071 support
  net: phy: mv88e61xx: register phy_driver struct for 88E6071
  net: phy: fix switch vendor name

 drivers/net/phy/Kconfig     |   9 +-
 drivers/net/phy/mv88e61xx.c | 166 +++++++++++++++++++++++++++---------
 2 files changed, 135 insertions(+), 40 deletions(-)

-- 
2.17.1

[U-Boot] [PATCH 1/6] net: phy: mv88e61xx: rework to enable detection of 88E6071 devices

[Anatolij Gustschin]

Extend the driver to init switch register offsets from variables
instead of compile time macros and enable 88E6071 detection.
Ethernet transfer (e.g. tftp) does not work yet, so enable the
registration of the 'indirect mii' bus for easier PHY register
access by 'mii' command.

Signed-off-by: Anatolij Gustschin <agust@denx.de>
---
 drivers/net/phy/mv88e61xx.c | 93 +++++++++++++++++++++++++++++--------
 1 file changed, 74 insertions(+), 19 deletions(-)

diff --git a/drivers/net/phy/mv88e61xx.c b/drivers/net/phy/mv88e61xx.c
index c1e2860329..6abb9ec7df 100644
--- a/drivers/net/phy/mv88e61xx.c
+++ b/drivers/net/phy/mv88e61xx.c
@@ -39,15 +39,12 @@
 
 #define PHY_AUTONEGOTIATE_TIMEOUT	5000
 
-#define PORT_COUNT			11
-#define PORT_MASK			((1 << PORT_COUNT) - 1)
+#define PORT_MASK(port_count)		((1 << (port_count)) - 1)
 
 /* Device addresses */
 #define DEVADDR_PHY(p)			(p)
-#define DEVADDR_PORT(p)			(0x10 + (p))
+#define DEVADDR_PORT(p)			(priv->port_reg_base + (p))
 #define DEVADDR_SERDES			0x0F
-#define DEVADDR_GLOBAL_1		0x1B
-#define DEVADDR_GLOBAL_2		0x1C
 
 /* SMI indirection registers for multichip addressing mode */
 #define SMI_CMD_REG			0x00
@@ -188,11 +185,16 @@
 #define PORT_SWITCH_ID_6176		0x1760
 #define PORT_SWITCH_ID_6240		0x2400
 #define PORT_SWITCH_ID_6352		0x3520
+#define PORT_SWITCH_ID_6071		0x0710
 
 struct mv88e61xx_phy_priv {
 	struct mii_dev *mdio_bus;
 	int smi_addr;
 	int id;
+	int port_count;
+	int port_reg_base;
+	u8 global1;
+	u8 global2;
 };
 
 static inline int smi_cmd(int cmd, int addr, int reg)
@@ -329,11 +331,12 @@ static int mv88e61xx_reg_write(struct phy_device *phydev, int dev, int reg,
 
 static int mv88e61xx_phy_wait(struct phy_device *phydev)
 {
+	struct mv88e61xx_phy_priv *priv = phydev->priv;
 	int val;
 	u32 timeout = 100;
 
 	do {
-		val = mv88e61xx_reg_read(phydev, DEVADDR_GLOBAL_2,
+		val = mv88e61xx_reg_read(phydev, priv->global2,
 					 GLOBAL2_REG_PHY_CMD);
 		if (val >= 0 && (val & SMI_BUSY) == 0)
 			return 0;
@@ -347,13 +350,15 @@ static int mv88e61xx_phy_wait(struct phy_device *phydev)
 static int mv88e61xx_phy_read_indirect(struct mii_dev *smi_wrapper, int dev,
 		int devad, int reg)
 {
+	struct mv88e61xx_phy_priv *priv;
 	struct phy_device *phydev;
 	int res;
 
 	phydev = (struct phy_device *)smi_wrapper->priv;
+	priv = phydev->priv;
 
 	/* Issue command to read */
-	res = mv88e61xx_reg_write(phydev, DEVADDR_GLOBAL_2,
+	res = mv88e61xx_reg_write(phydev, priv->global2,
 				  GLOBAL2_REG_PHY_CMD,
 				  smi_cmd_read(dev, reg));
 
@@ -363,25 +368,27 @@ static int mv88e61xx_phy_read_indirect(struct mii_dev *smi_wrapper, int dev,
 		return res;
 
 	/* Read retrieved data */
-	return mv88e61xx_reg_read(phydev, DEVADDR_GLOBAL_2,
+	return mv88e61xx_reg_read(phydev, priv->global2,
 				  GLOBAL2_REG_PHY_DATA);
 }
 
 static int mv88e61xx_phy_write_indirect(struct mii_dev *smi_wrapper, int dev,
 		int devad, int reg, u16 data)
 {
+	struct mv88e61xx_phy_priv *priv;
 	struct phy_device *phydev;
 	int res;
 
 	phydev = (struct phy_device *)smi_wrapper->priv;
+	priv = phydev->priv;
 
 	/* Set the data to write */
-	res = mv88e61xx_reg_write(phydev, DEVADDR_GLOBAL_2,
+	res = mv88e61xx_reg_write(phydev, priv->global2,
 				  GLOBAL2_REG_PHY_DATA, data);
 	if (res < 0)
 		return res;
 	/* Issue the write command */
-	res = mv88e61xx_reg_write(phydev, DEVADDR_GLOBAL_2,
+	res = mv88e61xx_reg_write(phydev, priv->global2,
 				  GLOBAL2_REG_PHY_CMD,
 				  smi_cmd_write(dev, reg));
 	if (res < 0)
@@ -408,12 +415,14 @@ static int mv88e61xx_phy_write(struct phy_device *phydev, int phy,
 
 static int mv88e61xx_port_read(struct phy_device *phydev, u8 port, u8 reg)
 {
+	struct mv88e61xx_phy_priv *priv = phydev->priv;
 	return mv88e61xx_reg_read(phydev, DEVADDR_PORT(port), reg);
 }
 
 static int mv88e61xx_port_write(struct phy_device *phydev, u8 port, u8 reg,
 								u16 val)
 {
+	struct mv88e61xx_phy_priv *priv = phydev->priv;
 	return mv88e61xx_reg_write(phydev, DEVADDR_PORT(port), reg, val);
 }
 
@@ -515,12 +524,13 @@ static int mv88e61xx_parse_status(struct phy_device *phydev)
 
 static int mv88e61xx_switch_reset(struct phy_device *phydev)
 {
+	struct mv88e61xx_phy_priv *priv = phydev->priv;
 	int time;
 	int val;
 	u8 port;
 
 	/* Disable all ports */
-	for (port = 0; port < PORT_COUNT; port++) {
+	for (port = 0; port < priv->port_count; port++) {
 		val = mv88e61xx_port_read(phydev, port, PORT_REG_CTRL);
 		if (val < 0)
 			return val;
@@ -536,18 +546,18 @@ static int mv88e61xx_switch_reset(struct phy_device *phydev)
 	udelay(2000);
 
 	/* Reset switch */
-	val = mv88e61xx_reg_read(phydev, DEVADDR_GLOBAL_1, GLOBAL1_CTRL);
+	val = mv88e61xx_reg_read(phydev, priv->global1, GLOBAL1_CTRL);
 	if (val < 0)
 		return val;
 	val |= GLOBAL1_CTRL_SWRESET;
-	val = mv88e61xx_reg_write(phydev, DEVADDR_GLOBAL_1,
+	val = mv88e61xx_reg_write(phydev, priv->global1,
 				     GLOBAL1_CTRL, val);
 	if (val < 0)
 		return val;
 
 	/* Wait up to 1 second for switch reset complete */
 	for (time = 1000; time; time--) {
-		val = mv88e61xx_reg_read(phydev, DEVADDR_GLOBAL_1,
+		val = mv88e61xx_reg_read(phydev, priv->global1,
 					    GLOBAL1_CTRL);
 		if (val >= 0 && ((val & GLOBAL1_CTRL_SWRESET) == 0))
 			break;
@@ -732,22 +742,23 @@ static int mv88e61xx_fixed_port_setup(struct phy_device *phydev, u8 port)
 
 static int mv88e61xx_set_cpu_port(struct phy_device *phydev)
 {
+	struct mv88e61xx_phy_priv *priv = phydev->priv;
 	int val;
 
 	/* Set CPUDest */
-	val = mv88e61xx_reg_read(phydev, DEVADDR_GLOBAL_1, GLOBAL1_MON_CTRL);
+	val = mv88e61xx_reg_read(phydev, priv->global1, GLOBAL1_MON_CTRL);
 	if (val < 0)
 		return val;
 	val = bitfield_replace(val, GLOBAL1_MON_CTRL_CPUDEST_SHIFT,
 			       GLOBAL1_MON_CTRL_CPUDEST_WIDTH,
 			       CONFIG_MV88E61XX_CPU_PORT);
-	val = mv88e61xx_reg_write(phydev, DEVADDR_GLOBAL_1,
+	val = mv88e61xx_reg_write(phydev, priv->global1,
 				     GLOBAL1_MON_CTRL, val);
 	if (val < 0)
 		return val;
 
 	/* Allow CPU to route to any port */
-	val = PORT_MASK & ~(1 << CONFIG_MV88E61XX_CPU_PORT);
+	val = PORT_MASK(priv->port_count) & ~(1 << CONFIG_MV88E61XX_CPU_PORT);
 	val = mv88e61xx_port_set_vlan(phydev, CONFIG_MV88E61XX_CPU_PORT, val);
 	if (val < 0)
 		return val;
@@ -856,6 +867,24 @@ static int mv88e61xx_phy_config_port(struct phy_device *phydev, u8 phy)
 	return 0;
 }
 
+static void mv88e61xx_priv_reg_offs_pre_init(struct mv88e61xx_phy_priv *priv)
+{
+	/*
+	 * Initial 'port_reg_base' value must be in the port register,
+	 * map and the global_N register offsets must be correct,
+	 * otherwise detection of switch ID won't work!
+	 */
+#ifndef CONFIG_MV88E61XX_88E6020_FAMILY
+	priv->global1 = 0x1B;
+	priv->global2 = 0x1C;
+	priv->port_reg_base = 0x10;
+#else
+	priv->global1 = 0x0F;
+	priv->global2 = 0x07;
+	priv->port_reg_base = 0x08;
+#endif
+}
+
 static int mv88e61xx_probe(struct phy_device *phydev)
 {
 	struct mii_dev *smi_wrapper;
@@ -910,13 +939,36 @@ static int mv88e61xx_probe(struct phy_device *phydev)
 
 	phydev->priv = priv;
 
+	mv88e61xx_priv_reg_offs_pre_init(priv);
+
 	priv->id = mv88e61xx_get_switch_id(phydev);
+	debug("%s ID 0x%x\n", __func__, priv->id);
+
+	switch (priv->id) {
+	case PORT_SWITCH_ID_6172:
+	case PORT_SWITCH_ID_6176:
+	case PORT_SWITCH_ID_6240:
+	case PORT_SWITCH_ID_6352:
+		priv->port_count = 11;
+		break;
+	case PORT_SWITCH_ID_6071:
+		priv->port_count = 7;
+		break;
+	default:
+		free(priv);
+		return -ENODEV;
+	}
+
+	res = mdio_register(smi_wrapper);
+	if (res)
+		printf("Failed to register SMI bus\n");
 
 	return 0;
 }
 
 static int mv88e61xx_phy_config(struct phy_device *phydev)
 {
+	struct mv88e61xx_phy_priv *priv = phydev->priv;
 	int res;
 	int i;
 	int ret = -1;
@@ -925,7 +977,7 @@ static int mv88e61xx_phy_config(struct phy_device *phydev)
 	if (res < 0)
 		return res;
 
-	for (i = 0; i < PORT_COUNT; i++) {
+	for (i = 0; i < priv->port_count; i++) {
 		if ((1 << i) & CONFIG_MV88E61XX_PHY_PORTS) {
 			phydev->addr = i;
 
@@ -988,13 +1040,14 @@ static int mv88e61xx_phy_is_connected(struct phy_device *phydev)
 
 static int mv88e61xx_phy_startup(struct phy_device *phydev)
 {
+	struct mv88e61xx_phy_priv *priv = phydev->priv;
 	int i;
 	int link = 0;
 	int res;
 	int speed = phydev->speed;
 	int duplex = phydev->duplex;
 
-	for (i = 0; i < PORT_COUNT; i++) {
+	for (i = 0; i < priv->port_count; i++) {
 		if ((1 << i) & CONFIG_MV88E61XX_PHY_PORTS) {
 			phydev->addr = i;
 			if (!mv88e61xx_phy_is_connected(phydev))
@@ -1068,6 +1121,8 @@ int get_phy_id(struct mii_dev *bus, int smi_addr, int devad, u32 *phy_id)
 	temp_phy.priv = &temp_priv;
 	temp_mii.priv = &temp_phy;
 
+	mv88e61xx_priv_reg_offs_pre_init(&temp_priv);
+
 	val = mv88e61xx_phy_read_indirect(&temp_mii, 0, devad, MII_PHYSID1);
 	if (val < 0)
 		return -EIO;
-- 
2.17.1

[U-Boot] [PATCH 1/6] net: phy: mv88e61xx: rework to enable detection of 88E6071 devices

[Chris Packham]

Hi Anatolij,

On Tue, Jul 9, 2019 at 1:06 AM Anatolij Gustschin <agust@denx.de> wrote:
>
> Extend the driver to init switch register offsets from variables
> instead of compile time macros and enable 88E6071 detection.
> Ethernet transfer (e.g. tftp) does not work yet, so enable the
> registration of the 'indirect mii' bus for easier PHY register
> access by 'mii' command.
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> ---
>  drivers/net/phy/mv88e61xx.c | 93 +++++++++++++++++++++++++++++--------
>  1 file changed, 74 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/net/phy/mv88e61xx.c b/drivers/net/phy/mv88e61xx.c
> index c1e2860329..6abb9ec7df 100644
> --- a/drivers/net/phy/mv88e61xx.c
> +++ b/drivers/net/phy/mv88e61xx.c
> @@ -39,15 +39,12 @@
>
>  #define PHY_AUTONEGOTIATE_TIMEOUT      5000
>
> -#define PORT_COUNT                     11
> -#define PORT_MASK                      ((1 << PORT_COUNT) - 1)
> +#define PORT_MASK(port_count)          ((1 << (port_count)) - 1)
>
>  /* Device addresses */
>  #define DEVADDR_PHY(p)                 (p)
> -#define DEVADDR_PORT(p)                        (0x10 + (p))
> +#define DEVADDR_PORT(p)                        (priv->port_reg_base + (p))
>  #define DEVADDR_SERDES                 0x0F
> -#define DEVADDR_GLOBAL_1               0x1B
> -#define DEVADDR_GLOBAL_2               0x1C
>
>  /* SMI indirection registers for multichip addressing mode */
>  #define SMI_CMD_REG                    0x00
> @@ -188,11 +185,16 @@
>  #define PORT_SWITCH_ID_6176            0x1760
>  #define PORT_SWITCH_ID_6240            0x2400
>  #define PORT_SWITCH_ID_6352            0x3520
> +#define PORT_SWITCH_ID_6071            0x0710
>
>  struct mv88e61xx_phy_priv {
>         struct mii_dev *mdio_bus;
>         int smi_addr;
>         int id;
> +       int port_count;
> +       int port_reg_base;
> +       u8 global1;
> +       u8 global2;
>  };
>
>  static inline int smi_cmd(int cmd, int addr, int reg)
> @@ -329,11 +331,12 @@ static int mv88e61xx_reg_write(struct phy_device *phydev, int dev, int reg,
>
>  static int mv88e61xx_phy_wait(struct phy_device *phydev)
>  {
> +       struct mv88e61xx_phy_priv *priv = phydev->priv;
>         int val;
>         u32 timeout = 100;
>
>         do {
> -               val = mv88e61xx_reg_read(phydev, DEVADDR_GLOBAL_2,
> +               val = mv88e61xx_reg_read(phydev, priv->global2,
>                                          GLOBAL2_REG_PHY_CMD);
>                 if (val >= 0 && (val & SMI_BUSY) == 0)
>                         return 0;
> @@ -347,13 +350,15 @@ static int mv88e61xx_phy_wait(struct phy_device *phydev)
>  static int mv88e61xx_phy_read_indirect(struct mii_dev *smi_wrapper, int dev,
>                 int devad, int reg)
>  {
> +       struct mv88e61xx_phy_priv *priv;
>         struct phy_device *phydev;
>         int res;
>
>         phydev = (struct phy_device *)smi_wrapper->priv;
> +       priv = phydev->priv;
>
>         /* Issue command to read */
> -       res = mv88e61xx_reg_write(phydev, DEVADDR_GLOBAL_2,
> +       res = mv88e61xx_reg_write(phydev, priv->global2,
>                                   GLOBAL2_REG_PHY_CMD,
>                                   smi_cmd_read(dev, reg));
>
> @@ -363,25 +368,27 @@ static int mv88e61xx_phy_read_indirect(struct mii_dev *smi_wrapper, int dev,
>                 return res;
>
>         /* Read retrieved data */
> -       return mv88e61xx_reg_read(phydev, DEVADDR_GLOBAL_2,
> +       return mv88e61xx_reg_read(phydev, priv->global2,
>                                   GLOBAL2_REG_PHY_DATA);
>  }
>
>  static int mv88e61xx_phy_write_indirect(struct mii_dev *smi_wrapper, int dev,
>                 int devad, int reg, u16 data)
>  {
> +       struct mv88e61xx_phy_priv *priv;
>         struct phy_device *phydev;
>         int res;
>
>         phydev = (struct phy_device *)smi_wrapper->priv;
> +       priv = phydev->priv;
>
>         /* Set the data to write */
> -       res = mv88e61xx_reg_write(phydev, DEVADDR_GLOBAL_2,
> +       res = mv88e61xx_reg_write(phydev, priv->global2,
>                                   GLOBAL2_REG_PHY_DATA, data);
>         if (res < 0)
>                 return res;
>         /* Issue the write command */
> -       res = mv88e61xx_reg_write(phydev, DEVADDR_GLOBAL_2,
> +       res = mv88e61xx_reg_write(phydev, priv->global2,
>                                   GLOBAL2_REG_PHY_CMD,
>                                   smi_cmd_write(dev, reg));
>         if (res < 0)
> @@ -408,12 +415,14 @@ static int mv88e61xx_phy_write(struct phy_device *phydev, int phy,
>
>  static int mv88e61xx_port_read(struct phy_device *phydev, u8 port, u8 reg)
>  {
> +       struct mv88e61xx_phy_priv *priv = phydev->priv;
>         return mv88e61xx_reg_read(phydev, DEVADDR_PORT(port), reg);
>  }
>
>  static int mv88e61xx_port_write(struct phy_device *phydev, u8 port, u8 reg,
>                                                                 u16 val)
>  {
> +       struct mv88e61xx_phy_priv *priv = phydev->priv;
>         return mv88e61xx_reg_write(phydev, DEVADDR_PORT(port), reg, val);
>  }
>
> @@ -515,12 +524,13 @@ static int mv88e61xx_parse_status(struct phy_device *phydev)
>
>  static int mv88e61xx_switch_reset(struct phy_device *phydev)
>  {
> +       struct mv88e61xx_phy_priv *priv = phydev->priv;
>         int time;
>         int val;
>         u8 port;
>
>         /* Disable all ports */
> -       for (port = 0; port < PORT_COUNT; port++) {
> +       for (port = 0; port < priv->port_count; port++) {
>                 val = mv88e61xx_port_read(phydev, port, PORT_REG_CTRL);
>                 if (val < 0)
>                         return val;
> @@ -536,18 +546,18 @@ static int mv88e61xx_switch_reset(struct phy_device *phydev)
>         udelay(2000);
>
>         /* Reset switch */
> -       val = mv88e61xx_reg_read(phydev, DEVADDR_GLOBAL_1, GLOBAL1_CTRL);
> +       val = mv88e61xx_reg_read(phydev, priv->global1, GLOBAL1_CTRL);
>         if (val < 0)
>                 return val;
>         val |= GLOBAL1_CTRL_SWRESET;
> -       val = mv88e61xx_reg_write(phydev, DEVADDR_GLOBAL_1,
> +       val = mv88e61xx_reg_write(phydev, priv->global1,
>                                      GLOBAL1_CTRL, val);
>         if (val < 0)
>                 return val;
>
>         /* Wait up to 1 second for switch reset complete */
>         for (time = 1000; time; time--) {
> -               val = mv88e61xx_reg_read(phydev, DEVADDR_GLOBAL_1,
> +               val = mv88e61xx_reg_read(phydev, priv->global1,
>                                             GLOBAL1_CTRL);
>                 if (val >= 0 && ((val & GLOBAL1_CTRL_SWRESET) == 0))
>                         break;
> @@ -732,22 +742,23 @@ static int mv88e61xx_fixed_port_setup(struct phy_device *phydev, u8 port)
>
>  static int mv88e61xx_set_cpu_port(struct phy_device *phydev)
>  {
> +       struct mv88e61xx_phy_priv *priv = phydev->priv;
>         int val;
>
>         /* Set CPUDest */
> -       val = mv88e61xx_reg_read(phydev, DEVADDR_GLOBAL_1, GLOBAL1_MON_CTRL);
> +       val = mv88e61xx_reg_read(phydev, priv->global1, GLOBAL1_MON_CTRL);
>         if (val < 0)
>                 return val;
>         val = bitfield_replace(val, GLOBAL1_MON_CTRL_CPUDEST_SHIFT,
>                                GLOBAL1_MON_CTRL_CPUDEST_WIDTH,
>                                CONFIG_MV88E61XX_CPU_PORT);
> -       val = mv88e61xx_reg_write(phydev, DEVADDR_GLOBAL_1,
> +       val = mv88e61xx_reg_write(phydev, priv->global1,
>                                      GLOBAL1_MON_CTRL, val);
>         if (val < 0)
>                 return val;
>
>         /* Allow CPU to route to any port */
> -       val = PORT_MASK & ~(1 << CONFIG_MV88E61XX_CPU_PORT);
> +       val = PORT_MASK(priv->port_count) & ~(1 << CONFIG_MV88E61XX_CPU_PORT);
>         val = mv88e61xx_port_set_vlan(phydev, CONFIG_MV88E61XX_CPU_PORT, val);
>         if (val < 0)
>                 return val;
> @@ -856,6 +867,24 @@ static int mv88e61xx_phy_config_port(struct phy_device *phydev, u8 phy)
>         return 0;
>  }
>
> +static void mv88e61xx_priv_reg_offs_pre_init(struct mv88e61xx_phy_priv *priv)
> +{
> +       /*
> +        * Initial 'port_reg_base' value must be in the port register,
> +        * map and the global_N register offsets must be correct,
> +        * otherwise detection of switch ID won't work!
> +        */
> +#ifndef CONFIG_MV88E61XX_88E6020_FAMILY
> +       priv->global1 = 0x1B;
> +       priv->global2 = 0x1C;
> +       priv->port_reg_base = 0x10;
> +#else
> +       priv->global1 = 0x0F;
> +       priv->global2 = 0x07;
> +       priv->port_reg_base = 0x08;
> +#endif
> +}
> +
>  static int mv88e61xx_probe(struct phy_device *phydev)
>  {
>         struct mii_dev *smi_wrapper;
> @@ -910,13 +939,36 @@ static int mv88e61xx_probe(struct phy_device *phydev)
>
>         phydev->priv = priv;
>
> +       mv88e61xx_priv_reg_offs_pre_init(priv);
> +
>         priv->id = mv88e61xx_get_switch_id(phydev);
> +       debug("%s ID 0x%x\n", __func__, priv->id);
> +
> +       switch (priv->id) {
> +       case PORT_SWITCH_ID_6172:
> +       case PORT_SWITCH_ID_6176:
> +       case PORT_SWITCH_ID_6240:
> +       case PORT_SWITCH_ID_6352:

6096 and 6097 are missing. These both have 11 ports (8x10/100M with
integrated PHY and 3 x 1G with external PHY).

> +               priv->port_count = 11;
> +               break;
> +       case PORT_SWITCH_ID_6071:
> +               priv->port_count = 7;
> +               break;
> +       default:
> +               free(priv);
> +               return -ENODEV;
> +       }
> +
> +       res = mdio_register(smi_wrapper);
> +       if (res)
> +               printf("Failed to register SMI bus\n");
>
>         return 0;
>  }
>
>  static int mv88e61xx_phy_config(struct phy_device *phydev)
>  {
> +       struct mv88e61xx_phy_priv *priv = phydev->priv;
>         int res;
>         int i;
>         int ret = -1;
> @@ -925,7 +977,7 @@ static int mv88e61xx_phy_config(struct phy_device *phydev)
>         if (res < 0)
>                 return res;
>
> -       for (i = 0; i < PORT_COUNT; i++) {
> +       for (i = 0; i < priv->port_count; i++) {
>                 if ((1 << i) & CONFIG_MV88E61XX_PHY_PORTS) {
>                         phydev->addr = i;
>
> @@ -988,13 +1040,14 @@ static int mv88e61xx_phy_is_connected(struct phy_device *phydev)
>
>  static int mv88e61xx_phy_startup(struct phy_device *phydev)
>  {
> +       struct mv88e61xx_phy_priv *priv = phydev->priv;
>         int i;
>         int link = 0;
>         int res;
>         int speed = phydev->speed;
>         int duplex = phydev->duplex;
>
> -       for (i = 0; i < PORT_COUNT; i++) {
> +       for (i = 0; i < priv->port_count; i++) {
>                 if ((1 << i) & CONFIG_MV88E61XX_PHY_PORTS) {
>                         phydev->addr = i;
>                         if (!mv88e61xx_phy_is_connected(phydev))
> @@ -1068,6 +1121,8 @@ int get_phy_id(struct mii_dev *bus, int smi_addr, int devad, u32 *phy_id)
>         temp_phy.priv = &temp_priv;
>         temp_mii.priv = &temp_phy;
>
> +       mv88e61xx_priv_reg_offs_pre_init(&temp_priv);
> +
>         val = mv88e61xx_phy_read_indirect(&temp_mii, 0, devad, MII_PHYSID1);
>         if (val < 0)
>                 return -EIO;
> --
> 2.17.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 1/6] net: phy: mv88e61xx: rework to enable detection of 88E6071 devices

[Anatolij Gustschin]

Hi Chris,

On Tue, 9 Jul 2019 19:34:37 +1200
Chris Packham judge.packham at gmail.com wrote:

> >         priv->id = mv88e61xx_get_switch_id(phydev);
> > +       debug("%s ID 0x%x\n", __func__, priv->id);
> > +
> > +       switch (priv->id) {
> > +       case PORT_SWITCH_ID_6172:
> > +       case PORT_SWITCH_ID_6176:
> > +       case PORT_SWITCH_ID_6240:
> > +       case PORT_SWITCH_ID_6352:  
> 
> 6096 and 6097 are missing. These both have 11 ports (8x10/100M with
> integrated PHY and 3 x 1G with external PHY).

Thanks for review! I didn't notice it, will extend in v2 series.

Thanks,
Anatolij

[U-Boot] [PATCH 2/6] net: phy: mv88e61xx: add CPU port parameter init for 88E6071

[Anatolij Gustschin]

On 88E6071 chip the port status register bit field offsets
for duplex and link bits differ. Extend the driver to use
88E6071 specific offset values. The width of bit fields for
speed status differ, too. Adapt for proper port speed
detection on 88E6071.

Signed-off-by: Anatolij Gustschin <agust@denx.de>
---
 drivers/net/phy/mv88e61xx.c | 41 +++++++++++++++++++++++++------------
 1 file changed, 28 insertions(+), 13 deletions(-)

diff --git a/drivers/net/phy/mv88e61xx.c b/drivers/net/phy/mv88e61xx.c
index 6abb9ec7df..79137f6080 100644
--- a/drivers/net/phy/mv88e61xx.c
+++ b/drivers/net/phy/mv88e61xx.c
@@ -85,9 +85,6 @@
 #define GLOBAL1_MON_CTRL_CPUDEST_SHIFT	4
 #define GLOBAL1_MON_CTRL_CPUDEST_WIDTH	4
 
-#define PORT_REG_STATUS_LINK		BIT(11)
-#define PORT_REG_STATUS_DUPLEX		BIT(10)
-
 #define PORT_REG_STATUS_SPEED_SHIFT	8
 #define PORT_REG_STATUS_SPEED_WIDTH	2
 #define PORT_REG_STATUS_SPEED_10	0
@@ -108,6 +105,7 @@
 #define PORT_REG_PHYS_CTRL_DUPLEX_VALUE	BIT(3)
 #define PORT_REG_PHYS_CTRL_DUPLEX_FORCE	BIT(2)
 #define PORT_REG_PHYS_CTRL_SPD1000	BIT(1)
+#define PORT_REG_PHYS_CTRL_SPD100	BIT(0)
 #define PORT_REG_PHYS_CTRL_SPD_MASK	(BIT(1) | BIT(0))
 
 #define PORT_REG_CTRL_PSTATE_SHIFT	0
@@ -193,6 +191,9 @@ struct mv88e61xx_phy_priv {
 	int id;
 	int port_count;
 	int port_reg_base;
+	u16 port_stat_link_mask;
+	u16 port_stat_dup_mask;
+	u8 port_stat_speed_width;
 	u8 global1;
 	u8 global2;
 };
@@ -638,6 +639,7 @@ static int mv88e61xx_port_set_vlan(struct phy_device *phydev, u8 port,
 
 static int mv88e61xx_read_port_config(struct phy_device *phydev, u8 port)
 {
+	struct mv88e61xx_phy_priv *priv = phydev->priv;
 	int res;
 	int val;
 	bool forced = false;
@@ -645,7 +647,7 @@ static int mv88e61xx_read_port_config(struct phy_device *phydev, u8 port)
 	val = mv88e61xx_port_read(phydev, port, PORT_REG_STATUS);
 	if (val < 0)
 		return val;
-	if (!(val & PORT_REG_STATUS_LINK)) {
+	if (!(val & priv->port_stat_link_mask)) {
 		/* Temporarily force link to read port configuration */
 		u32 timeout = 100;
 		forced = true;
@@ -668,7 +670,7 @@ static int mv88e61xx_read_port_config(struct phy_device *phydev, u8 port)
 				res = -EIO;
 				goto unforce;
 			}
-			if (val & PORT_REG_STATUS_LINK)
+			if (val & priv->port_stat_link_mask)
 				break;
 		} while (--timeout);
 
@@ -678,13 +680,13 @@ static int mv88e61xx_read_port_config(struct phy_device *phydev, u8 port)
 		}
 	}
 
-	if (val & PORT_REG_STATUS_DUPLEX)
+	if (val & priv->port_stat_dup_mask)
 		phydev->duplex = DUPLEX_FULL;
 	else
 		phydev->duplex = DUPLEX_HALF;
 
 	val = bitfield_extract(val, PORT_REG_STATUS_SPEED_SHIFT,
-			       PORT_REG_STATUS_SPEED_WIDTH);
+			       priv->port_stat_speed_width);
 	switch (val) {
 	case PORT_REG_STATUS_SPEED_1000:
 		phydev->speed = SPEED_1000;
@@ -717,6 +719,7 @@ unforce:
 
 static int mv88e61xx_fixed_port_setup(struct phy_device *phydev, u8 port)
 {
+	struct mv88e61xx_phy_priv *priv = phydev->priv;
 	int val;
 
 	val = mv88e61xx_port_read(phydev, port, PORT_REG_PHYS_CTRL);
@@ -724,13 +727,19 @@ static int mv88e61xx_fixed_port_setup(struct phy_device *phydev, u8 port)
 		return val;
 
 	val &= ~(PORT_REG_PHYS_CTRL_SPD_MASK |
-		 PORT_REG_PHYS_CTRL_FC_VALUE);
-	val |= PORT_REG_PHYS_CTRL_PCS_AN_EN |
-	       PORT_REG_PHYS_CTRL_PCS_AN_RST |
-	       PORT_REG_PHYS_CTRL_FC_FORCE |
+		 PORT_REG_PHYS_CTRL_FC_VALUE |
+		 PORT_REG_PHYS_CTRL_FC_FORCE);
+	val |= PORT_REG_PHYS_CTRL_FC_FORCE |
 	       PORT_REG_PHYS_CTRL_DUPLEX_VALUE |
-	       PORT_REG_PHYS_CTRL_DUPLEX_FORCE |
-	       PORT_REG_PHYS_CTRL_SPD1000;
+	       PORT_REG_PHYS_CTRL_DUPLEX_FORCE;
+
+	if (priv->id == PORT_SWITCH_ID_6071) {
+		val |= PORT_REG_PHYS_CTRL_SPD100;
+	} else {
+		val |= PORT_REG_PHYS_CTRL_PCS_AN_EN |
+		       PORT_REG_PHYS_CTRL_PCS_AN_RST |
+		       PORT_REG_PHYS_CTRL_SPD1000;
+	}
 
 	if (port == CONFIG_MV88E61XX_CPU_PORT)
 		val |= PORT_REG_PHYS_CTRL_LINK_VALUE |
@@ -950,9 +959,15 @@ static int mv88e61xx_probe(struct phy_device *phydev)
 	case PORT_SWITCH_ID_6240:
 	case PORT_SWITCH_ID_6352:
 		priv->port_count = 11;
+		priv->port_stat_link_mask = BIT(11);
+		priv->port_stat_dup_mask = BIT(10);
+		priv->port_stat_speed_width = 2;
 		break;
 	case PORT_SWITCH_ID_6071:
 		priv->port_count = 7;
+		priv->port_stat_link_mask = BIT(12);
+		priv->port_stat_dup_mask = BIT(9);
+		priv->port_stat_speed_width = 1;
 		break;
 	default:
 		free(priv);
-- 
2.17.1

[U-Boot] [PATCH 3/6] net: phy: mv88E61xx: fix ENERGY_DET init for mv88E6071

[Anatolij Gustschin]

On mv88E6071 the 'EDet' field offset, width and sense control
bits are different, adjust the driver to init the PHY control
register as needed. This fixes not working link detection and
tftp transfers.

Signed-off-by: Anatolij Gustschin <agust@denx.de>
---
 drivers/net/phy/mv88e61xx.c | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/drivers/net/phy/mv88e61xx.c b/drivers/net/phy/mv88e61xx.c
index 79137f6080..6d10292f11 100644
--- a/drivers/net/phy/mv88e61xx.c
+++ b/drivers/net/phy/mv88e61xx.c
@@ -119,16 +119,12 @@
 
 #define SERDES_REG_CTRL_1_FORCE_LINK	BIT(10)
 
-#define PHY_REG_CTRL1_ENERGY_DET_SHIFT	8
-#define PHY_REG_CTRL1_ENERGY_DET_WIDTH	2
-
 /* Field values */
 #define PORT_REG_CTRL_PSTATE_DISABLED	0
 #define PORT_REG_CTRL_PSTATE_FORWARD	3
 
 #define PHY_REG_CTRL1_ENERGY_DET_OFF	0
 #define PHY_REG_CTRL1_ENERGY_DET_SENSE_ONLY	2
-#define PHY_REG_CTRL1_ENERGY_DET_SENSE_XMIT	3
 
 /* PHY Status Register */
 #define PHY_REG_STATUS1_SPEED		0xc000
@@ -194,6 +190,9 @@ struct mv88e61xx_phy_priv {
 	u16 port_stat_link_mask;
 	u16 port_stat_dup_mask;
 	u8 port_stat_speed_width;
+	u8 phy_ctrl1_en_det_shift;
+	u8 phy_ctrl1_en_det_width;
+	u8 phy_ctrl1_en_det_sense_xmit;
 	u8 global1;
 	u8 global2;
 };
@@ -841,6 +840,7 @@ static int mv88e61xx_phy_enable(struct phy_device *phydev, u8 phy)
 
 static int mv88e61xx_phy_setup(struct phy_device *phydev, u8 phy)
 {
+	struct mv88e61xx_phy_priv *priv = phydev->priv;
 	int val;
 
 	/*
@@ -850,9 +850,9 @@ static int mv88e61xx_phy_setup(struct phy_device *phydev, u8 phy)
 	val = mv88e61xx_phy_read(phydev, phy, PHY_REG_CTRL1);
 	if (val < 0)
 		return val;
-	val = bitfield_replace(val, PHY_REG_CTRL1_ENERGY_DET_SHIFT,
-			       PHY_REG_CTRL1_ENERGY_DET_WIDTH,
-			       PHY_REG_CTRL1_ENERGY_DET_SENSE_XMIT);
+	val = bitfield_replace(val, priv->phy_ctrl1_en_det_shift,
+			       priv->phy_ctrl1_en_det_width,
+			       priv->phy_ctrl1_en_det_sense_xmit);
 	val = mv88e61xx_phy_write(phydev, phy, PHY_REG_CTRL1, val);
 	if (val < 0)
 		return val;
@@ -962,12 +962,18 @@ static int mv88e61xx_probe(struct phy_device *phydev)
 		priv->port_stat_link_mask = BIT(11);
 		priv->port_stat_dup_mask = BIT(10);
 		priv->port_stat_speed_width = 2;
+		priv->phy_ctrl1_en_det_shift = 8;
+		priv->phy_ctrl1_en_det_width = 2;
+		priv->phy_ctrl1_en_det_sense_xmit = 3;
 		break;
 	case PORT_SWITCH_ID_6071:
 		priv->port_count = 7;
 		priv->port_stat_link_mask = BIT(12);
 		priv->port_stat_dup_mask = BIT(9);
 		priv->port_stat_speed_width = 1;
+		priv->phy_ctrl1_en_det_shift = 14;
+		priv->phy_ctrl1_en_det_width = 1;
+		priv->phy_ctrl1_en_det_sense_xmit = 1;
 		break;
 	default:
 		free(priv);
-- 
2.17.1

[U-Boot] [PATCH 4/6] net: phy: mv88E61xx: add config option for mv88E6071 support

[Anatolij Gustschin]

Signed-off-by: Anatolij Gustschin <agust@denx.de>
---
 drivers/net/phy/Kconfig | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index 2a3da068c9..097b499ba3 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -50,6 +50,13 @@ config MV88E61XX_SWITCH
 
 if MV88E61XX_SWITCH
 
+config MV88E61XX_88E6020_FAMILY
+	bool "Marvell MV88E6020 family support."
+	help
+	  The driver supports 6172/6176/6240/6352 devices in the
+	  default configuration. Select this option to enable support
+	  for 6250/6220/6020/6070/6071 switches.
+
 config MV88E61XX_CPU_PORT
 	int "CPU Port"
 
-- 
2.17.1

[U-Boot] [PATCH 5/6] net: phy: mv88e61xx: register phy_driver struct for 88E6071

[Anatolij Gustschin]

Support probing and init for 88E6071 switch.

Signed-off-by: Anatolij Gustschin <agust@denx.de>
---
 drivers/net/phy/mv88e61xx.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/net/phy/mv88e61xx.c b/drivers/net/phy/mv88e61xx.c
index 6d10292f11..b33ad86a90 100644
--- a/drivers/net/phy/mv88e61xx.c
+++ b/drivers/net/phy/mv88e61xx.c
@@ -1114,10 +1114,22 @@ static struct phy_driver mv88e609x_driver = {
 	.shutdown = &genphy_shutdown,
 };
 
+static struct phy_driver mv88e6071_driver = {
+	.name = "Marvell MV88E6071",
+	.uid = 0x1410db0,
+	.mask = 0xfffffff0,
+	.features = PHY_BASIC_FEATURES | SUPPORTED_MII,
+	.probe = mv88e61xx_probe,
+	.config = mv88e61xx_phy_config,
+	.startup = mv88e61xx_phy_startup,
+	.shutdown = &genphy_shutdown,
+};
+
 int phy_mv88e61xx_init(void)
 {
 	phy_register(&mv88e61xx_driver);
 	phy_register(&mv88e609x_driver);
+	phy_register(&mv88e6071_driver);
 
 	return 0;
 }
-- 
2.17.1

[U-Boot] [PATCH 6/6] net: phy: fix switch vendor name

[Anatolij Gustschin]

Fix vendor name in MV88E61xx option description.

Signed-off-by: Anatolij Gustschin <agust@denx.de>
---
 drivers/net/phy/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index 097b499ba3..94386b74ba 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -46,7 +46,7 @@ config B53_PHY_PORTS
 endif # B53_SWITCH
 
 config MV88E61XX_SWITCH
-	bool "Marvel MV88E61xx Ethernet switch PHY support."
+	bool "Marvell MV88E61xx Ethernet switch PHY support."
 
 if MV88E61XX_SWITCH
 
-- 
2.17.1

[U-Boot] [PATCH 0/6] Extend mv88e61xx driver to support 88E6071

[Chris Packham]

On Tue, Jul 9, 2019 at 1:04 AM Anatolij Gustschin <agust@denx.de> wrote:
>
> This series adds support for 88E6071 switches in the mv88e61xx
> driver.
>
> Anatolij Gustschin (6):
>   net: phy: mv88e61xx: rework to enable detection of 88E6071 devices
>   net: phy: mv88e61xx: add CPU port parameter init for 88E6071
>   net: phy: mv88E61xx: fix ENERGY_DET init for mv88E6071
>   net: phy: mv88E61xx: add config option for mv88E6071 support
>   net: phy: mv88e61xx: register phy_driver struct for 88E6071
>   net: phy: fix switch vendor name

I've had a quick look over the series and it looks pretty good. One
comment on 1/6 that needs addressing. I'll see if I can give one of
the Allied Telesis boards with a 6097 a quick spin tomorrow.

>
>  drivers/net/phy/Kconfig     |   9 +-
>  drivers/net/phy/mv88e61xx.c | 166 +++++++++++++++++++++++++++---------
>  2 files changed, 135 insertions(+), 40 deletions(-)
>
> --
> 2.17.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 0/6] Extend mv88e61xx driver to support 88E6071

[Anatolij Gustschin]

On Tue, 9 Jul 2019 19:41:22 +1200
Chris Packham judge.packham at gmail.com wrote:
...
> >   net: phy: mv88e61xx: rework to enable detection of 88E6071 devices
> >   net: phy: mv88e61xx: add CPU port parameter init for 88E6071
> >   net: phy: mv88E61xx: fix ENERGY_DET init for mv88E6071
> >   net: phy: mv88E61xx: add config option for mv88E6071 support
> >   net: phy: mv88e61xx: register phy_driver struct for 88E6071
> >   net: phy: fix switch vendor name  
> 
> I've had a quick look over the series and it looks pretty good. One
> comment on 1/6 that needs addressing. I'll see if I can give one of
> the Allied Telesis boards with a 6097 a quick spin tomorrow.

OK, I'll address the comment and resubmit the series later today.

Thanks,
Anatolij