From mboxrd@z Thu Jan 1 00:00:00 1970 From: AKASHI Takahiro Date: Fri, 12 Jul 2019 09:59:39 +0900 Subject: [U-Boot] [PATCH 1/1] efi_loader: duplicate IMAGE_SUBSYSTEM_EFI_APPLICATION In-Reply-To: <20190711162824.2630-1-xypron.glpk@gmx.de> References: <20190711162824.2630-1-xypron.glpk@gmx.de> Message-ID: <20190712005938.GI21948@linaro.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Heinrich, I wonder why we need "asm-generic/pe.h." If IMAGE_SUBSYSTEM_EFI_APPLICATION can be arch-specific, why not move other definitions, like * relocation types, too? -Takahiro Akashi On Thu, Jul 11, 2019 at 06:28:24PM +0200, Heinrich Schuchardt wrote: > IMAGE_SUBSYSTEM_EFI_APPLICATION is already defined in > include/asm-generic/pe.h which is included in include/pe.h. We should > not define it twice. > > Signed-off-by: Heinrich Schuchardt > --- > include/pe.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/pe.h b/include/pe.h > index 36e1908b7e..c7aeb2dcb6 100644 > --- a/include/pe.h > +++ b/include/pe.h > @@ -48,7 +48,6 @@ typedef struct _IMAGE_DOS_HEADER { > > #define IMAGE_NT_OPTIONAL_HDR32_MAGIC 0x10b > #define IMAGE_NT_OPTIONAL_HDR64_MAGIC 0x20b > -#define IMAGE_SUBSYSTEM_EFI_APPLICATION 10 > > typedef struct _IMAGE_FILE_HEADER { > uint16_t Machine; > -- > 2.20.1 >