From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] efi_loader: duplicate IMAGE_SUBSYSTEM_EFI_APPLICATION
Date: Fri, 12 Jul 2019 15:22:23 +0900 [thread overview]
Message-ID: <20190712062222.GJ21948@linaro.org> (raw)
In-Reply-To: <4e7b1b0f-e015-9a89-e2d4-ed2211d199a8@gmx.de>
On Fri, Jul 12, 2019 at 08:04:59AM +0200, Heinrich Schuchardt wrote:
> On 7/12/19 2:59 AM, AKASHI Takahiro wrote:
> >Heinrich,
> >
> >I wonder why we need "asm-generic/pe.h".
>
> The assembler cannot understand includes that contain C specific syntax.
> So we cannot include "pe.h". This is why "asm-generic/pe.h" has been
> split off.
If so, why not use "#if(n)def __ASSEMBLY__"?
It is a common usage in lots of headers.
-Takahiro Akashi
> >If IMAGE_SUBSYSTEM_EFI_APPLICATION can be arch-specific,
> >why not move other definitions, like * relocation types, too?
>
> We need those symbols in include/asm-generic/pe.h that are used by
> assembler code. IMAGE_SUBSYSTEM_EFI_APPLICATION is not arch-specific but
> it is used in arch/arm/lib/crt0_arm_efi.S and others.
>
> Best regards
>
> Heinrich
>
> >
> >-Takahiro Akashi
> >
> >On Thu, Jul 11, 2019 at 06:28:24PM +0200, Heinrich Schuchardt wrote:
> >>IMAGE_SUBSYSTEM_EFI_APPLICATION is already defined in
> >>include/asm-generic/pe.h which is included in include/pe.h. We should
> >>not define it twice.
> >>
> >>Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> >>---
> >> include/pe.h | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >>diff --git a/include/pe.h b/include/pe.h
> >>index 36e1908b7e..c7aeb2dcb6 100644
> >>--- a/include/pe.h
> >>+++ b/include/pe.h
> >>@@ -48,7 +48,6 @@ typedef struct _IMAGE_DOS_HEADER {
> >>
> >> #define IMAGE_NT_OPTIONAL_HDR32_MAGIC 0x10b
> >> #define IMAGE_NT_OPTIONAL_HDR64_MAGIC 0x20b
> >>-#define IMAGE_SUBSYSTEM_EFI_APPLICATION 10
> >>
> >> typedef struct _IMAGE_FILE_HEADER {
> >> uint16_t Machine;
> >>--
> >>2.20.1
> >>
> >
>
prev parent reply other threads:[~2019-07-12 6:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 16:28 [U-Boot] [PATCH 1/1] efi_loader: duplicate IMAGE_SUBSYSTEM_EFI_APPLICATION Heinrich Schuchardt
2019-07-12 0:59 ` AKASHI Takahiro
2019-07-12 6:04 ` Heinrich Schuchardt
2019-07-12 6:22 ` AKASHI Takahiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712062222.GJ21948@linaro.org \
--to=takahiro.akashi@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox